Fixed
Status Update
No update yet.
Comments
se...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 96cee05bdb8f61a92e4be00a52b991cfc1ed2f4e
Author: Clara Fok <clarafok@google.com>
Date: Wed Mar 01 12:28:09 2023
Add FragmentNavigator test to assert entry destroyed
Add test to assert that NavBackStackEntry is destroyed after being restored upon recreation/configuration change.
Asserts that the fix on this bug also fixes
Test: ./gradlew navigation:navigation-fragment
Bug: 270447657
Change-Id: I8874d2dfaa17e560dd2f6d9da54e435494c187d2
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
https://android-review.googlesource.com/2464422
Branch: androidx-main
commit 96cee05bdb8f61a92e4be00a52b991cfc1ed2f4e
Author: Clara Fok <clarafok@google.com>
Date: Wed Mar 01 12:28:09 2023
Add FragmentNavigator test to assert entry destroyed
Add test to assert that NavBackStackEntry is destroyed after being restored upon recreation/configuration change.
Asserts that the fix on this bug also fixes
Test: ./gradlew navigation:navigation-fragment
Bug: 270447657
Change-Id: I8874d2dfaa17e560dd2f6d9da54e435494c187d2
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
se...@google.com
Fixed by
By attaching fragment observers, restored entries will be destroyed when their fragments are destroyed.
This fix will be available in navigation 2.6.0-alpha07.
il...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-fragment:2.6.0-alpha07
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit da54c9d83ca533316fa95591a59b33eb2903a1e6
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Dec 04 16:39:50 2020
SavedStateHandle#keys() now returns keys of Providers and LiveData-s
Fixes: 174713653
Test: improved SavedStateHandleTest#testKeySet
Change-Id: Ib586038aabe6601cd95e0d74af67f031439cf6ee
M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/SavedStateHandleTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandle.java
https://android-review.googlesource.com/1517919
Branch: androidx-master-dev
commit da54c9d83ca533316fa95591a59b33eb2903a1e6
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Dec 04 16:39:50 2020
SavedStateHandle#keys() now returns keys of Providers and LiveData-s
Fixes: 174713653
Test: improved SavedStateHandleTest#testKeySet
Change-Id: Ib586038aabe6601cd95e0d74af67f031439cf6ee
M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/SavedStateHandleTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandle.java
Description
The keys() method in SavedStateHandle will always include keys for values set via the set() method, but it doesn't include the keys associated with a SavedStateProvider set via setSavedStateProvider() until after state is saved. If you wanted to remove all of the SavedStateProviders by iterating through the keys, whether it would work or not would depend on if state was already saved, which is kind of inconsistent and seems like a bug.