NavBackStackEntries never get destroyed after being restored [270610768]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Feb 23, 2023 10:44PM

Due to the recent changes in Navigation `2.6.0-alpha06`, there is a regression where restored `NavBackStackEntry`s are not `DESTROYED` when the destination is popped. This could cause entries to remain in the `NavigatorState` until the `NavController` is `DESTROYED`.

Comments

ap...@google.com <ap...@google.com> #2Mar 1, 2023 11:50PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 96cee05bdb8f61a92e4be00a52b991cfc1ed2f4e
Author: Clara Fok <clarafok@google.com>
Date: Wed Mar 01 12:28:09 2023

Add FragmentNavigator test to assert entry destroyed

Add test to assert that NavBackStackEntry is destroyed after being restored upon recreation/configuration change.

Asserts that the fix on this bug also fixes

b/270610768

.

Test: ./gradlew navigation:navigation-fragment
Bug: 270447657
Change-Id: I8874d2dfaa17e560dd2f6d9da54e435494c187d2

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt

https://android-review.googlesource.com/2464422

cl...@google.com <cl...@google.com> #3Mar 1, 2023 11:53PM

Fixed by https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2461556.

By attaching fragment observers, restored entries will be destroyed when their fragments are destroyed.

This fix will be available in navigation 2.6.0-alpha07.

na...@google.com <na...@google.com> #4Mar 8, 2023 07:51PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.6.0-alpha07

Issue 270610768

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 1, 2023 11:50PM

cl...@google.com <cl...@google.com> #3Mar 1, 2023 11:53PM

na...@google.com <na...@google.com> #4Mar 8, 2023 07:51PM

Add comment

Issue metadata