Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
I was able to repro locally using the snippet in #1. The slide should never be applied to the content for state == 0, i.e. the green box.
Will take a look. Thanks for the repro steps, Jeremy.
as...@google.com <as...@google.com>
jb...@google.com <jb...@google.com> #3
I'm having an issue with Compose navigation-animation which might be caused by this.
I have two screens: List and Details.
List screen uses default transitions.
Details screen uses the following transitions:
enterTransition = {
slideIntoContainer(
AnimatedContentScope.SlideDirection.Up,
animationSpec = tween(400)
)
},
popExitTransition = {
slideOutOfContainer(
AnimatedContentScope.SlideDirection.Down,
animationSpec = tween(200)
)
},
The video is showing the bug vs expected. It's hard to describe: after clicking the back button before the transition to the Details screen was completed, the List screen moves up a little.
as...@google.com <as...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 7e3b52b20e73c397019f474ab15eb8ea64a872d3
Author: Doris Liu <tianliu@google.com>
Date: Thu Sep 29 18:06:42 2022
Fix incorrect interruption animation in AnimatedContent
Bug: 238662479
Test: included
Change-Id: I86bb98800070f4584e30a1d0a4edec274b0c7e5c
A compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/visualinspection/AnimatedContentWithInterruptions.kt
M compose/animation/animation/src/androidAndroidTest/kotlin/androidx/compose/animation/AnimatedContentTest.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/EnterExitTransition.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedContent.kt
M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/AnimationDemos.kt
https://android-review.googlesource.com/2239235
Branch: androidx-main
commit 7e3b52b20e73c397019f474ab15eb8ea64a872d3
Author: Doris Liu <tianliu@google.com>
Date: Thu Sep 29 18:06:42 2022
Fix incorrect interruption animation in AnimatedContent
Bug: 238662479
Test: included
Change-Id: I86bb98800070f4584e30a1d0a4edec274b0c7e5c
A compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/visualinspection/AnimatedContentWithInterruptions.kt
M compose/animation/animation/src/androidAndroidTest/kotlin/androidx/compose/animation/AnimatedContentTest.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/EnterExitTransition.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedContent.kt
M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/AnimationDemos.kt
ap...@google.com <ap...@google.com> #5
The following release(s) address this bug:
androidx.compose.animation:animation:1.4.0-alpha01
Description
Component used: Navigation Version used: 2.3.2
It has been recommended that using <deeplink> inside an <activity> tag on navigation graph should not be used as it has unintended side effects (as per this issue - https://issuetracker.google.com/issues/174934674 ). Would it be possible to deprecate this feature so that new developers are also aware of this issue? Or a lint warning would also help convey that this is not the correct approach going forward.