Add Lint Warning or Deprecate usages of <deeplink> inside <activity> tag. [178403185]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

fr...@gmail.com

created issue #1

Jan 26, 2021 02:53PM

Component used: Navigation Version used: 2.3.2

It has been recommended that using <deeplink> inside an <activity> tag on navigation graph should not be used as it has unintended side effects (as per this issue - https://issuetracker.google.com/issues/174934674). Would it be possible to deprecate this feature so that new developers are also aware of this issue? Or a lint warning would also help convey that this is not the correct approach going forward.

Comments

il...@google.com <il...@google.com> #2Jan 26, 2021 08:57PM

Assigned to jb...@google.com.

To reproduce the issue. Open a fragment for example then request permission. send the app to background, open it again from recent apps. it will crash with the above exception.

as...@google.com <as...@google.com> Apr 15, 2022 02:36PM

Reassigned to ju...@google.com.

jb...@google.com <jb...@google.com> #3Apr 15, 2022 09:35PM

IMPORTANT: Please try https://developer.android.com/studio/run/device#resolve-usb-issues first. Supply all required information if it is not a USB connection issue, e.g. idea.log (Select Help > Show Log in Finder/Files)

Studio Build: OS: Android Device model number & build number: Android SDK Platform Tools version: Attach the idea.log file via Help > Show Log in Finder.

Steps to Reproduce: 1. 2. 3.

as...@google.com <as...@google.com> #4Apr 18, 2022 01:22PM

This has been fixed already in aosp/1359642 and will be available in Activity 1.2.0-alpha07.

ap...@google.com <ap...@google.com> #5Apr 22, 2022 02:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit cd77b4bbe312dd8892dfbb3c662344d13a96c82d
Author: Julia McClellan <juliamcclellan@google.com>
Date: Thu Apr 14 15:31:46 2022

Deep link in activity destination in navigation lint

Test: Included tests of API version and the lint rule
Bug: 178403185

Change-Id: Ic15a5ec165620b7ef5b3f03538cc83b5576add8d

A navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/DeepLinkInActivityDestinationDetector.kt
A navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/ApiLintVersionsTest.kt
M settings.gradle
A navigation/navigation-runtime-lint/build.gradle
M navigation/navigation-runtime/build.gradle
A navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/NavigationRuntimeIssueRegistry.kt
A navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/DeepLinkInActivityDestinationDetectorTest.kt
A navigation/navigation-runtime-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry

https://android-review.googlesource.com/2064176

il...@google.com <il...@google.com> Apr 25, 2022 10:35PM

Marked as fixed.

Issue 178403185