DialogFragmentCallbacksDetector lint check crashing lint [187524311]

Fixed

Bug

Status Update

No update yet.

Description

mh...@google.com

created issue #1

May 7, 2021 06:02PM

Component used: Fragment Version used: (latest 1.4.0-SNAPSHOT) Devices/Android versions reproduced on: N/A (host lint crash)

A new lint check was added to androidx.fragment (DialogFragmentCallbacksDetector) which is crashing lint when run. It looks like it crashes if a javafile has a class/interface with no supertype?

Here is an abridged stacktrace:

java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)
at java.base/java.util.Objects.checkIndex(Objects.java:372)
at java.base/java.util.ArrayList.get(ArrayList.java:458)
at androidx.fragment.lint.OnCreateDialogIncorrectCallbackDetector$UastHandler.visitClass(OnCreateDialogIncorrectCallbackDetector.kt:84)
...

Full stack trace here. Full chromium compile output here (it's a bit noisy since it crashes on a lot of .java files).

Comments

il...@google.com <il...@google.com> May 7, 2021 06:13PM

Assigned to jb...@google.com.

il...@google.com <il...@google.com> #2May 10, 2021 07:17PM

It seems that this ordering is caused by FragmentManager's addAddedFragments(), which is being removed/reworked as part of b/147749580. It should be straightforward to fix this once that is done, but I'll mark this as being blocked by that issue.

mh...@google.com <mh...@google.com> #3May 10, 2021 07:32PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4ea7d82a7e17dd5a20aa0d581add0ba34874e485
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 20 17:12:55 2020

Ensure fragments move to the expected state in op order

When using the new FragmentStateManager, we
should ensure that fragments move to their expected
state in the same order as the underlying operations -
i.e., in the order that they were added to the
FragmentTransaction.

This ensures that replace()'d fragments are stopped
before their replacement fragments move through
lifecycle methods, avoiding cases where both fragments
are simultaneously started.

Due to how the previous code works, this fix *only*
applies when using the new FragmentStateManager.

Test: new FragmentReorderingTest passes
BUG: 161654580
Change-Id: I32662cf3ec8bc5bd9a232b2572c91b5567a47f2f

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentReorderingTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java

https://android-review.googlesource.com/1367610

ap...@google.com <ap...@google.com> #4May 11, 2021 01:31AM

This has been fixed internally and will be avilable in Fragment 1.3.0-alpha08.

Note: this fix relies on using the new state manager and will not function if it is manually disabled.

jb...@google.com <jb...@google.com> #5May 11, 2021 01:44AM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.4.0-alpha01 release.

jo...@gmail.com <jo...@gmail.com> #6May 24, 2021 04:31PM

I am using 1.4.0-alpha01 of the Fragment Library but I am still getting this error.

il...@google.com <il...@google.com> #7Jun 1, 2021 07:11PM

Re #6 - please file a new bug with a sample that reproduces your error.

de...@gmail.com <de...@gmail.com> #8Jun 12, 2022 12:11PM

Comment has been deleted.

Message last modified on Jun 12, 2022 12:12PM

de...@gmail.com <de...@gmail.com> #9Jun 12, 2022 12:14PM

Still getting this annoying lint error. For some reason this probably happens after updating to AGP 7.4.0-alpha03. The error is pointing to DaggerApplication which is even more confusing