DialogFragmentCallbacksDetector lint check crashing lint [187524311]

Fixed

Bug

Status Update

No update yet.

Description

mh...@google.com

created issue #1

May 7, 2021 06:02PM

Component used: Fragment Version used: (latest 1.4.0-SNAPSHOT) Devices/Android versions reproduced on: N/A (host lint crash)

A new lint check was added to androidx.fragment (DialogFragmentCallbacksDetector) which is crashing lint when run. It looks like it crashes if a javafile has a class/interface with no supertype?

Here is an abridged stacktrace:

java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)
at java.base/java.util.Objects.checkIndex(Objects.java:372)
at java.base/java.util.ArrayList.get(ArrayList.java:458)
at androidx.fragment.lint.OnCreateDialogIncorrectCallbackDetector$UastHandler.visitClass(OnCreateDialogIncorrectCallbackDetector.kt:84)
...

Full stack trace here. Full chromium compile output here (it's a bit noisy since it crashes on a lot of .java files).

Comments

il...@google.com <il...@google.com> May 7, 2021 06:13PM

Assigned to jb...@google.com.

il...@google.com <il...@google.com> #2May 10, 2021 07:17PM

Yes, this is correct. Having individual navigation graphs on each activities overrides or disallow up navigation to the main activity.

mh...@google.com <mh...@google.com> #3May 10, 2021 07:32PM

I believe I have found the potential problem that is causing this:
// @ androidx.navigation.NavController
// line 124

// Now record the pop operation that we were sent
if (!mBackStack.isEmpty()) {
mBackStack.removeLast();
}
// We never want to leave NavGraphs on the top of the stack
while (!mBackStack.isEmpty()
&& mBackStack.peekLast() instanceof NavGraph) {
popBackStack();
}

the condition in while loop is never satisfied because of the above `if` statement above it has already removed the last item of the mBackStack (which was the NavGraph) and thus popBackStack() is never called again.

ap...@google.com <ap...@google.com> #4May 11, 2021 01:31AM

According to Ian Lake, NavigationUI does not support up navigation yet, that is why this is a feature request.

+Pedro Varela - we don't support navigating up through activities as part of NavigationUI yet, please star the feature request:

https://issuetracker.google.com/issues/79993862 (this issue)

jb...@google.com <jb...@google.com> #5May 11, 2021 01:44AM

Marked as fixed.

Ian Lake said Up navigation is not supported through activities, only through fragments.

jo...@gmail.com <jo...@gmail.com> #6May 24, 2021 04:31PM

With the introduction of AppBarConfiguration, this is now possible with the setupActionBarWithNavController method by using an empty set of top level destinations (to always show the up button) and then overriding onSupportNavigateUp() as per the documentation:

https://developer.android.com/topic/libraries/architecture/navigation/navigation-ui#action_bar

I'll leave this bug open as we still need an equivalent API for the Toolbar versions.

il...@google.com <il...@google.com> #7Jun 1, 2021 07:11PM

https://android-review.googlesource.com/846338 adds a setFallbackOnNavigateUpListener method on AppBarConfiguration that allows you to register an OnNavigateUpListener to handle cases where navController.navigateUp() return false.

This allows you to call onSupportNavigateUp() (or super.onSupportNavigateUp() if you're using an ActionBar) from that method to have your Up button transition between activities.

This will be available in 1.0.0-alpha09.

de...@gmail.com <de...@gmail.com> #8Jun 12, 2022 12:11PM

Comment has been deleted.

Message last modified on Jun 12, 2022 12:12PM

de...@gmail.com <de...@gmail.com> #9Jun 12, 2022 12:14PM

Still getting this annoying lint error. For some reason this probably happens after updating to AGP 7.4.0-alpha03. The error is pointing to DaggerApplication which is even more confusing