Incorrect font weight are set for DownloadableFonts on API 29+ [194553426]

Fixed

Bug

Status Update

No update yet.

Description

ri...@gmail.com

created issue #1

Jul 24, 2021 01:22PM

Artifact used: androidx.core:core:1.6.0 Version used: 1.6.0 Theme used: (Not related) Devices/Android versions reproduced on: Pixel 5 Android 11

https://cs.android.com/androidx/platform/frameworks/support/+/c32cc6c885b20be94d2d1c0498e4a978161d3f61:core/core/src/main/java/androidx/core/graphics/TypefaceCompatApi29Impl.java;l=131-136

final FontStyle defaultStyle = new FontStyle(
    (style & Typeface.BOLD) != 0 ? FontStyle.FONT_WEIGHT_BOLD
       : FontStyle.FONT_WEIGHT_NORMAL,
    (style & Typeface.ITALIC) != 0 ? FontStyle.FONT_SLANT_ITALIC
       : FontStyle.FONT_SLANT_UPRIGHT
);

return new Typeface.CustomFallbackBuilder(familyBuilder.build())
    .setStyle(defaultStyle)
    .build();

This part will make the final Typeface lost the correct font-weight from the FontInfo. For example, request for a font with 500 weight, but the final Typeface has 400 weight. This will make the fallback font incorrectly displayed.

The fix is to use the style from the best-matched font, just like the platform, https://cs.android.com/android/platform/superproject/+/android-11.0.0_r1:frameworks/base/graphics/java/android/graphics/Typeface.java;l=276-285.

Comments

ow...@google.com <ow...@google.com> Aug 2, 2021 01:07PM

Assigned to no...@google.com.

ri...@gmail.com <ri...@gmail.com> #2Aug 2, 2021 06:32PM

This should be fixed in 10591065.

se...@google.com <se...@google.com> #3Mar 29, 2022 06:29PM

Reassigned to se...@google.com.

This bug has been verified as fixed. The 'Microphone' setting are saved. Emulator version : 33.1.17-10594030

ap...@google.com <ap...@google.com> #4Mar 30, 2022 08:38AM

I see that your png is making reference to API-34 emulator. Does this means that your team will not fix the problem on API-31. Do not think this is an acceptable solution if so. You must extend the fix to all API's emulators.

Please note that "Pixel 6 Pro API 33" emulator the mic is not working even with mic being enabled.

lo...@gmail.com <lo...@gmail.com> #5Mar 30, 2022 08:59AM

I think this should work on all API levels, you can try the emulator build I referenced in #comment2.

se...@google.com <se...@google.com> #6Mar 30, 2022 03:56PM

I tried on the Emulator "Pixel2 API 31" and it was not working. I enabled the mic settings and powered down the emulator. When I start up the emulator again, the mic settings are all set to disabled.

Do I have to manually update the emulator or recreate the emulator?

se...@google.com <se...@google.com> Jun 29, 2022 04:41PM

Marked as fixed.