Improve Compose in Fragment experience [258046948]

Fixed

Feature Request

Status Update

No update yet.

Description

ch...@google.com

created issue #1

Nov 7, 2022 09:53PM

Using Compose within Fragments require setting a different ViewCompositionStrategy (DisposeOnViewTreeLifecycleDestroyed) so that the composition follows the fragment's view lifecycle. While we do document this behavior in https://developer.android.com/jetpack/compose/interop/interop-apis#composition-strategy it is still a common 'gotcha' that developers frequently run into as per feedback we've received from partners (b/229427938).

To prevent developers from making this mistake, we can improve the DevEx by either:

providing a lint warning when using ComposeView in a fragment (preferred - works for existing implementations)
create a subclass ComposeFragment (less preferred - requires awareness of this new component, also can be confused with fragment-in-compose use case)

Comments

il...@google.com <il...@google.com> #2May 31, 2023 11:32PM

Might be related to

https://issuetracker.google.com/issues/118020865. BTW, I'm using 1.1.0-alpha01.

Project:

https://github.com/SUPERCILEX/Robot-Scouter/tree/2e3100276e5fe2cbad8a2cbb36303694e9f46bbd
Setup: ./gradlew setup

ap...@google.com <ap...@google.com> #3Jan 16, 2024 11:55PM

This is due to a bug in Fragment - using 1.1.0-alpha02 of Preference uses a newer Fragment dependency, and fixes this issue.

ap...@google.com <ap...@google.com> #4Jan 17, 2024 08:27PM

Actually, I just checked and it still crashes using 1.1.0-alpha02.

jb...@google.com <jb...@google.com> #5Jan 17, 2024 08:47PM

Marked as fixed, reassigned to jb...@google.com.

Could you maybe upload a simpler project with reproduction steps? Or at least provide reproduction steps for the project you linked - Does it crash when using Preference 1.0.0?

This still seems suspiciously similar to

https://issuetracker.google.com/issues/120240628, which can not be reproduced with 1.1.0-alpha02 (following the reproduction steps in the first comment).

na...@google.com <na...@google.com> #6Jan 24, 2024 07:53PM

Hi guys. I can also confirm that it still crashes using preferences 1.1.0-alpha02. I ran the barebones sample project included in

https://issuetracker.google.com/issues/120240628 on a Samsung Galaxy J2 Prime running Android 6.0.1.

If I use 1.0.0 version, the NPE issue will not appear. If I use any of the 1.1.0 alphas with/without fragments 1.1.0-alpha02, the NPE issue is there. This issue also exists for MultiSelectListPreference.

Issue 258046948