Android Studio Emulator Network [267647323]

Fixed

Bug

Status Update

No update yet.

Description

do...@gmail.com

created issue #1

Feb 3, 2023 11:38AM

Description has been deleted.

Comments

do...@gmail.com <do...@gmail.com> #2Feb 3, 2023 01:48PM

Great

ml...@google.com <ml...@google.com> Feb 3, 2023 02:50PM

Assigned to an...@google.com.

bo...@google.com <bo...@google.com> Feb 8, 2023 07:22PM

Reassigned to wd...@google.com.

wd...@google.com <wd...@google.com> #3Feb 8, 2023 07:52PM

Project: platform/frameworks/support
Branch: androidx-main

commit a735aaa4d06c90454de772fae5a02f6cbde210b3
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Feb 28 22:58:23 2023

Ensure FragmentNavigator destroys intermediate entries on popUpTo

We need to make sure that when Fragment are destroyed their entries are
also always destroyed.

RelNote: "Fixes a regressions in previous release that caused the wrong
BottomNav menu item to be highlighted when using system back to go
between tabs."
Test: Added FragmentNavigatorTest
Bug: 270447657

Change-Id: I634f6047b7016bcb8b690047605a6f66b2dc1438

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt

https://android-review.googlesource.com/2461556

Message last modified on Feb 8, 2023 07:58PM

do...@gmail.com <do...@gmail.com> #4Feb 9, 2023 09:20AM

This has been fixed internally and will be available in the Navigation 2.6.0-alpha07 release.

pixel2_33.txt

22 KB

View

Download

wd...@google.com <wd...@google.com> #5Feb 9, 2023 03:51PM

Project: platform/frameworks/support
Branch: androidx-main

commit 96cee05bdb8f61a92e4be00a52b991cfc1ed2f4e
Author: Clara Fok <clarafok@google.com>
Date: Wed Mar 01 12:28:09 2023

Add FragmentNavigator test to assert entry destroyed

Add test to assert that NavBackStackEntry is destroyed after being restored upon recreation/configuration change.

Asserts that the fix on this bug also fixes

b/270610768

.

Test: ./gradlew navigation:navigation-fragment
Bug: 270447657
Change-Id: I8874d2dfaa17e560dd2f6d9da54e435494c187d2

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt

https://android-review.googlesource.com/2464422

wd...@google.com <wd...@google.com> #6Feb 9, 2023 04:07PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.6.0-alpha07

ma...@google.com <ma...@google.com> #7Feb 9, 2023 04:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7cf55857f0db6bd1a1e1f95be7374ed5cf3eca58
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 15 16:59:50 2023

Fix system back after popUpTo

After you do a popUpTo inclusive while using Navigation with Fragments,
if you attempt to do a system back call, the Navigation back stack is
never updated.

The reason for this is that when fragment views are DESTROYED, we need
for the observer in the FragmentNavigator to update the state so we know
that the entry was already popped.

RelNote: "When using system back after doing a navigate with popUpTo,
the state of the NavController will pop to the correct entry."
Test: Added OnBackPressedTest
Bug: 270447657

Change-Id: I3a8ec072ba6d1655ab054cc081961825909088e6

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/OnBackPressedTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt

https://android-review.googlesource.com/2493203

Message last modified on Feb 9, 2023 04:35PM

ma...@google.com <ma...@google.com> #8Feb 9, 2023 04:36PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.6.0-alpha08

wd...@google.com <wd...@google.com> #9Feb 9, 2023 08:26PM

Accepted by wd...@google.com.

RE#7 Thanks for the detailed explanation and really appreciate the solution mentioned in

Fixes in order of preference:
(a) The network should 'simply' be fixed to return a non-link local DNS IPv6 address.
(b) Make Android Studio simply ignore fe80::/64 dns servers (strip them out, you'd be left with just 192.168.1.1) - though this may end up with Android Studio networking coming up without any ipv6 connection.
(c) You could in such a case use a hardcoded DNS server - like the Google DNS ips you mentioned in #6.
However, not using the DNS provided by the system is usually something that shouldn't be done (for privacy reasons...)
As such I'd recommend doing (a) and/or (b) and perhaps adding a flag (or config option or something) to manually specify / override the DNS servers to use (perhaps one for ipv4, one for ipv6??).

I think emulator should implement (b) at least and (c) should be only enabled if an option is provided.

Message last modified on Feb 9, 2023 08:26PM

wd...@google.com <wd...@google.com> #10Feb 10, 2023 12:16AM

CL uploaded.

do...@gmail.com <do...@gmail.com> #11Feb 10, 2023 10:45AM

Apparently, the issue has been resolved in Android Emulator 32.1.11-9536276. After updating and restarting AS I see that network works.
However, if I run from CL, network works but log is the same for 32.1.11 with pixel 2 API 33:

VERBOSE | Found 2 DNS servers:
VERBOSE |       fe80::16de:39ff:fe44:5806
VERBOSE |       192.168.1.1

Message last modified on Feb 10, 2023 10:50AM

wd...@google.com <wd...@google.com> #12Feb 10, 2023 02:12PM

RE#11 Ok, let me see what has been changed from build 9456632 to build 9536276. Thanks again for the information.

wd...@google.com <wd...@google.com> #13Mar 13, 2023 09:48PM

RE#11 I found the culprit. It's this CL which basically makes sure that the DNS servers discovered via /etc/resolve.conf are passed into slirp instances. In Android Emulator 32.1.11-9536276, the aforementioned CL was not cherry-picked while in emulator 31.3.15-9456632, the CL was merged. Therefore, the "problematic" link local DNS is passed into emulator 31 release but not emulator 32 release.

Solution: make sure the CL that ignores ipv6 link local DNS goes into in both 31 and 32 release and also make sure CL goes into emulator 32 release.

Message last modified on Mar 13, 2023 09:49PM

wd...@google.com <wd...@google.com> #14Mar 14, 2023 02:56PM

Marked as fixed.

We mark this bug as fixed since the issue is fixed by CL.

For those users who have experienced similar issues, please try emulator 32 stable release.

Message last modified on Mar 14, 2023 03:41PM

go...@gmail.com <go...@gmail.com> #15Jul 19, 2023 10:45AM

i want to install simulators android but i cant install in my laptop.

wd...@google.com <wd...@google.com> #16Aug 28, 2023 02:58PM

RE#15 It seems like this is a different topic if you cannot install android studio on your laptop. Would you like to file a different bug?