2.6.0-alpha05 NavController visibleEntries flow contains many wrong entries [288520638]

Fixed

Bug

Status Update

No update yet.

Description

th...@outlook.com

created issue #1

Jun 23, 2023 12:30PM

Component used: Navigation
Version used: 2.6.0-alpha05 and up (including 2.6.0 stable)
Devices/Android versions reproduced on: Any

In the sample project I try to determine if the home fragment is visible using NavController.visibleEntries. In library version alpha04 it always contains the correct entries, but in alpha05 the list is a hot mess because it keeps growing when navigating and even the host fragment and fragments that are not on the backstack are added to the list. This is not possible in the sample project.

The sample project logs the information for demonstration.

VisibleEntriesBugReport.zip

148 KB

Download

Comments

il...@google.com <il...@google.com> Jun 23, 2023 10:07PM

Assigned to cl...@google.com.

th...@outlook.com <th...@outlook.com> #2Aug 30, 2023 09:57AM

FWIW, I've created a PR on https://github.com/androidx/androidx/pull/636 with a regression test.

il...@google.com <il...@google.com> #3Aug 30, 2023 04:52PM

Project: platform/frameworks/support
Branch: androidx-main

commit 812fe658e564bb57b0bea0ae79946d04e2b85610
Author: Simon Marquis <contact@simon-marquis.fr>
Date: Tue Dec 19 21:46:01 2023

[GH] Fix regression in dynamic labels with non-string typed arguments

Regression introduced in

https://github.com/androidx/androidx/commit/76f9009e6cfc1cba5314cad87a6f1923203c54fa Reported in

https://issuetracker.google.com/issues/316676794

Test: ./gradlew navigation:navigation-ui:cC
Fixes: 316676794

[AndroidX Navigation 2.6.0 broke dynamic app bar title for non String arguments](

https://issuetracker.google.com/issues/316676794)

This is an imported pull request from

https://github.com/androidx/androidx/pull/636.

Resolves #636
Github-Pr-Head-Sha: f455c6d1e641cc72cc1bd371b1f47b7d87ec8eff
GitOrigin-RevId: 3ad8f763f17acb22678f1a87e183ef4e7dac5a9d
Change-Id: I94b4e28bb847632663be32b11e481d13789e8c1b

M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.kt
M navigation/navigation-ui/src/androidTest/java/androidx/navigation/ui/NavigationUITest.kt

https://android-review.googlesource.com/2882895

ap...@google.com <ap...@google.com> #4Sep 7, 2023 05:19PM

Thanks for pointing this out and putting up the PR to fix this! We'll look at doing a Navigation 2.7.7 release with this fix.

cl...@google.com <cl...@google.com> #5Sep 7, 2023 05:25PM

Marked as fixed.

Awesome, thanks for the quick merge 😀

na...@google.com <na...@google.com> #6Sep 20, 2023 07:16PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.8.0-alpha01
androidx.navigation:navigation-ui:2.8.0-alpha01

th...@outlook.com <th...@outlook.com> #7Sep 21, 2023 08:48AM

I can confirm the issue reported here is fixed in 2.8.0-alpha01. Not sure why there is no mention of it in the release notes though. I should have added a RelNotes trailer to the git commit message, or can it be added afterwards?

na...@google.com <na...@google.com> #8Jan 24, 2024 07:53PM

You would have had to add a Relnote if you wanted it mentioned in the release notes, yes.

We can manually add it to the release notes though.