Obsolete
Status Update
Comments
hu...@google.com <hu...@google.com>
va...@google.com <va...@google.com> #2
Fixed in CL 9735373
ti...@stu.scappoosek12.org <ti...@stu.scappoosek12.org> #3
Should be available in 4.0 canary 5+
ti...@stu.scappoosek12.org <ti...@stu.scappoosek12.org> #4
y'all I found some secret info and codes I'ma just stop
va...@google.com <va...@google.com> #5
there's nothing secret or private here. it should be completely public.
Description
i noticed that tlsdate-helper.c mmaps a 32-bit value to hold time_t:
which it passes to the child that makes the server connection :
and this is because TLS 1.2 only encodes a 32-bit timestamp in the first 4 bytes.
if the server treats this as signed, then it means the limit is 2038. if it treats it as unsigned, it means the limit is 2106. i think our client side is OK because we're treating it as unsigned. so even if the server side treated it as signed 32-bit, if 2038 rolled around, it should be an easy fix on the server side and not require any client updates.
something to be aware of ... i could see this being a concern in the 2038 timeframe (based on devices going EOL), but i'd like to think we'd be on a completely diff system by 2106. i'll be long dead by then though, so i don't care so much. hence, P4.