Obsolete
Status Update
Comments
hu...@google.com <hu...@google.com>
va...@google.com <va...@google.com> #2
The same set of changes builds on linux
ti...@stu.scappoosek12.org <ti...@stu.scappoosek12.org> #3
deleted
ti...@stu.scappoosek12.org <ti...@stu.scappoosek12.org> #4
➜ My-App git:(feature-agp-7.0) ✗ echo $JAVA_HOME
/Applications/Android Studio Arctic Fox.app/Contents/jre/Contents/Home
➜ My-App git:(feature-agp-7.0) ✗ "/Applications/Android Studio Arctic Fox.app/Contents/jre/Contents/Home/bin/java" --version
openjdk 11.0.10 2021-01-19
OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
OpenJDK 64-Bit Server VM (build 11.0.10+0-b96-7281165, mixed mode)
va...@google.com <va...@google.com> #5
Interesting find- tests run fine from Android Studio, but not from the command line (for us).
Running this single test (and probably any test or set of tests) works from AS, but not from the command line:
./gradlew :app-settings:cleanTestDebugUnitTest :app-settings:testDebugUnitTest --tests "com.my.company.settings.DefaultAppSettingsTests"
Description
i noticed that tlsdate-helper.c mmaps a 32-bit value to hold time_t:
which it passes to the child that makes the server connection :
and this is because TLS 1.2 only encodes a 32-bit timestamp in the first 4 bytes.
if the server treats this as signed, then it means the limit is 2038. if it treats it as unsigned, it means the limit is 2106. i think our client side is OK because we're treating it as unsigned. so even if the server side treated it as signed 32-bit, if 2038 rolled around, it should be an easy fix on the server side and not require any client updates.
something to be aware of ... i could see this being a concern in the 2038 timeframe (based on devices going EOL), but i'd like to think we'd be on a completely diff system by 2106. i'll be long dead by then though, so i don't care so much. hence, P4.