Remove @DoNotInline usage, disable lint check [345472586]

Fixed

Feature Request

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jun 6, 2024 04:37PM

R8 may double-outline platform NewApi calls when automatic outlining is enabled, so we should consider no-op'ing the @DoNotInline annotation when we're using an R8 version that does outlining.

Looping in from email,

The design for targeted rules is in go/targeted-shrinking-rules.

You can actually target R8 rules based on R8 version, so that's probably even better. I don't know where it's documented, but you can do: META-INF/com.android.tools/r8-upto-$VERSION/rules.pro

Comments

al...@google.com <al...@google.com> #2Jun 6, 2024 07:32PM

Update: I was able to downgrade to 32.1.10 and I can confirm it's smooth again. The issue is indeed in emulator version 33.1.1

sg...@google.com <sg...@google.com> #3Jun 7, 2024 06:54AM

It's happening to me too and I also confirm that reverting to 32.1.10 fixes the issue.

We should have an easier way of reverting versions. AS should allow picking the version similarly to how we already do for the other tools in SDK manager.

al...@google.com <al...@google.com> #4Jun 10, 2024 02:51PM

Hi,

would you try to turn on hardware GPU rendering (instead of auto GPU) and see if it fixes this issue?

ag...@google.com <ag...@google.com> #5Jun 10, 2024 03:08PM

Hi,

I'm currently not able to change this option, it is greyed out.

al...@google.com <al...@google.com> #6Jun 10, 2024 04:07PM

Hi,

there are 2 ways to set it:

1. use a google_apis image (instead of google_apis_playstore). it will re-enable the option.
2. go to your avd folder (usually located in ~/.android/avd/your_avd_name.avd/), open config.ini and hardware-qemu.ini, then modify those lines:

hw.gpu.enabled=yes
hw.gpu.mode=host

al...@google.com <al...@google.com> Jun 10, 2024 08:57PM

Accepted by al...@google.com.

al...@google.com <al...@google.com> #7Jun 11, 2024 04:30PM

Status: New

Hi,

Yes, option 2 fixes the issue (which also persists on 33.1.2 btw). Even though I get a warning when I start the emulator (see attachments).

Will this option be enabled "out of the box" in a future version?

al...@google.com <al...@google.com> Jul 2, 2024 02:50PM

Assigned to al...@google.com.

al...@google.com <al...@google.com> Jul 2, 2024 05:35PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #8Jul 8, 2024 05:41PM

Hi,

we suspect a bug in gpu detection logic on Mac M1, and will try to address it in upcoming releases.

ap...@google.com <ap...@google.com> #9Jul 8, 2024 07:31PM

Hi Devki,

would you help to cp aosp/2451107 to next stable and canary releases? Thank you!

ap...@google.com <ap...@google.com> #10Jul 9, 2024 03:56PM

Hi Devki,

Could we cherry-pick it to canary release as well? Thanks!

al...@google.com <al...@google.com> #11Jul 9, 2024 04:37PM

@yahan it will be picked up in the next canary since we are doing snaps!

ap...@google.com <ap...@google.com> #12Jul 9, 2024 05:08PM

Thanks!

ap...@google.com <ap...@google.com> #13Jul 9, 2024 05:38PM

Was able to force the emulator to use the host GPU by opening it via the terminal with

./emulator -avd Resizable_API_33 -gpu host

ap...@google.com <ap...@google.com> #14Jul 10, 2024 04:05PM

I believe this is still happening in 33.1.10

al...@google.com <al...@google.com> #15Jul 10, 2024 05:48PM

Assigned to bu...@google.com.

Chris, would you help to send us the verbose log?

bu...@google.com <bu...@google.com> #16Jul 10, 2024 05:53PM

Accepted by bu...@google.com.

User on #comment13 should provide it. User was the one who reported this still happening with Play Store images, via Slack communities. I can also try to repro myself.

ap...@google.com <ap...@google.com> #17Jul 18, 2024 03:34PM

do you still have this problem with latest 33.1.20+ ?

bu...@google.com <bu...@google.com> Jul 23, 2024 02:34PM

Assigned to al...@google.com.

al...@google.com <al...@google.com> #18Jul 29, 2024 02:25PM

Marked as fixed.

If that question is for me, I've tested changing the config.ini back to "hw.gpu.mode=auto" and it appears to be fine. I have 33.1.2.0.

pr...@google.com <pr...@google.com> #19Aug 13, 2024 06:58PM

with 34.1.x stable already, are there still any performance degradation ?

let us know