IssueTracker

I've tried the Audio MIDI Setup program, but it doesn't show any changes for my headphones that are bluetooth connected with a USB dongle.

I don't think that is what is happening. For me, when the emulator launches, it changes the macOS input device from the internal speaker to my headphones which switches the bt profile to a2dp. As a temporary workaround, I set hw.audioInput=no in my avd config.ini and it seemed to help.

As a temporary workaround, https://issuetracker.google.com/issues/183139207#comment5 is working for me.

config.ini changes don't seem to work for me - tried on various emulators with API level 31+. Both freshly installed emulators and existing ones.

Hi. I am sorry for the issues around sound quality. I am working on a new sound card, this bug will be the next issue I will be working on.

I was able to repro this with bluetooth headphones, it does not repro with laptop speakers somehow. It happens very early, even before the kernel is loaded.

Bluetooth audio devices switch operating modes when used as: a) Speaker only (simplex, only supports audio out and up to stereo 48KHz sampling rate) b) Speakers + Microphone (duplex, supports both mono audio in and out at 8 or 16 Khz sampling rate)

Devices are usually by default in mode a, as soon as a sw opens the the microphone they switch to mode b and therefore any audio being reproduced suddenly jumps from 48 to 16khz and the quality gap can be clearly heard. Some drivers even have different volume settings between the 2 modes and when switching mode the volume can suddenly jump up or down.

This is why you can't repro with built in laptop speakers: their sound card is not a bluetooth device and hence doesn't have this peculiar behavior.

Thank you for the details. To me this sounds like, bluetooth headphones have to switch to 16Khz if we want to use their microphone in the emulator. One way of fixing this is to avoid touching the microphone in the emulator unless we want to record from it. As a quick fix, it is possible to switch the audio input in MacOS to the "Internal microphone" then the running emulator does not affect audio quality.

To me this sounds like, bluetooth headphones have to switch to 16Khz if we want to use their microphone in the emulator.

Correct. There’s no way out from here.

One way of fixing this is to avoid touching the microphone in the emulator unless we want to record from it.

Indeed. And closing the mike as soon as finishing recording.

As a quick fix, it is possible to switch the audio input in MacOS to the "Internal microphone" then the running emulator does not affect audio quality.

Yes. This is how most of us are coping with this since years :) but every time you disconnect and reconnect the bt headphones the system automatically reselects them as microphone. So it’s easy to retrigger this unpleasant behavior.

AUD_open_in (as well as _out) is called twice: in goldfish_audio and in hda.

#0  AUD_open_out (card=card@entry=0x7b1f178, sw=sw@entry=0x0, name=0x2759e5 "goldfish_audio", callback_opaque=callback_opaque@entry=0x7b1ed00, 
    callback_fn=0x1155300 <goldfish_audio_callback>, as=as@entry=0x7fffe03b3fc0) at ../audio/audio_template.h:399
#1  0x0000000001155208 in goldfish_audio_realize (dev=<optimized out>, errp=<optimized out>) at ../hw/audio/goldfish_audio.c:450
#2  0x0000000001176890 in device_set_realized (obj=<optimized out>, value=true, errp=0x7fffe03b4118) at ../hw/core/qdev.c:852
#3  0x0000000001247fdc in property_set_bool (obj=0x7b1ed00, v=<optimized out>, name=<optimized out>, opaque=0x7a4b210, errp=0x7fffe03b4118)
    at ../qom/object.c:1923
#4  0x00000000012498ed in object_property_set_qobject (obj=0x7b1f178, value=<optimized out>, name=0x2759e5 "goldfish_audio", errp=0x7b1ed00)
    at ../qom/qom-qobject.c:27
#5  0x00000000012467cc in object_property_set_bool (obj=0x7b1f178, value=<optimized out>, name=0x2759e5 "goldfish_audio", errp=0x7b1ed00)
    at ../qom/object.c:1188
#6  0x000000000117541f in qdev_init_nofail (dev=dev@entry=0x7b1ed00) at ../hw/core/qdev.c:339
#7  0x0000000001177ef3 in sysbus_create_varargs (name=<optimized out>, addr=addr@entry=4278267904) at ../hw/core/sysbus.c:226
#8  0x0000000001083cf0 in sysbus_create_simple (name=0x7b1f178 " \263\244\a", addr=4278267904, irq=0x2759e5) at ../include/hw/sysbus.h:111
#9  pc_init1 (machine=0x3b25880, host_type=<optimized out>, pci_type=<optimized out>) at ../hw/i386/pc_piix.c:288
#10 0x000000000116fa72 in machine_run_board_init (machine=0x3b25880) at ../hw/core/machine.c:829
#11 0x000000000109b4c5 in main_impl (argc=<optimized out>, argv=<optimized out>, 
    on_main_loop_done=0x10959a0 <enter_qemu_main_loop(int, char**)::$_4::__invoke()>) at ../vl.c:5533
#12 0x0000000001097746 in run_qemu_main (argc=129102200, argv=0x0, on_main_loop_done=0x2759e5) at ../vl.c:3360
#13 0x0000000001092c3a in enter_qemu_main_loop (argc=112, argv=0x3b24e00) at ../android-qemu2-glue/main.cpp:731
#14 0x00007ffff7320233 in QThreadPrivate::start (arg=0x3a9a420)
    at /usr/local/google/home/wdu/build-qt/src/qt-everywhere-src-5.12.1/qtbase/src/corelib/thread/qthread_unix.cpp:361
#15 0x00007ffff79d4d80 in start_thread (arg=0x7fffe03b5640) at pthread_create.c:481
#16 0x00007ffff6396bdf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

#0  AUD_open_in (card=card@entry=0x7b1f178, sw=sw@entry=0x0, name=0x392aaf "goldfish_audio_in", callback_opaque=callback_opaque@entry=0x7b1ed00, 
    callback_fn=0x11554a0 <goldfish_audio_in_callback>, as=as@entry=0x7fffe03b3fc0) at ../audio/audio_template.h:399
#1  0x0000000001155280 in goldfish_audio_realize (dev=<optimized out>, errp=<optimized out>) at ../hw/audio/goldfish_audio.c:471
#2  0x0000000001176890 in device_set_realized (obj=<optimized out>, value=true, errp=0x7fffe03b4118) at ../hw/core/qdev.c:852
#3  0x0000000001247fdc in property_set_bool (obj=0x7b1ed00, v=<optimized out>, name=<optimized out>, opaque=0x7a4b210, errp=0x7fffe03b4118)
    at ../qom/object.c:1923
#4  0x00000000012498ed in object_property_set_qobject (obj=0x7b1f178, value=<optimized out>, name=0x392aaf "goldfish_audio_in", errp=0x7b1ed00)
    at ../qom/qom-qobject.c:27
#5  0x00000000012467cc in object_property_set_bool (obj=0x7b1f178, value=<optimized out>, name=0x392aaf "goldfish_audio_in", errp=0x7b1ed00)
    at ../qom/object.c:1188
#6  0x000000000117541f in qdev_init_nofail (dev=dev@entry=0x7b1ed00) at ../hw/core/qdev.c:339
#7  0x0000000001177ef3 in sysbus_create_varargs (name=<optimized out>, addr=addr@entry=4278267904) at ../hw/core/sysbus.c:226
#8  0x0000000001083cf0 in sysbus_create_simple (name=0x7b1f178 " \263\244\a", addr=4278267904, irq=0x392aaf) at ../include/hw/sysbus.h:111
#9  pc_init1 (machine=0x3b25880, host_type=<optimized out>, pci_type=<optimized out>) at ../hw/i386/pc_piix.c:288
#10 0x000000000116fa72 in machine_run_board_init (machine=0x3b25880) at ../hw/core/machine.c:829
#11 0x000000000109b4c5 in main_impl (argc=<optimized out>, argv=<optimized out>, 
    on_main_loop_done=0x10959a0 <enter_qemu_main_loop(int, char**)::$_4::__invoke()>) at ../vl.c:5533
#12 0x0000000001097746 in run_qemu_main (argc=129102200, argv=0x0, on_main_loop_done=0x392aaf) at ../vl.c:3360
#13 0x0000000001092c3a in enter_qemu_main_loop (argc=112, argv=0x3b24e00) at ../android-qemu2-glue/main.cpp:731
#14 0x00007ffff7320233 in QThreadPrivate::start (arg=0x3a9a420)
    at /usr/local/google/home/wdu/build-qt/src/qt-everywhere-src-5.12.1/qtbase/src/corelib/thread/qthread_unix.cpp:361
#15 0x00007ffff79d4d80 in start_thread (arg=0x7fffe03b5640) at pthread_create.c:481
#16 0x00007ffff6396bdf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

#0  AUD_open_out (card=0x5086388, sw=0x0, name=0x2d9383 "dac", callback_opaque=callback_opaque@entry=0x50863a8, 
    callback_fn=0x1156820 <hda_audio_output_cb>, as=as@entry=0x50863d4) at ../audio/audio_template.h:399
#1  0x000000000115677f in hda_audio_setup (st=0x50863a8) at ../hw/audio/hda-codec.c:288
#2  0x0000000001156c8d in hda_audio_init (hda=hda@entry=0x5086300, desc=<optimized out>) at ../hw/audio/hda-codec.c:520
#3  0x0000000001156e34 in hda_audio_init_duplex (hda=0x5086300) at ../hw/audio/hda-codec.c:640
#4  0x00000000011590c3 in hda_codec_dev_realize (qdev=<optimized out>, errp=0x7fffe03b4288) at ../hw/audio/intel-hda.c:69
#5  0x0000000001176890 in device_set_realized (obj=<optimized out>, value=true, errp=0x7fffe03b4378) at ../hw/core/qdev.c:852
#6  0x0000000001247fdc in property_set_bool (obj=0x5086300, v=<optimized out>, name=<optimized out>, opaque=0x9604650, errp=0x7fffe03b4378)
    at ../qom/object.c:1923
#7  0x00000000012498ed in object_property_set_qobject (obj=0x5086388, value=<optimized out>, name=0x2d9383 "dac", errp=0x50863a8)
    at ../qom/qom-qobject.c:27
#8  0x00000000012467cc in object_property_set_bool (obj=0x5086388, value=<optimized out>, name=0x2d9383 "dac", errp=0x50863a8)
    at ../qom/object.c:1188
#9  0x000000000117541f in qdev_init_nofail (dev=0x5086300) at ../hw/core/qdev.c:339
#10 0x000000000115713c in intel_hda_and_codec_init (bus=<optimized out>) at ../hw/audio/intel-hda.c:1355
#11 0x00000000011594d6 in soundhw_init () at ../hw/audio/soundhw.c:151
#12 0x000000000109b514 in main_impl (argc=<optimized out>, argv=<optimized out>, 
    on_main_loop_done=0x10959a0 <enter_qemu_main_loop(int, char**)::$_4::__invoke()>) at ../vl.c:5554
#13 0x0000000001097746 in run_qemu_main (argc=84435848, argv=0x0, on_main_loop_done=0x2d9383) at ../vl.c:3360
#14 0x0000000001092c3a in enter_qemu_main_loop (argc=112, argv=0x3b24e00) at ../android-qemu2-glue/main.cpp:731
#15 0x00007ffff7320233 in QThreadPrivate::start (arg=0x3a9a420)
    at /usr/local/google/home/wdu/build-qt/src/qt-everywhere-src-5.12.1/qtbase/src/corelib/thread/qthread_unix.cpp:361
#16 0x00007ffff79d4d80 in start_thread (arg=0x7fffe03b5640) at pthread_create.c:481
#17 0x00007ffff6396bdf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

#0  AUD_open_in (card=0x5086388, sw=0x0, name=0x392af6 "adc", callback_opaque=callback_opaque@entry=0x50864f8, 
    callback_fn=0x1155910 <hda_audio_input_cb>, as=as@entry=0x5086524) at ../audio/audio_template.h:399
#1  0x000000000115680c in hda_audio_setup (st=0x50864f8) at ../hw/audio/hda-codec.c:293
#2  0x0000000001156c8d in hda_audio_init (hda=hda@entry=0x5086300, desc=<optimized out>) at ../hw/audio/hda-codec.c:520
#3  0x0000000001156e34 in hda_audio_init_duplex (hda=0x5086300) at ../hw/audio/hda-codec.c:640
#4  0x00000000011590c3 in hda_codec_dev_realize (qdev=<optimized out>, errp=0x7fffe03b4288) at ../hw/audio/intel-hda.c:69
#5  0x0000000001176890 in device_set_realized (obj=<optimized out>, value=true, errp=0x7fffe03b4378) at ../hw/core/qdev.c:852
#6  0x0000000001247fdc in property_set_bool (obj=0x5086300, v=<optimized out>, name=<optimized out>, opaque=0x9604650, errp=0x7fffe03b4378)
    at ../qom/object.c:1923
#7  0x00000000012498ed in object_property_set_qobject (obj=0x5086388, value=<optimized out>, name=0x392af6 "adc", errp=0x50864f8)
    at ../qom/qom-qobject.c:27
#8  0x00000000012467cc in object_property_set_bool (obj=0x5086388, value=<optimized out>, name=0x392af6 "adc", errp=0x50864f8)
    at ../qom/object.c:1188
#9  0x000000000117541f in qdev_init_nofail (dev=0x5086300) at ../hw/core/qdev.c:339
#10 0x000000000115713c in intel_hda_and_codec_init (bus=<optimized out>) at ../hw/audio/intel-hda.c:1355
#11 0x00000000011594d6 in soundhw_init () at ../hw/audio/soundhw.c:151
#12 0x000000000109b514 in main_impl (argc=<optimized out>, argv=<optimized out>, 
    on_main_loop_done=0x10959a0 <enter_qemu_main_loop(int, char**)::$_4::__invoke()>) at ../vl.c:5554
#13 0x0000000001097746 in run_qemu_main (argc=84435848, argv=0x0, on_main_loop_done=0x392af6) at ../vl.c:3360
#14 0x0000000001092c3a in enter_qemu_main_loop (argc=112, argv=0x3b24e00) at ../android-qemu2-glue/main.cpp:731
#15 0x00007ffff7320233 in QThreadPrivate::start (arg=0x3a9a420)
    at /usr/local/google/home/wdu/build-qt/src/qt-everywhere-src-5.12.1/qtbase/src/corelib/thread/qthread_unix.cpp:361
#16 0x00007ffff79d4d80 in start_thread (arg=0x7fffe03b5640) at pthread_create.c:481
#17 0x00007ffff6396bdf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

BTW, I am migrating us to virtio-snd, it does not open the microphone for no reason (it has other problems so far and disabled).

Not opening the microphone at all is definitely a strategy. I don't think many people actually do record sound with the emulator (but happy to be proven wrong). Or perhaps adding a default-off checkbox in the emulator settings to explicitly enable the microphone only when actually needed could be another way to go.

I suspect there could be a reason (probably not a very good one) why sound cards are implemented this way. I tried to delay opening output streams and got audio issues (audio stops and restarts every few milliseconds because the kernel detects XRUN because some global variables compare in a certain way) similar to what I am having in virtio-snd currently. So, I made virtio-snd to work like hda and audio was clear.

I'm sorry but I only have high level knowledge of this stuff so I can't help much when it comes to linux drivers. But I'll be happy to try out any pre-release should this be of help!

I believe this is not a kernel, but some weird assumptions in qemu which break if we open a device moments before using it or in a wrong thread. If you happen to have a linux machine and willing to build and play with our emulator, we will be happy to take a patch from you :) From here I will be working on virtio-snd first and then I will try to figure out if we can delay opening stream to the point where they are needed. Or maybe we could just introduce -no-microphone.

This looks like not an easy issue to fix! ... as these bugs could resurface back after some time.

I agree :(

we could disable mic by default

If we go this way, we probably want to add an option to disable it.

If we go this way, we probably want to add an option to disable it.

This also works, at least we could disable mic manually and have the sound quality back. Do you think you could use it as a short term fix while you are looking for a better solution?

a short term fix while you are looking for a better solution?

I'll talk about it on our weekly meeting on Tuesday.

dm...@gmail.com this is a complex project and it's not an easy job to keep it bug-free. I clearly see it's improving and onboarding more features. I also have a chance to work with Xcode and believe me - Android studio is way way better than apple's product - refactoring, hotkeys out of the box, WYSIWIG and overall performance are just a few areas with a big difference

I found a TODO: Be able to disable audio input/output separately but so far I can't figure out how to pass a runtime value into the sound card init functions (goldfish_audio_realize, hda_audio_setup).

I figured out how to pass runtime values into virtio-snd and hda-duplex, we should be able to avoid opening the microphone in those devices. When I tried the same with goldfish_audio, the QEMU says -device goldfish_audio,debug=42: Parameter 'driver' expects pluggable device type. We probably want to retire (not sure if we can just disable it) this device instead of hacking it further.

I merged a change to disable the microphone in Intel HDA and virtio-snd. Not sure how we can disable it goldfish_sound in a proper way. We probably want to disable it unconditionally.

"Sounds like" (pun intended) a very good improvement! BTW: What decides which audio driver to use (I mean with which logic virtio-snd or hda-duplex or goldfish_audio is used) ?