AGP KMP breaks Gradle metadata for KMP projects that target JVM [396184120]

Fixed

Bug

Status Update

No update yet.

Description

da...@google.com

created issue #1

Feb 12, 2025 09:13PM

Applying the newer AGP KMP plugin to androidx.sqlite breaks the Gradle metadata such that a JVM project depending on the artifact will attempt (and fail) to use the android artifact instead of the JVM one.

This was originally reported in SQLite KMP b/396148592

Here is a diff on the metadata, left is before AGP KMP is used (i.e. after reverting the changes in this CL) and right is with AGP KMP applied: https://diff.googleplex.com/#key=EY2FqaJWQbUQ

Let me know if you need a sample project, but if you create a new JVM or Kotlin project and depend on androidx.sqlite:sqlite:2.5.0-beta01 and try to use classes from it, it will fail at runtime with a class not found exception. When inspecting the deps via :dependencies you will notice it attempts to use the -android artifact instead of the -jvm one:

runtimeClasspath - Runtime classpath of 'main'.
+--- org.jetbrains.kotlin:kotlin-stdlib:2.1.10
|    \--- org.jetbrains:annotations:13.0
\--- androidx.sqlite:sqlite:2.5.0-beta01
     +--- androidx.annotation:annotation:1.8.1
     |    \--- androidx.annotation:annotation-jvm:1.8.1
     |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 2.1.10 (*)
     +--- androidx.sqlite:sqlite-android:2.5.0-beta01
     |    +--- androidx.annotation:annotation:1.8.1 (*)
     |    +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.1.10 (*)
     |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.10 (c)
     \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.10 (*)

Comments

au...@google.com <au...@google.com> #2Feb 12, 2025 09:28PM

https://bit.ly/3UxSQmb

da...@google.com <da...@google.com> #3Feb 12, 2025 09:34PM

Here is what I found: On API 31+, time was not updated after the host was waken up. While on API 30 and under, time was updated after host was waken up. The main difference is caused by switching the modem simulator. In API 30 and under, time will be updated whenever signal strength query is received. Reference

Looking at the code in API 31+ for time update when signal strength query is received, I think it is possible that timeUpdate is not invoked

void NetworkService::HandleSignalStrength(const Client& client) {
  std::vector<std::string> responses;
  std::stringstream ss;

  if (WakeupFromSleep()) {
    misc_service_->TimeUpdate();
  } else if (first_signal_strength_request_) {
    first_signal_strength_request_ = false;
    misc_service_->TimeUpdate();
  }

  android_last_signal_time_ = time(0);

  auto response = BuildCSQCommandResponse(GetCurrentSignalStrength());

  responses.push_back(response);
  responses.push_back("OK");
  client.SendCommandResponse(responses);
}

au...@google.com <au...@google.com> #4Feb 12, 2025 09:39PM

CL is merged. We plan to release it to the next canary and stable.

da...@google.com <da...@google.com> #5Feb 12, 2025 09:45PM

Ranjit, can you please help verify this on 32.1.8 Canary and 31.3.14 Stable?

Message last modified on Feb 12, 2025 09:46PM

sqlitedrivertest.zip

182 KB

Download

da...@google.com <da...@google.com> #6Feb 12, 2025 09:56PM

Still seeing this issue with Emulator 31.3.14 Stable. Refer to the screenshot.

hm...@google.com <hm...@google.com> #7Feb 13, 2025 10:15AM

@devki How do I know if the fix is in 31.3.14 stable? Any tool for checking if a CL went into the specified version?

Message last modified on Feb 13, 2025 12:58PM

hm...@google.com <hm...@google.com> #8Feb 13, 2025 01:15PM

hi! we can check in "where is my cl" to see if it was added into the branch:

https://android-build.googleplex.com/builds/where-is-my-cl/search/I098de6ea8fe90c64bfc72a11adc13c6e13a06cdd

It doesn't look like it was cp'ed into aosp-emu-31-release

Does it need to be cp'ed?

hm...@google.com <hm...@google.com> #9Feb 13, 2025 01:46PM

RE#9 Thanks Devki. Actually the fix is included in aosp-emu-31-release branch. https://android-build.googleplex.com/builds/branch-dashboard/aosp-emu-31-release?build_id=9296499 There is probably still something missing in the stable release and I will take another look.

da...@google.com <da...@google.com> #10Feb 13, 2025 02:03PM

Upload a new CL which will enforce time update when QT application state changes, which happens when emulator sleeps and wakes up.

da...@google.com <da...@google.com> #11Feb 13, 2025 07:22PM

Please use the build from go/ab/9413197 https://android-build.googleplex.com/builds/branch-dashboard/aosp-emu-31-release?build_id=9413197

Message last modified on Feb 13, 2025 07:23PM

ow...@google.com <ow...@google.com> Feb 18, 2025 05:47PM

Reassigned to hm...@google.com.

hm...@google.com <hm...@google.com> #12Feb 26, 2025 12:40PM

Hi Weilun, Devki,
Still seeing this issue on Emulator 31.3.15 Stable build.
Can you check if the changes are in 31.3.15 or not?

hm...@google.com <hm...@google.com> #13Mar 3, 2025 10:25AM

Reassigned to da...@google.com.

RE#12 31.3.15 uses build 9456632 so it should have included the fix. Let's sync up in chat.

da...@google.com <da...@google.com> Mar 3, 2025 01:42PM

Marked as fixed.

au...@google.com <au...@google.com> #14Mar 4, 2025 05:12PM

Retried as per offline discussion with Weilun, sometimes the time adjusts automatically but sometimes it gets adjusted after interacting with AVD.