Fixed
Status Update
No update yet.
Comments
[Deleted User] <[Deleted User]>
Also, it would be great to return Observable, cause Flowable has some overhead.
fl...@google.com
da...@google.com
ap...@google.com
We are going to add Single for queries (and Maybe) but for @insert, @Update and @Delete it is a bit more tricky because we would be reading those values when the computable runs, in which case developer may change them by mistake. We've not decided whether we want to take that risk or not. (We could copy but that would be additional hidden load, especially if the input is a long list).
#2, flowable can easily turn into an observable, would you like to escalate on why you think the overhead is a problem?
#2, flowable can easily turn into an observable, would you like to escalate on why you think the overhead is a problem?
[Deleted User] <[Deleted User]>
Cool for Single/Maybe for queries :)
For @insert, @Update and @Delete I personally would like to have the possibility to have Single/Maybe... because I will 100% of the time wrap the call into a Single to make it asynchronous and have the possibility to chain other actions with it. I understand that copying entries will take additional resources but in that case we'll have the possibility to not use the RX return type.
That my opinion ^^
Thanks !
For @insert, @Update and @Delete I personally would like to have the possibility to have Single/Maybe... because I will 100% of the time wrap the call into a Single to make it asynchronous and have the possibility to chain other actions with it. I understand that copying entries will take additional resources but in that case we'll have the possibility to not use the RX return type.
That my opinion ^^
Thanks !
da...@google.com
Shouldn't this be typed as a feature request?
ma...@marcardar.com
je...@gmail.com
This issue is half year old and it's still not implemented. Without this the library is unusable.
da...@google.com
+1
[Deleted User] <[Deleted User]>
+1 Here as well. I would like Completable support.
yb...@google.com
+1 i think Completable support is necessary
cr...@shou.tv
+1 for Completable support as well
da...@google.com
+1 for completable - just missed it on the fly while coding
pi...@gmail.com
+1 for Completable support as well
ai...@gmail.com
+1 for completable for @Delete @Update and @Insert
Description
Version used: 1.0.0
Room currently supports RxJava and LiveData, but it would be great to also have support for Kotlin's Coroutines.
In a basic implementation this could be achieved with supporting the following types:
- Query: Deferred<T>
- Insert: Job or Deferred<Long>
- Delete: Job or Deferred<Int>
- Update: Job or Deferred<Int>
What could be really awesome though would be implementing support for the `suspend` keyword, as the developer would be able to write just:
```
@Query("SELECT * FROM ITEMS")
suspend fun getItems(): List<Item>
```
I understand this might be tricky to implement on your side though, since a suspend function has got a continuation parameter and that might be an issue with the way Room currently works.