Status Update
No update yet.
Comments
td...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e1b42da3ee5bcb06756d8cb8377abf6116086e11
Author: Sanura N'Jaka <sanura@google.com>
Date: Tue Sep 07 20:23:52 2021
Make nullable NavDeepLink arguments not required
Removing the inclusion of nullable NavDeepLink
arguments from the "required" argument checking.
RelNote: "Nullable `NavDeepLink` arguments no longer
require a default value."
Test: deepLinkNullableArgumentNotRequired test
Bug: 198689811
Change-Id: Ia14ef04bfe5b25942163688f40adacc30fa7e044
M navigation/navigation-common/src/androidTest/java/androidx/navigation/AddInDefaultArgsTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/test/NavArgument.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
https://android-review.googlesource.com/1817360
Branch: androidx-main
commit e1b42da3ee5bcb06756d8cb8377abf6116086e11
Author: Sanura N'Jaka <sanura@google.com>
Date: Tue Sep 07 20:23:52 2021
Make nullable NavDeepLink arguments not required
Removing the inclusion of nullable NavDeepLink
arguments from the "required" argument checking.
RelNote: "Nullable `NavDeepLink` arguments no longer
require a default value."
Test: deepLinkNullableArgumentNotRequired test
Bug: 198689811
Change-Id: Ia14ef04bfe5b25942163688f40adacc30fa7e044
M navigation/navigation-common/src/androidTest/java/androidx/navigation/AddInDefaultArgsTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/test/NavArgument.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
Description
Gradle version: 4.6
Android Plugin Version: 3.2.0-alpha17
NOTE: This problem DOES NOT appear in alpha16; it seems to be new
Module Compile Sdk Version: API 27: Android 8.1 (Oreo)
Module Build Tools Version: 27.0.3
Android SDK Tools version: 26.1.1
Select Tools > Android > SDK Manager, click SDK Tools, and then locate Android SDK Tools
Steps to repro:
1. Have a project with an feature module and a parent application module (i.e. an instant app).
2. In the feature module, have
apply plugin: 'com.android.feature'
//...
apply plugin: 'kotlin-android'
3. Try to do a Gradle sync
With earlier versions of the Android gradle plugin this works, but with the most recent version (canary 17) I get this error:
'kotlin-android' expects one of the Android Gradle plugins to be applied to the project:
* android
* com.android.application
* android-library
* com.android.library
* com.android.test
* com.android.feature
* com.android.dynamic-feature
Note that I *am* using the com.android.feature plugin that it asks for. This breaks building instant apps with Kotlin, which is a critical feature as many apps use Kotlin now, so I'm making it at least a P1.