Fixed
Status Update
No update yet.
Comments
fr...@ingenie.com
since these are in public API (:/) we need to do this in 1.2
il...@google.com
since it is already marked as deprecated, we can probably do it by now.
[Deleted User] <[Deleted User]>
Opening diff shortly
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d967abdf673a9ab9249fedead4cb0389139e7e70
Author: jbwoods <jbwoods@google.com>
Date: Thu Apr 18 15:36:48 2019
Add hasDeepLink Api to NavDestination
When users attempt to navigate to a deep link destination, if the deep
link is invalid an IllegalArgumentException is thrown. This Api offers
a way to verify the deeplink is valid before attempting to navigate, and
gives developers more flexibility to handle the case where the deep link
may be invalid.
It uses matchDeepLink() and returns whether a match was found.
Test: New tests and ./gradlew checkApi
BUG: 117437718, 110412864
Change-Id: Iabbca9cfbb864ce305d84d9e4f616d2b43dc7ac6
M navigation/common/api/2.1.0-alpha03.txt
M navigation/common/api/current.txt
M navigation/common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/common/src/main/java/androidx/navigation/NavDestination.java
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
https://android-review.googlesource.com/948136
https://goto.google.com/android-sha1/d967abdf673a9ab9249fedead4cb0389139e7e70
Branch: androidx-master-dev
commit d967abdf673a9ab9249fedead4cb0389139e7e70
Author: jbwoods <jbwoods@google.com>
Date: Thu Apr 18 15:36:48 2019
Add hasDeepLink Api to NavDestination
When users attempt to navigate to a deep link destination, if the deep
link is invalid an IllegalArgumentException is thrown. This Api offers
a way to verify the deeplink is valid before attempting to navigate, and
gives developers more flexibility to handle the case where the deep link
may be invalid.
It uses matchDeepLink() and returns whether a match was found.
Test: New tests and ./gradlew checkApi
BUG: 117437718, 110412864
Change-Id: Iabbca9cfbb864ce305d84d9e4f616d2b43dc7ac6
M navigation/common/api/2.1.0-alpha03.txt
M navigation/common/api/current.txt
M navigation/common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/common/src/main/java/androidx/navigation/NavDestination.java
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
il...@google.com
This has been implemented internally and will be available in Navigation 2.1.0-alpha03.
Now in addition to navigating via an R.id, you can reuse the same <deepLink> elements in your graph to navigate(Uri).
Now in addition to navigating via an R.id, you can reuse the same <deepLink> elements in your graph to navigate(Uri).
Description
Version used: 1.0.0-alpha02
Navigating via id works great for flat navigation graphs contained within a single module, but for multi-module cases that have separate graphs (included together by higher level modules), there's no easy way to navigate bidirectionally between them.
It would be nice to be able to navigate via URI, preferably in a way that would allow you to navigate to destinations even within other graphs (which normally you wouldn't be able to navigate directly to).
This would differ from using NavDeepLinkBuilder since it wouldn't blow away the back stack with a synthetic back stack, but just add the new destination to the back stack just like any other navigate() call.