Locality/postal_code in Place Details does not align with Place Autocomplete description. [111160335]

Fixed

Bug

Status Update

No update yet.

Description

mi...@onthespotcorp.com

created issue #1

Jul 5, 2018 07:57PM

# WARNING: DO NOT INCLUDE YOUR API KEY OR CLIENT ID CREDENTIALS
# It is OK to share your API Project ID, but _not_ API keys.

Issue report
----------------
What steps will reproduce the problem? Please provide a link to a
demonstration page if at all possible, or attach code.
1. Type in 24 Market Street, Saddle Brook, NJ 07663, USA
2. Returns 24 Market Street, Garfield, NJ 07026, USA

<div id="locationField">
<input id="autocomplete" placeholder="Enter Customer Address" type="text"></input>
</div>

<script>
// Google Maps Javascript API
var placeSearch, autocomplete;
var componentForm = {
street_number: 'short_name',
route: 'long_name',
locality: 'long_name',
postal_code: 'short_name'
};

function initAutocomplete() {
// Create the autocomplete object, restricting the search to geographical
// location types.
var defaultBounds = new google.maps.LatLng({lat: 40.894985, lng: -74.079809});

var input = document.getElementById('autocomplete');
var options = {
location: defaultBounds,
radius: '48280',
types: ['address'],
ComponentRestrictions: {country: "us"}
};

autocomplete = new google.maps.places.Autocomplete(input, options);

// When the user selects an address from the dropdown, populate the address
// fields in the form.
autocomplete.addListener('place_changed', fillInAddress);
}

function fillInAddress() {
// Get the place details from the autocomplete object.
var place = autocomplete.getPlace();
var test = place.formatted_address;

for (var component in componentForm) {
document.getElementById(component).value = '';
document.getElementById(component).disabled = false;
}

// Get each component of the address from the place details
// and fill the corresponding field on the form.
for (var i = 0; i < place.address_components.length; i++) {
var addressType = place.address_components[i].types[0];
if (componentForm[addressType]) {
var val = place.address_components[i][componentForm[addressType]];
console.log(val);
document.getElementById(addressType).value = val;
}
}
}
</script>

Comments

an...@google.com <an...@google.com> #2Jul 6, 2018 09:30AM

Assigned to mi...@google.com.

datastore-core and datastore-preferences have dependencies on android for SharedPreferencesMigrations and convenience constructors. We should extract these dependencies so users can use this in kotlin-only parts of their code.

[Deleted User] <[Deleted User]> #3Jul 15, 2018 10:45AM

Would this enable Kotlin Multiplatform usage? Or just Kotlin/JVM in non-Android settings?

jo...@gmail.com <jo...@gmail.com> #4Jul 23, 2018 06:39PM

This work is intended to support kotlin-only modules in android projects using Kotlin/JVM. We haven't tested this in non-android settings and haven't built it using Kotlin Multiplatform.

mi...@google.com <mi...@google.com> #5Jul 30, 2018 10:47AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c9bbc6f26740be8b2ca486032238442e1138c914
Author: rohitsat13 <rohitsat@google.com>
Date: Tue Sep 29 09:36:28 2020

Split out datastore and datastore-core modules

Test: Ran all datastore tests
Bug: 168512698
Relnote: Created a pure kotlin dependency for datastore to allow for faster compilation
Change-Id: I42d75d0f66dc0cac19bd0f452a84b58806a65a46

M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
A datastore/datastore-core/api/1.0.0-alpha01.txt
M datastore/datastore-core/api/current.txt
A datastore/datastore-core/api/public_plus_experimental_1.0.0-alpha01.txt
M datastore/datastore-core/api/public_plus_experimental_current.txt
A datastore/datastore-core/api/restricted_1.0.0-alpha01.txt
M datastore/datastore-core/api/restricted_current.txt
M datastore/datastore-core/build.gradle
D datastore/datastore-core/lint-baseline.xml
M datastore/datastore-core/src/main/java/androidx/datastore/core/CorruptionHandler.kt
M datastore/datastore-core/src/main/java/androidx/datastore/core/DataMigration.kt
M datastore/datastore-core/src/main/java/androidx/datastore/core/DataMigrationInitializer.kt
M datastore/datastore-core/src/main/java/androidx/datastore/core/DataStore.kt
M datastore/datastore-core/src/main/java/androidx/datastore/core/DataStoreFactory.kt
M datastore/datastore-core/src/main/java/androidx/datastore/core/InitializerApi.kt
M datastore/datastore-core/src/main/java/androidx/datastore/core/Serializer.kt
M datastore/datastore-core/src/main/java/androidx/datastore/core/SingleProcessDataStore.kt
M datastore/datastore-core/src/main/java/androidx/datastore/core/handlers/NoOpCorruptionHandler.kt
M datastore/datastore-core/src/main/java/androidx/datastore/core/handlers/ReplaceFileCorruptionHandler.kt
M datastore/datastore-core/src/test/java/androidx/datastore/core/DataMigrationInitializerTest.kt
M datastore/datastore-core/src/test/java/androidx/datastore/core/DataStoreFactoryTest.kt
M datastore/datastore-core/src/test/java/androidx/datastore/core/SingleProcessDataStoreTest.kt
M datastore/datastore-core/src/test/java/androidx/datastore/core/TestingSerializer.kt
M datastore/datastore-core/src/test/java/androidx/datastore/core/handlers/ReplaceFileCorruptionHandlerTest.kt
M datastore/datastore-preferences/api/api_lint.ignore
M datastore/datastore-preferences/api/current.txt
M datastore/datastore-preferences/api/public_plus_experimental_current.txt
M datastore/datastore-preferences/api/restricted_current.txt
M datastore/datastore-preferences/build.gradle
M datastore/datastore-preferences/datastore-preferences-proto/src/main/java/androidx/datastore/preferences/PreferencesMapCompat.kt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/PreferenceDataStoreFactoryTest.kt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/SharedPreferencesToPreferencesTest.kt
M datastore/datastore-preferences/src/main/java/androidx/datastore/preferences/PreferenceDataStoreFactory.kt
M datastore/datastore-preferences/src/main/java/androidx/datastore/preferences/Preferences.kt
M datastore/datastore-preferences/src/main/java/androidx/datastore/preferences/PreferencesSerializer.kt
M datastore/datastore-preferences/src/test/java/androidx/datastore/preferences/PreferencesSerializerTest.kt
M datastore/datastore-proto/src/main/java/androidx/datastore/protos/ProtoSerializer.kt
M datastore/datastore-proto/src/test/java/androidx/datastore/protos/ProtoSerializerTest.kt
M datastore/datastore-sampleapp/build.gradle
M datastore/datastore-sampleapp/src/main/java/com/example/datastoresampleapp/PreferencesDataStoreActivity.kt
M datastore/datastore-sampleapp/src/main/java/com/example/datastoresampleapp/ProtoDataStoreActivity.kt
M datastore/datastore-sampleapp/src/main/java/com/example/datastoresampleapp/SettingsFragment.kt
M datastore/datastore/api/api_lint.ignore
A datastore/datastore/api/current.txt
A datastore/datastore/api/public_plus_experimental_current.txt
A datastore/datastore/api/res-current.txt
A datastore/datastore/api/restricted_current.txt
A datastore/datastore/build.gradle
M datastore/datastore/src/androidTest/AndroidManifest.xml
A datastore/datastore/src/androidTest/java/androidx/datastore/DataStoreFactoryTest.kt
M datastore/datastore/src/androidTest/java/androidx/datastore/TestingSerializer.kt
M datastore/datastore/src/androidTest/java/androidx/datastore/migrations/SharedPreferencesMigrationTest.kt
M datastore/datastore/src/main/AndroidManifest.xml
A datastore/datastore/src/main/java/androidx/datastore/DataStoreFactory.kt
M datastore/datastore/src/main/java/androidx/datastore/migrations/SharedPreferencesMigration.kt
M settings.gradle

https://android-review.googlesource.com/1441928

mi...@google.com <mi...@google.com> #6Aug 8, 2018 04:32PM

Accepted by mi...@google.com.

This should be available in the next release.

mi...@google.com <mi...@google.com> #7Sep 12, 2018 01:16PM

Marked as fixed.

Thank you for your patience. Additional fixes have been released to completely resolve the issues reported here.

sp...@gmail.com <sp...@gmail.com> #8Jul 31, 2019 05:53AM

hello, i'm still having this issue.

Should this fix have become available automatically for my website or do I need to upgrade my maps script? How do I know what version i need to upgrade to?

mi...@google.com <mi...@google.com> #9Jul 31, 2019 07:19AM

The fix became available automatically for everybody. Please file a new bug with your current issue, commenting on a bug that was closed nearly a year ago may result in your comment not being noticed.

ar...@gmail.com <ar...@gmail.com> #10Apr 21, 2021 07:07AM

https://maps.googleapis.com/maps/api/place/autocomplete/json?input=11325%20s%20trent%20dr&key=key&types=address&components=country:us

for this address its giving wrong address