Android Studio is not persisting files to file system [111565517]

Fixed

Bug

Regression

Status Update

No update yet.

Description

mi...@gmail.com

created issue #1

Jul 18, 2018 11:00AM

In certain conditions, the file changes might not be saved on file system.

How to reproduce:
- You can use any project you want.
- Open a single file in the editor (important: only one should be opened).
- Change anything in the file.
- Without changing focus of the editor, close the file.
- Go to an external terminal e check if file content has changed (you can use `cat` or `git status` if using VCS).
- The content has not changed (?).
- Go back to Android Studio, do any action (focus on different sidebar, open any file, etc).
- Go back to external terminal.
- Check if file has changed -> now it has (!).

This is a big deal special for rebase conflicts scenarios, when you just open a file, fix the rebase issue (import missing dependencies, etc), close the file and continue the rebase on terminal (but the file was never updated in the first place).

Tested both on macOS and Linux using Android Studio 3.2-beta 4:

*Mac*
Build: 3.2 Beta 4, AI-181.5281.24.32.4886486, 201807111753,
AI-181.5281.24.32.4886486, JRE 1.8.0_152-release-1136-b04x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.13.5 unknown, screens 2560x1440
Android Gradle Plugin: 3.2.0-beta04
Gradle: 4.8.1
NDK: from local.properties: 17.1.4828580; latest from SDK: 17.1.4828580;
LLDB: LLDB 3.1 (revision: 3.1.4508709)
CMake: from local.properties: (not specified); latest from SDK: 3.6.0-rc2; from PATH: (not found);

*Linux*
Build: 3.2 Beta 4, AI-181.5281.24.32.4886486, 201807111753, AI-181.5281.24.32.4886486, JRE 1.8.0_152-release-1136-b04x64 JetBrains s.r.o, OS Linux(amd64) v4.17.5-200.fc28.x86_64 unknown, screens 1680x1050, 1920x1080, 1680x1050
Android Gradle Plugin: 3.1.3
Gradle: 4.5
NDK: from local.properties: 17.1.4828580; latest from SDK: 17.1.4828580;
LLDB: LLDB 3.1 (revision: 3.1.4508709)
CMake: from local.properties: (not specified); latest from SDK: 3.6.0-rc2; from PATH: (not found);

– Mickele

Comments

uc...@google.com <uc...@google.com> Jul 18, 2018 09:23PM

Assigned to tn...@google.com.

ma...@gmail.com <ma...@gmail.com> #2Jul 20, 2018 12:22PM

Hello,

Thank you for reaching out to us with your request.

We have duly noted your feedback and will thoroughly validate it. While we cannot provide an estimated time of implementation or guarantee the fulfillment of the issue, please be assured that your input is highly valued. Your feedback enables us to enhance our products and services.

We appreciate your continued trust and support in improving our Google Cloud Platform products. In case you want to report a new issue, Please do not hesitate to create a new issue on the Issue Tracker providing a detailed description of your issue.

Once again, we sincerely appreciate your valuable feedback; Thank you for your understanding and collaboration.

sa...@google.com <sa...@google.com> Jul 23, 2018 11:49AM

Reassigned to rp...@google.com.

rp...@google.com <rp...@google.com> #3Jul 26, 2018 07:17PM

Being able to view the available backups in console would be helpful

rp...@google.com <rp...@google.com> #4Jul 26, 2018 07:18PM

Accepted by rp...@google.com.

Note: I can also confirm this does NOT happen with AS 3.1.3 (Windows)

rp...@google.com <rp...@google.com> #5Jul 26, 2018 11:53PM

This is a bug in the IJ platform. Here is what is happening:
1) When closing the file editor, nothing happens (i.e. the file is not saved to disk)
2) When switching to another application (i.e. when activating any other application), IJ/AS detects it is being de-activated and posts message (an "Alarm") to save the file to disk in 200 msec.
3) 200msec later, the file is saved to disk

However, in never build 3) does not happen because there is another event in between 2) and 3) that re-activates the application and cancels the Alarm request. I believe this is a regression introduced by

https://github.com/JetBrains/intellij-community/commit/65871b384739b52b1c0450235bc742d2ba7fb137.

Here is the callstack where the Alarm posted in 2) is cancelled:

applicationActivated:58, FrameStateManagerImpl$2 (com.intellij.ide)
invoke:-1, GeneratedMethodAccessor226 (sun.reflect)
invoke:43, DelegatingMethodAccessorImpl (sun.reflect)
invoke:498, Method (java.lang.reflect)
deliverMessage:117, MessageBusConnectionImpl (com.intellij.util.messages.impl)
doPumpMessages:426, MessageBusImpl (com.intellij.util.messages.impl)
pumpWaitingBuses:387, MessageBusImpl (com.intellij.util.messages.impl)
pumpMessages:376, MessageBusImpl (com.intellij.util.messages.impl)
sendMessage:357, MessageBusImpl (com.intellij.util.messages.impl)
access$200:43, MessageBusImpl (com.intellij.util.messages.impl)
invoke:208, MessageBusImpl$2 (com.intellij.util.messages.impl)
applicationActivated:-1, $Proxy166 (com.sun.proxy)
setActive:135, ApplicationActivationStateManager (com.intellij.ide)
updateState:146, ApplicationActivationStateManager (com.intellij.ide)
isActive:1173, ApplicationImpl (com.intellij.openapi.application.impl)
getFocusOwner:276, FocusManagerImpl (com.intellij.openapi.wm.impl)
getFocusOwner:99, IdeFocusManagerImpl (com.intellij.openapi.wm.impl)
getActiveSplittersSync:267, FileEditorManagerImpl (com.intellij.openapi.fileEditor.impl)
getSplitters:1266, FileEditorManagerImpl (com.intellij.openapi.fileEditor.impl)
findNextFocusComponent:193, IdeFrameImpl (com.intellij.openapi.wm.impl)
access$100:63, IdeFrameImpl (com.intellij.openapi.wm.impl)
getInitialComponent:169, IdeFrameImpl$2 (com.intellij.openapi.wm.impl)
getMostRecentFocusOwner:2343, Window (java.awt)
storeLastFocusedComponent:794, IdeEventQueue (com.intellij.ide)
processAppActivationEvents:783, IdeEventQueue (com.intellij.ide)
_dispatchEvent:645, IdeEventQueue (com.intellij.ide)
dispatchEvent:394, IdeEventQueue (com.intellij.ide)
dispatch:70, SentEvent (java.awt)
dispatch:217, DefaultKeyboardFocusManager$DefaultKeyboardFocusManagerSentEvent (java.awt)
sendMessage:244, DefaultKeyboardFocusManager (java.awt)
dispatchEvent:755, DefaultKeyboardFocusManager (java.awt)
dispatchEvent:27, IdeKeyboardFocusManager (com.intellij.ide)
dispatchEventImpl:4768, Component (java.awt)
dispatchEventImpl:2295, Container (java.awt)
dispatchEventImpl:2746, Window (java.awt)
dispatchEvent:4719, Component (java.awt)
dispatchEventImpl:764, EventQueue (java.awt)
access$500:98, EventQueue (java.awt)
run:715, EventQueue$3 (java.awt)
run:709, EventQueue$3 (java.awt)
doPrivileged:-1, AccessController (java.security)
doIntersectionPrivilege:80, ProtectionDomain$JavaSecurityAccessImpl (java.security)
doIntersectionPrivilege:90, ProtectionDomain$JavaSecurityAccessImpl (java.security)
run:737, EventQueue$4 (java.awt)
run:735, EventQueue$4 (java.awt)
doPrivileged:-1, AccessController (java.security)
doIntersectionPrivilege:80, ProtectionDomain$JavaSecurityAccessImpl (java.security)
dispatchEvent:734, EventQueue (java.awt)
defaultDispatchEvent:815, IdeEventQueue (com.intellij.ide)
_dispatchEvent:756, IdeEventQueue (com.intellij.ide)
dispatchEvent:394, IdeEventQueue (com.intellij.ide)
dispatch:128, SequencedEvent (java.awt)
dispatchEventImpl:762, EventQueue (java.awt)
access$500:98, EventQueue (java.awt)
run:715, EventQueue$3 (java.awt)
run:709, EventQueue$3 (java.awt)
doPrivileged:-1, AccessController (java.security)
doIntersectionPrivilege:80, ProtectionDomain$JavaSecurityAccessImpl (java.security)
doIntersectionPrivilege:90, ProtectionDomain$JavaSecurityAccessImpl (java.security)
run:737, EventQueue$4 (java.awt)
run:735, EventQueue$4 (java.awt)
doPrivileged:-1, AccessController (java.security)
doIntersectionPrivilege:80, ProtectionDomain$JavaSecurityAccessImpl (java.security)
dispatchEvent:734, EventQueue (java.awt)
defaultDispatchEvent:815, IdeEventQueue (com.intellij.ide)
_dispatchEvent:756, IdeEventQueue (com.intellij.ide)
dispatchEvent:394, IdeEventQueue (com.intellij.ide)
pumpOneEventForFilters:201, EventDispatchThread (java.awt)
pumpEventsForFilter:116, EventDispatchThread (java.awt)
pumpEventsForHierarchy:105, EventDispatchThread (java.awt)
pumpEvents:101, EventDispatchThread (java.awt)
pumpEvents:93, EventDispatchThread (java.awt)
run:82, EventDispatchThread (java.awt)

rp...@google.com <rp...@google.com> #6Jul 27, 2018 05:19PM

I created

https://youtrack.jetbrains.com/issue/IDEA-196291 to track the IJ issue.

rp...@google.com <rp...@google.com> #7Aug 15, 2018 04:50PM

NoteO Fixed in upstream branch:

https://github.com/JetBrains/intellij-community/commit/cfa2db71d1b711592e6b0af7c398ce1f64e54aca

rp...@google.com <rp...@google.com> #8Aug 16, 2018 07:18PM

Note: Fix mentioned in #7 has a follow up fix:

https://github.com/JetBrains/intellij-community/commit/bf6fe0c056183622036d9532e3b51c1c87f6bc47

rp...@google.com <rp...@google.com> #9Sep 18, 2018 06:54PM

Assigned to ra...@google.com.

raluca: Do we want to cherry pick this in 3.3 or wait for the IJ merge?

ra...@google.com <ra...@google.com> #10Sep 18, 2018 07:00PM

Reassigned to da...@google.com.

I don't think 2018.3 is going in to 3.3, so I'd say it's safer to cherry-pick the fixes.

da...@google.com <da...@google.com> #11Sep 19, 2018 12:07AM

Accepted by da...@google.com.

Commits cfa2db7 and bf6fe0c are cherry-picked as 2bab959 and 2807724 respectively.

da...@google.com <da...@google.com> #12Oct 25, 2018 07:26PM

Marked as fixed.

The commits in

comment #11

should be included in Android Studio 3.3 Canary 12 et seq.