Navigation action default argument value [111569267]

Fixed

Bug

Status Update

No update yet.

Description

2m...@gmail.com

created issue #1

Jul 18, 2018 09:18AM

Component used: android.arch.navigation:navigation-fragment-ktx, android.arch.navigation:navigation-ui-ktx
Version used: 1.0.0-alpha03
Devices/Android versions reproduced on: Nexus 5 (6.0.1), Nexus 5x (8.1.0)

Expected behavior: When navigation action has an argument with default value, it should pass that to destination.
Actual behavior: Default value is is not used, passed bundle is empty.

Steps to reproduce:
I made this small app to demonstrate behavior:

https://github.com/2ma/NavigationActionBug

Comments

il...@google.com <il...@google.com> #2Jul 18, 2018 06:23PM

Assigned to wk...@google.com.

The weird thing is, i tested this on a fully resetted samsung s23 with Android 14, no way to reproduce the crash that other users and testers were experiencing.

Then i updated to One UI 6.0, and now i can consistently reproduce the IndexOutOfBoundsException.

il...@google.com <il...@google.com> #3Jul 18, 2018 06:31PM

I'm seeing this exact crash in production too.
Not limited to Samsung tho, we also have OnePlus and Sony users affected.

EDIT: I'm using version 2.9.0-alpha04 of the navigation library. But this crash goes way back.
The stacktrace is from 2.9.0-alpha04 tho.

Fatal Exception: java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 1
at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
at java.util.Objects.checkIndex(Objects.java:359)
at java.util.ArrayList.get(ArrayList.java:434)
at androidx.navigation.compose.NavHostKt$NavHost$28$1.invokeSuspend(NavHost.kt:620)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
at androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch(AndroidUiDispatcher.android.kt:79)
at androidx.compose.ui.platform.AndroidUiDispatcher.access$performTrampolineDispatch(AndroidUiDispatcher.android.kt:41)
at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.run(AndroidUiDispatcher.android.kt:57)
at android.os.Handler.handleCallback(Handler.java:958)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:230)
at android.os.Looper.loop(Looper.java:319)
at android.app.ActivityThread.main(ActivityThread.java:9063)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:588)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)

2m...@gmail.com <2m...@gmail.com> #4Jul 18, 2018 08:04PM

The same issue with me. Please fix it

il...@google.com <il...@google.com> #5Dec 6, 2018 10:48PM

Seeing this pop up again for us on some Samsung Galaxy S24 running Android 14.

navigation-compose 2.8.5

Fatal Exception: java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 1
       at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
       at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
       at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
       at java.util.Objects.checkIndex(Objects.java:359)
       at java.util.ArrayList.get(ArrayList.java:434)
       at androidx.navigation.compose.NavHostKt$NavHost$28$1.invokeSuspend(NavHost.kt:620)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
       at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
       at androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch(AndroidUiDispatcher.android.kt:81)
       at androidx.compose.ui.platform.AndroidUiDispatcher.access$performTrampolineDispatch(AndroidUiDispatcher.android.kt:41)
       at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.run(AndroidUiDispatcher.android.kt:57)
       at android.os.Handler.handleCallback(Handler.java:958)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:230)
       at android.os.Looper.loop(Looper.java:319)
       at android.app.ActivityThread.main(ActivityThread.java:9063)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:588)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)

wk...@google.com <wk...@google.com> Dec 7, 2018 05:01PM

Accepted by wk...@google.com.

il...@google.com <il...@google.com> #6Dec 11, 2018 06:22PM

Marked as fixed.

I am using navigation-compose = "2.8.6" and the same error is thrown.

The majority of devices affected are:

samsung dm3q
samsung a52q
realme REE2ADL1
samsung b2q

Exception java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 1
  at jdk.internal.util.Preconditions.outOfBounds (Preconditions.java:64)
  at jdk.internal.util.Preconditions.outOfBoundsCheckIndex (Preconditions.java:70)
  at jdk.internal.util.Preconditions.checkIndex (Preconditions.java:266)
  at java.util.Objects.checkIndex (Objects.java:359)
  at java.util.ArrayList.get (ArrayList.java:434)
  at androidx.navigation.compose.NavHostKt$NavHost$28$1.invokeSuspend (NavHost.kt:620)
  at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:33)
  at kotlinx.coroutines.DispatchedTask.run (DispatchedTask.kt:104)
  at androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch (AndroidUiDispatcher.android.kt:79)
  at androidx.compose.ui.platform.AndroidUiDispatcher.access$performTrampolineDispatch (AndroidUiDispatcher.android.kt:41)
  at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.run (AndroidUiDispatcher.android.kt:57)
  at android.os.Handler.handleCallback (Handler.java:958)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:230)
  at android.os.Looper.loop (Looper.java:319)
  at android.app.ActivityThread.main (ActivityThread.java:9063)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:588)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1103)

Issue 111569267