Verified
Status Update
No update yet.
Comments
ad...@google.com
We have passed this to the development team and will update this issue with more information as it becomes available.
cc...@google.com
Thanks for reporting, fixed internally, will go out with next release of recyclerview, as well as paging-runtime (which had the same issue in its AsyncPagedListDiffer).
rh...@abc.net.au
Hi, can you confirm whether the fix was included in the current release of recyclerview please?
cc...@google.com
Yes, this was included in RecyclerView 1.0.0 (and pre-androidx 28.0.0), confirmed by checking source jar.
Description
Version used: 27.1.1
Theme used: N/A
Devices/Android versions reproduced on: Any
Regarding the check at the top of `submitList` here:
```
if (newList == mList) {
// nothing to do
return;
}
```
There's a race condition -- suppose we have lists A and B, and the differ's `mList` before starting is list A.
1. Submit list B - async diff generation N kicks off
2. Submit list A - `newList` matches `mList` since diff gen N hasn't completed yet, but `mMaxScheduledGeneration` is not incremented and this returns early
3. Async diff gen N is accepted, despite list A being submitted after list B.
Seems this could be fixed by incrementing `mMaxScheduledGeneration`. As a workaround, I am wrapping my lists in a new identity before submitting them to the differ.