assumevalues+assumenosideeffects not removing framework method call [111763015]

Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Jul 23, 2018 10:19PM

I am trying to remove a call to a framework API and replace it with a constant value but no combination of -assumevalue and -assuemnosideeffects seems to work.

$ java -version
java version "1.8.0_144"
Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)

$ java -jar ~/dev/android/r8/build/libs/r8.jar --version
R8 1.3.11-dev
build engineering

$ cat Test.java
import java.util.Random;

public class Test {
public static void main(String... args) {
Random random = new Random();
if (random.nextBoolean()) {
System.out.println("True");
} else {
System.out.println("False");
}
}
}

$ cat keep.txt
-keep public class * {
public static void main(...);
}
-assumevalues class java.util.Random {
boolean nextBoolean() return false;
}

$ javac Test.java

$ java -jar ~/dev/android/r8/build/libs/r8.jar --lib $ANDROID_HOME/platforms/android-28/android.jar --release --output . --pg-conf keep.txt Test.class

$ $ANDROID_HOME/build-tools/27.0.3/dexdump -d classes.dex
(snipped)
000158: |[000158] Test.main:([Ljava/lang/String;)V
000168: 2201 0500 |0000: new-instance v1, Ljava/util/Random; // type@0005
00016c: 7010 0200 0100 |0002: invoke-direct {v1}, Ljava/util/Random;.<init>:()V // method@0002
000172: 6e10 0300 0100 |0005: invoke-virtual {v1}, Ljava/util/Random;.nextBoolean:()Z // method@0003
000178: 0a01 |0008: move-result v1
00017a: 3801 0a00 |0009: if-eqz v1, 0013 // +000a
00017e: 6201 0000 |000b: sget-object v1, Ljava/lang/System;.out:Ljava/io/PrintStream; // field@0000
000182: 1a00 0900 |000d: const-string v0, "True" // string@0009
000186: 6e20 0100 0100 |000f: invoke-virtual {v1, v0}, Ljava/io/PrintStream;.println:(Ljava/lang/String;)V // method@0001
00018c: 2808 |0012: goto 001a // +0008
00018e: 6201 0000 |0013: sget-object v1, Ljava/lang/System;.out:Ljava/io/PrintStream; // field@0000
000192: 1a00 0200 |0015: const-string v0, "False" // string@0002
000196: 6e20 0100 0100 |0017: invoke-virtual {v1, v0}, Ljava/io/PrintStream;.println:(Ljava/lang/String;)V // method@0001
00019c: 0e00 |001a: return-void

Using only -assumevalues has no effect on the bytecode as the call to nextBoolean() and both branches are still present.

I also tried:

-keep public class * {
public static void main(...);
}
-assumevalues class java.util.Random {
boolean nextBoolean() return false;
}
-assumenosideeffects class java.util.Random {
boolean nextBoolean();
}

for the keep.txt file. No change.

The -assumenosideeffects syntax also allows the 'return' clause so I tried that. I also tried removing -assumevalues. All 4 combinations do not result in the elimination of this method call.

This example is contrived, obviously, but there exists at least one valid use case for this: View.isInEditMode() always returns false at runtime and never needs invoked and any code inside a conditional eliminated.

Comments

ja...@gmail.com <ja...@gmail.com> #2Jul 27, 2018 02:11PM

    assertTrue(Double.NaN.coerceIn(0.0, 1.0).isNaN())
    assertTrue(Double.NaN.coerceIn(0.0..1.0).isNaN())

https://github.com/JetBrains/kotlin/blob/master/libraries/stdlib/test/ranges/CoercionTest.kt

ja...@gmail.com <ja...@gmail.com> #3Aug 21, 2018 07:34PM

Low-hanging fruit. Shalom, mind taking a look during your work for PIs and loaders?

sg...@google.com <sg...@google.com> #4Aug 22, 2018 07:21AM

We can check for NaN, but what is the expected behavior here if a NaN is passed in?

We can throw an exception, but that would end in the same result you are experiencing now (i.e. a crash if you don't handle it)
We can just set the progress to zero in cases of NaNs, but then you would not be able to tell that you have a problem in your implementation and you are passing in illegal values.
We can document it that we only expect a non NaN values, but that seems a bit redundant and we don't usually adding these to the docs as it's implicit in most cases.

ja...@gmail.com <ja...@gmail.com> #5Aug 22, 2018 01:44PM

On my end, I discovered it was caused by division by zero and just set the bar to indeterminate in that case.

ag...@google.com <ag...@google.com> Sep 12, 2018 05:45PM

Assigned to ag...@google.com.

ja...@gmail.com <ja...@gmail.com> #6Jan 19, 2019 05:50AM

I also experience this crash in our released app, I can reproduce this with both Material2 and Material3 with latest stable and alpha-versions, but only with enabled Talkback-service.

Since this crash only happens with enabled Talkback-service and the app works fine otherwise, I consider this to be a bug in the interaction between Talkback and the participating Material-compose frameworks.

build.gradle:

    implementation "androidx.compose.material:material:1.8.0-alpha08"
    implementation "androidx.compose.material3:material3:1.4.0-alpha06"

Minimal reproducible examples:

@Preview
@Composable
private fun MinimalReproducibleExampleM2Preview() {
    androidx.compose.material.LinearProgressIndicator(
        modifier =
            Modifier
                .fillMaxWidth()
                .height(12.dp),
        progress = 0f / 0f,
    )
}

@Preview
@Composable
private fun MinimalReproducibleExampleM3Preview() {
    androidx.compose.material3.LinearProgressIndicator(
        modifier =
            Modifier
                .fillMaxWidth()
                .height(12.dp),
        progress = { 0f / 0f },
    )
}

Crash in Material2:

FATAL EXCEPTION: main (Ask Gemini)
Process: de.billiger.android, PID: 416
java.lang.IllegalArgumentException: current must not be NaN
	at androidx.compose.ui.semantics.ProgressBarRangeInfo.<init>(SemanticsProperties.kt:662)
	at androidx.compose.foundation.ProgressSemanticsKt$progressSemantics$1.invoke(ProgressSemantics.kt:53)
	at androidx.compose.foundation.ProgressSemanticsKt$progressSemantics$1.invoke(ProgressSemantics.kt:51)
	at androidx.compose.ui.semantics.CoreSemanticsModifierNode.applySemantics(SemanticsModifier.kt:59)
	at androidx.compose.ui.node.LayoutNode$collapsedSemantics$1.invoke(LayoutNode.kt:442)
	at androidx.compose.ui.node.LayoutNode$collapsedSemantics$1.invoke(LayoutNode.kt:433)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2496)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:460)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:244)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeSemanticsReads$ui_release(OwnerSnapshotObserver.kt:121)
	at androidx.compose.ui.node.LayoutNode.getCollapsedSemantics$ui_release(LayoutNode.kt:433)
	at androidx.compose.ui.semantics.SemanticsNodeKt.SemanticsNode(SemanticsNode.kt:49)
	at androidx.compose.ui.semantics.SemanticsNode.fillOneLayerOfSemanticsWrappers(SemanticsNode.kt:278)
	at androidx.compose.ui.semantics.SemanticsNode.unmergedChildren$ui_release(SemanticsNode.kt:257)
	at androidx.compose.ui.semantics.SemanticsNode.getChildren$ui_release(SemanticsNode.kt:338)
	at androidx.compose.ui.semantics.SemanticsNode.getChildren$ui_release$default(SemanticsNode.kt:322)
	at androidx.compose.ui.semantics.SemanticsNode.getReplacedChildren$ui_release(SemanticsNode.kt:305)
	at androidx.compose.ui.platform.SemanticsUtils_androidKt.getAllUncoveredSemanticsNodesToIntObjectMap$findAllSemanticNodesRecursive(SemanticsUtils.android.kt:195)
	at androidx.compose.ui.platform.SemanticsUtils_androidKt.getAllUncoveredSemanticsNodesToIntObjectMap(SemanticsUtils.android.kt:230)
	at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.getCurrentSemanticsNodes(AndroidComposeViewAccessibilityDelegateCompat.android.kt:311)
	at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.createEvent(AndroidComposeViewAccessibilityDelegateCompat.android.kt:1577)
	at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.sendEventForVirtualView(AndroidComposeViewAccessibilityDelegateCompat.android.kt:1519)
	at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.sendEventForVirtualView$default(AndroidComposeViewAccessibilityDelegateCompat.android.kt:1509)
	at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.sendSubtreeChangeAccessibilityEvents(AndroidComposeViewAccessibilityDelegateCompat.android.kt:2377)
	at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.boundsUpdatesEventLoop$ui_release(AndroidComposeViewAccessibilityDelegateCompat.android.kt:2251)
	at androidx.compose.ui.platform.AndroidComposeView.boundsUpdatesAccessibilityEventLoop(AndroidComposeView.android.kt:1639)
	at androidx.compose.ui.platform.WrappedComposition$setContent$1$1$1$1.invokeSuspend(Wrapper.android.kt:148)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
	at androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch(AndroidUiDispatcher.android.kt:81)
	at androidx.compose.ui.platform.AndroidUiDispatcher.access$performTrampolineDispatch(AndroidUiDispatcher.android.kt:41)
	at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:68)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1299)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1309) (Ask Gemini)
	at android.view.Choreographer.doCallbacks(Choreographer.java:923)
	at android.view.Choreographer.doFrame(Choreographer.java:847)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1283)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:226)
	at android.os.Looper.loop(Looper.java:313)
	at android.app.ActivityThread.main(ActivityThread.java:8762)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:604)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@93d2fd8, androidx.compose.runtime.BroadcastFrameClock@cb15f31, StandaloneCoroutine{Cancelling}@36ca616, AndroidUiDispatcher@ae19b97]

Crash in Material3:

FATAL EXCEPTION: main (Ask Gemini)
Process: de.billiger.android, PID: 4219
java.lang.IllegalArgumentException: current must not be NaN
	at androidx.compose.ui.semantics.ProgressBarRangeInfo.<init>(SemanticsProperties.kt:662)
	at androidx.compose.ui.semantics.ProgressBarRangeInfo.<init>(SemanticsProperties.kt:655)
	at androidx.compose.material3.ProgressIndicatorKt$LinearProgressIndicator$3$1.invoke(ProgressIndicator.kt:156)
	at androidx.compose.material3.ProgressIndicatorKt$LinearProgressIndicator$3$1.invoke(ProgressIndicator.kt:155)
	at androidx.compose.ui.semantics.CoreSemanticsModifierNode.applySemantics(SemanticsModifier.kt:59)
	at androidx.compose.ui.node.LayoutNode$collapsedSemantics$1.invoke(LayoutNode.kt:442)
	at androidx.compose.ui.node.LayoutNode$collapsedSemantics$1.invoke(LayoutNode.kt:433)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2496)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:460)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:244)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeSemanticsReads$ui_release(OwnerSnapshotObserver.kt:121)
	at androidx.compose.ui.node.LayoutNode.getCollapsedSemantics$ui_release(LayoutNode.kt:433)
	at androidx.compose.ui.semantics.SemanticsNodeKt.SemanticsNode(SemanticsNode.kt:49)
	at androidx.compose.ui.semantics.SemanticsNode.fillOneLayerOfSemanticsWrappers(SemanticsNode.kt:278)
	at androidx.compose.ui.semantics.SemanticsNode.unmergedChildren$ui_release(SemanticsNode.kt:257)
	at androidx.compose.ui.semantics.SemanticsNode.getChildren$ui_release(SemanticsNode.kt:338)
	at androidx.compose.ui.semantics.SemanticsNode.getChildren$ui_release$default(SemanticsNode.kt:322)
	at androidx.compose.ui.semantics.SemanticsNode.getReplacedChildren$ui_release(SemanticsNode.kt:305)
	at androidx.compose.ui.platform.SemanticsUtils_androidKt.getAllUncoveredSemanticsNodesToIntObjectMap$findAllSemanticNodesRecursive(SemanticsUtils.android.kt:195)
	at androidx.compose.ui.platform.SemanticsUtils_androidKt.getAllUncoveredSemanticsNodesToIntObjectMap(SemanticsUtils.android.kt:230)
	at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.getCurrentSemanticsNodes(AndroidComposeViewAccessibilityDelegateCompat.android.kt:311)
	at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.createEvent(AndroidComposeViewAccessibilityDelegateCompat.android.kt:1577)
	at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.sendEventForVirtualView(AndroidComposeViewAccessibilityDelegateCompat.android.kt:1519)
	at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.sendEventForVirtualView$default(AndroidComposeViewAccessibilityDelegateCompat.android.kt:1509)
	at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.sendSubtreeChangeAccessibilityEvents(AndroidComposeViewAccessibilityDelegateCompat.android.kt:2377)
	at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.boundsUpdatesEventLoop$ui_release(AndroidComposeViewAccessibilityDelegateCompat.android.kt:2251)
	at androidx.compose.ui.platform.AndroidComposeView.boundsUpdatesAccessibilityEventLoop(AndroidComposeView.android.kt:1639)
	at androidx.compose.ui.platform.WrappedComposition$setContent$1$1$1$1.invokeSuspend(Wrapper.android.kt:148)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
	at androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch(AndroidUiDispatcher.android.kt:81)
	at androidx.compose.ui.platform.AndroidUiDispatcher.access$performTrampolineDispatch(AndroidUiDispatcher.android.kt:41)
	at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:68) (Ask Gemini)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1299)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1309)
	at android.view.Choreographer.doCallbacks(Choreographer.java:923)
	at android.view.Choreographer.doFrame(Choreographer.java:847)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1283)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:226)
	at android.os.Looper.loop(Looper.java:313)
	at android.app.ActivityThread.main(ActivityThread.java:8762)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:604)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@f9ecebb, androidx.compose.runtime.BroadcastFrameClock@93d2fd8, StandaloneCoroutine{Cancelling}@cb15f31, AndroidUiDispatcher@36ca616]

ag...@google.com <ag...@google.com> Jan 29, 2019 05:44AM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> #7Jan 29, 2019 10:12AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Shalom Gibly <sgibly@google.com>
Link: https://android-review.googlesource.com/3461097

Prevent a crash when Float.NaN is a progress value

Expand for full commit details

Prevent a crash when Float.NaN is a progress value 
 
- Check for a NaN value and return zero if a progress lambda is 
  producing it and passing it into a `ProgressBarRangeInfo`. The range 
  info will throw an exception if a NaN is passed in. 
- Applied the check at the progress indicators (M3 & M2), and at the 
  loading indicator. 
- The remaining implementation does not cras on NaN, but the UI usually 
  does not render anything. 
- Also, switched to use `fastCoerceIn` instead of `coerceIn`. 
 
Test: Added 
Fixes: 352364576 
Relnote: "Fixed a crash at the progress and loading indicators in case a 
Float.NaN is passed in as a progress." 
 
Change-Id: I4fa969a1d46358a6f1db8b28cb0a375a809102c2

Files:

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ProgressIndicator.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/LoadingIndicatorTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ProgressIndicatorTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/WavyProgressIndicatorTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/LoadingIndicator.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ProgressIndicator.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/WavyProgressIndicator.kt

Hash: bf90726d0c7fadd916c5c8bf38b18f6a9a5d7a6b
Date: Wed Jan 22 16:28:41 2025

ch...@google.com <ch...@google.com> Feb 4, 2019 11:38AM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> #8May 21, 2019 08:32AM

Thank you!

ch...@google.com <ch...@google.com> #9May 21, 2019 08:39AM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha08
androidx.compose.material3:material3-android:1.4.0-alpha08
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha08
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha08