IssueTracker

Not reproduces, can you share a sample project where this issue can be reproducible.

Adding 2 zips:

NavigaionCreateTest.zip generates correct files.

Sunflower004 does NOT create correct files.

RG

reproduced with Canary 6

This isn't related to the navigation editor. Right now it looks like the template mechanism generates old-style fragments if you're not using an appcompat theme.
Reassigning to Jose to confirm that this is the desired behavior.

Progress so far...

- Can reproduce using #3 Sunflower, but is OK on a new Project (or #3 NavigationCreateTest).
It will reproduce just by adding a new BlankFragment from right click "app" > New > Fragment > Fragment (Blank)

- The template code that adds the import is:
import ${getMaterialComponentName('android${SupportPackage}.app.Fragment', useAndroidX)};

- ${SupportPackage} is (wrongly) set to "", so the package used is the deprecated "android.app.Fragment"

- ${SupportPackage} is defined as: <global id="SupportPackage" value="${useSupport?string('.support.v4','')}" />
and ${useSupport} is (wrongly) set to false

- "useSupport" is provided by Android Studio through FmGetApplicationThemeMethod
and the value is determined by ThemeHelper@isAppCompatTheme(themeName)

I'll try to find out what is the difference in the two App Theme, that would cause isAppCompatTheme() to return false

Following on #6, the "problem" boils down to the fact that
Sunflower project theme is Theme.MaterialComponents.Light.DarkActionBar and
NavigationCreateTest theme is Theme.AppCompat.Light.DarkActionBar

If I change Sunflower theme to Theme.AppCompat.Light.DarkActionBar, then adding a new Fragment will use an import for "androidx.fragment.app.Fragment"

I'm not sure how to progress this. I'm a bit confused why we check the theme of the Application to determine the support for "app compat", instead of checking if the "app compat library" is one of project dependency...

@Diego @Jens do you have any background on this?

This is a while ago, but I think the thinking at the time was:

A project can have a dependency on appcompat without actually using it.
However when the theme is an appcompat theme the activity generated must be: AppCompatActivity.

Perhaps that is no longer a valid assumption ??!

On a side note: It is interesting that the SunFlower project is using a non appcompat theme but is using the material library.
That will normally create problems.

#8 Thanks Jens!
Trevor, can you please take a look at this? We are not sure if this a bug or if the Wizard templates need to be updated

I think we should use android.support.v4.app.Fragment or androidx.fragment.app.Fragment in the imporrt statement.

import ${getMaterialComponentName('android${SupportPackage}.app.Fragment', useAndroidX)};

So the logic around ${SupportPackage} should be removed. There is no reason to support android.app.Fragment at this moment.