WAI
Status Update
Comments
jf...@google.com <jf...@google.com> #2
I believe this is for the shim library but it's unclear who the new owner is now, so please triage and reassign.
da...@gmail.com <da...@gmail.com> #3
#2:
> The maximum page size for requests has been changed to 100, per the error returned by these calls
"per the error": ... the error returned by these calls does not actually indicate the page size has been changed. Did you intend to convey we had the information to understand what was wrong?
1. please update the external facing docs *before* changing the APIs in the future. From a user point of view: it's fine to accept more than you promise, but it's not okay to accept less.
2. It might be helpful to have a "release notes" indicating what you've changing. My process upon seeing APIs were broken:
- well, it's a Beta API, let's go look at release notes. Um, never mind, those don't exist.
- let's go look at docs. Nope, this all looks the same as last time I looked.
- let's send no parameters and see if that works?
- okay, it does, let's bisect.
Would have been helpful to see "30 August: maximum pageSize is now 100" front and center somewhere.
> The maximum page size for requests has been changed to 100, per the error returned by these calls
"per the error": ... the error returned by these calls does not actually indicate the page size has been changed. Did you intend to convey we had the information to understand what was wrong?
1. please update the external facing docs *before* changing the APIs in the future. From a user point of view: it's fine to accept more than you promise, but it's not okay to accept less.
2. It might be helpful to have a "release notes" indicating what you've changing. My process upon seeing APIs were broken:
- well, it's a Beta API, let's go look at release notes. Um, never mind, those don't exist.
- let's go look at docs. Nope, this all looks the same as last time I looked.
- let's send no parameters and see if that works?
- okay, it does, let's bisect.
Would have been helpful to see "30 August: maximum pageSize is now 100" front and center somewhere.
de...@gmail.com <de...@gmail.com> #4
+1 my app also randomly broke and had to spend time experimenting figuring out what the proper size is. The error does not state the proper size just says its invalid.
jf...@google.com <jf...@google.com> #5
This is now documented as part of our latest release: https://developers.google.com/photos/library/support/release-notes#2018-09-05
The missing error message is an issue on our side, it API calls are meant to return a more useful response pointing to the page size limits. We'll work on getting this updated.
I'll close this issue for now, as the documentation is updated and the maximum page size has been changed to 100.
Our apologies for not being clearer in the documentation earlier.
The missing error message is an issue on our side, it API calls are meant to return a more useful response pointing to the page size limits. We'll work on getting this updated.
I'll close this issue for now, as the documentation is updated and the maximum page size has been changed to 100.
Our apologies for not being clearer in the documentation earlier.
da...@gmail.com <da...@gmail.com> #6
Fantastic all around. Thanks!
Description
Steps:
1. Broken: Call
Note: This was working up until yesterday Aug 30. Today we discovered that it is returning an error - see below.
2. Not Broken: Call
Error returned:
Code 400
Invalid argument
This happens in debug as well.
Our approved scopes are: