Status Update
Comments
lf...@google.com <lf...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 53d7e9505dce7026e7c92059d42e5de784739106
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 16:26:25 2021
Avoid nullable boolean in constraint trackers
Now instead of returning null, trackers work pessimistically,
e.g. BatteryChargingTracker says that battery isn't charging.
It is done in preparation for Kotlin migration, where
this code smell is more apparent.
bug: 209145335
Test: *TrackerTest were updated
Change-Id: Ie1dcbe8961d925784d5633a297307993f3b8a43b
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/ConstraintTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.java
https://android-review.googlesource.com/1911432
Branch: androidx-main
commit 53d7e9505dce7026e7c92059d42e5de784739106
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 16:26:25 2021
Avoid nullable boolean in constraint trackers
Now instead of returning null, trackers work pessimistically,
e.g. BatteryChargingTracker says that battery isn't charging.
It is done in preparation for Kotlin migration, where
this code smell is more apparent.
bug: 209145335
Test: *TrackerTest were updated
Change-Id: Ie1dcbe8961d925784d5633a297307993f3b8a43b
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/ConstraintTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.java
ma...@gmail.com <ma...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 37b6a3fbb83456e319412c81f5039ffede5571c1
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:33:19 2021
Bump room 2.4.0-rc01
bug: 209145335
Test: refactoring
Change-Id: I29efb1b5a2e49ceddae999ed244803889723b080
M work/work-runtime/build.gradle
M work/work-runtime-ktx/build.gradle
M work/work-inspection/build.gradle
M work/work-gcm/build.gradle
M work/work-multiprocess/build.gradle
M work/work-benchmark/build.gradle
M work/work-testing/build.gradle
M work/integration-tests/testapp/build.gradle
https://android-review.googlesource.com/1910055
Branch: androidx-main
commit 37b6a3fbb83456e319412c81f5039ffede5571c1
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:33:19 2021
Bump room 2.4.0-rc01
bug: 209145335
Test: refactoring
Change-Id: I29efb1b5a2e49ceddae999ed244803889723b080
M work/work-runtime/build.gradle
M work/work-runtime-ktx/build.gradle
M work/work-inspection/build.gradle
M work/work-gcm/build.gradle
M work/work-multiprocess/build.gradle
M work/work-benchmark/build.gradle
M work/work-testing/build.gradle
M work/integration-tests/testapp/build.gradle
Description
Android Studio Version:
3.2.1
Emulator Version (Emulator--> Extended Controls--> Emulator Version):
27.3.10-4969155 (HVF 10.14.0)
HAXM / KVM Version:
7.3.2
Android SDK Tools:
Host Operating System:
macOS 10.14.1
CPU Manufacturer: [Intel / AMD / Other]
intel 2.2 GHz Intel Core i7 (MacBook Pro (Retina, 15-inch, Mid 2014))
Steps to Reproduce Bug:
1. Close the emulator (and have the save the state option enabled)
2. While saving the state, the whole system crashes
Expected Behavior:
Should not crash
Observed Behavior:
macOS system crahes:
*** Panic Report ***
panic(cpu 6 caller 0xffffff8003ad84dd): Kernel trap at 0xffffff7f862267a3, type 14=page fault, registers:
CR0: 0x0000000080010033, CR2: 0x0000000000000000, CR3: 0x00000001febd5185, CR4: 0x00000000001626e0
RAX: 0x0000000000000040, RBX: 0xffffff8033e2f800, RCX: 0x0000000000000000, RDX: 0xffffff922426b8f0
RSP: 0xffffff922426b7a0, RBP: 0xffffff922426b7d0, RSI: 0xffffff922426b8d8, RDI: 0x0000000000000000
R8: 0xffffff804e7f8400, R9: 0x0000000000000040, R10: 0xffffff800429d8e8, R11: 0xffffff7f861fd2c0
R12: 0x0000000000000000, R13: 0x0000000000000000, R14: 0xffffff922426b8f0, R15: 0xffffff922426b8d8
RFL: 0x0000000000010246, RIP: 0xffffff7f862267a3, CS: 0x0000000000000008, SS: 0x0000000000000010
Fault CR2: 0x0000000000000000, Error code: 0x0000000000000000, Fault CPU: 0x6, PL: 0, VF: 0
Backtrace (CPU 6), Frame : Return Address
0xffffff922426b270 : 0xffffff80039aca9d
0xffffff922426b2c0 : 0xffffff8003ae6893
0xffffff922426b300 : 0xffffff8003ad82ba
0xffffff922426b370 : 0xffffff8003959ca0
0xffffff922426b390 : 0xffffff80039ac4b7
0xffffff922426b4b0 : 0xffffff80039ac303
0xffffff922426b520 : 0xffffff8003ad84dd
0xffffff922426b690 : 0xffffff8003959ca0
0xffffff922426b6b0 : 0xffffff7f862267a3
0xffffff922426b7d0 : 0xffffff7f861fd55b
0xffffff922426ba40 : 0xffffff8004086779
0xffffff922426ba90 : 0xffffff800408522b
0xffffff922426bae0 : 0xffffff7f84cd0fa4
0xffffff922426bb30 : 0xffffff800408e52f
0xffffff922426bc70 : 0xffffff8003a92ef4
0xffffff922426bd80 : 0xffffff80039b218d
0xffffff922426bdd0 : 0xffffff800398cb45
0xffffff922426be50 : 0xffffff80039a14fe
0xffffff922426bef0 : 0xffffff8003abfa0b
0xffffff922426bfa0 : 0xffffff800395a486
Kernel Extensions in backtrace:
com.apple.iokit.IOAcceleratorFamily2(400.27)[5BC3E111-E908-36E8-9AFB-A39BD0D561D5]@0xffffff7f84cb1000->0xffffff7f84d55fff
dependency: com.apple.driver.AppleMobileFileIntegrity(1.0.5)[66A1BDE1-514B-3B0D-87DD-8E2B9F110A8C]@0xffffff7f84c20000
dependency: com.apple.iokit.IOSurface(255.1)[B153C6D6-2542-3D6F-A21F-B56D9E1349DF]@0xffffff7f84c8d000
dependency: com.apple.iokit.IOPCIFamily(2.9)[7DE930EC-AB73-3F5A-9D38-94D5EE90D197]@0xffffff7f84295000
dependency: com.apple.iokit.IOGraphicsFamily(530.12)[9D1E5FA7-267E-397E-9C91-1751221A05CF]@0xffffff7f84820000
dependency: com.apple.iokit.IOReportFamily(47)[6A9FF3E1-E644-3F33-8A44-8B51C44AA67C]@0xffffff7f8451a000
com.apple.driver.AppleIntelHD5000Graphics(12.0.2)[D8908CD8-D54B-3FD5-B1CF-76BB24CBF2EA]@0xffffff7f861f4000->0xffffff7f8626efff
dependency: com.apple.iokit.IOSurface(255.1)[B153C6D6-2542-3D6F-A21F-B56D9E1349DF]@0xffffff7f84c8d000
dependency: com.apple.iokit.IOPCIFamily(2.9)[7DE930EC-AB73-3F5A-9D38-94D5EE90D197]@0xffffff7f84295000
dependency: com.apple.iokit.IOGraphicsFamily(530.12)[9D1E5FA7-267E-397E-9C91-1751221A05CF]@0xffffff7f84820000
dependency: com.apple.iokit.IOAcceleratorFamily2(400.27)[5BC3E111-E908-36E8-9AFB-A39BD0D561D5]@0xffffff7f84cb1000
BSD process name corresponding to current thread: qemu-system-x86_
Mac OS version:
18B75