The default GitHub Triggers builds refs/pull/<issue>/head but not refs/pull/<issue>/merge [119662038]

Obsolete

Feature Request

Status Update

No update yet.

Description

br...@sourcery.ai

created issue #1

Nov 16, 2018 03:50PM

A pull request has 2 refs associated with it in github
1. refs/pull/<issue-no>/head - this has the code from the pull request branch
2. refs/pull/<issue-no>/merge - this has the code from merging the pull request into master

The default trigger runs over 1 only. Ideally it should run over both of these refs (Note that travis-ci does this

https://docs.travis-ci.com/user/pull-requests/#double-builds-on-pull-requests ). I tried to setup a build over 2 but it doesn't seem to be possible to access either of these 2 refs from within the trigger menu. It seems as though the regex only matches refs like refs/heads/<regex>.

It's possible to see all of these branches in github with the command: git ls-remote

The ideal solution would be to extend the default trigger to perform 2 builds over both of above refs.
It would also be good to be able to access these refs from within the 'add trigger' menu

Comments

wa...@google.com <wa...@google.com> #2Nov 17, 2018 03:43PM

Assigned to gc...@google.com.

This issue was migrated from

https://crbug.com/1002993.

ry...@gmail.com <ry...@gmail.com> #3Sep 9, 2019 06:16AM

Any update on this issue?

e....@gmail.com <e....@gmail.com> #4Oct 29, 2019 01:38AM

This is a very useful feature whose absence is causing me to change my build pipeline.

mj...@gmail.com <mj...@gmail.com> #5Oct 29, 2019 10:28AM

It might be worth noting for watchers of this thread that you can check "Require branches to be up to date before merging" in Github branch protection rules to essentially enforce that the two builds are the same.

kn...@google.com <kn...@google.com> May 13, 2021 11:23PM

Status: Won't Fix (Obsolete)

ti...@houtbecke.rs <ti...@houtbecke.rs> #6May 14, 2021 07:55PM

Curious, how is this feature obsolete? Most other CI systems work as this feature suggest. Without this feature you still will not know if your merged branch will actually build before merging.

ch...@rocketlawyer.com <ch...@rocketlawyer.com> #7Jul 8, 2021 07:17PM

Probably they saw

comment #5

in a bug cleanup and falsely determined that it fixed the issue when it's really just a workaround that requires manual upkeep.

Message last modified on Jul 8, 2021 07:18PM