IssueTracker

I also encountered this problem

We need a more reproducible scenario. Perhaps you can create a test project where this issue occurs, and then share the project with us?

uchidige@: Were you able to reproduce this? If so, can you share your project?

Problem is fixed in 3.4 Beta 1 with gradle 3.4.0-beta01.

 

 

From: buganizer-system@google.com <buganizer-system@google.com>
Sent: Wednesday, January 23, 2019 12:33 PM
To: b-system+1339686801@google.com
Cc: coolapps726@gmail.com
Subject: Re: Issue 122450679: Can not break on if statements

 

Replying to this email means your email address will be shared with the team that works on this product.


https://issuetracker.google.com/issues/122450679

Changed
assignee:  rp...@google.com <mailto:rp...@google.com>   →  uc...@google.com <mailto:uc...@google.com>

 <mailto:vs...@google.com> vs...@google.com added comment #3 <https://issuetracker.google.com/issues/122450679#comment3> :
We need a more reproducible scenario. Perhaps you can create a test project where this issue occurs, and then share the project with us?

uchidige@: Were you able to reproduce this? If so, can you share your project?

_______________________________


Reference Info: 122450679 Can not break on if statements

component:  Android Public Tracker > App Development > Android Studio > Run Debug > Debugger
status:  Assigned
reporter:  coolapps726@gmail.com <mailto:coolapps726@gmail.com>
assignee:  uc...@google.com <mailto:uc...@google.com>
cc:  coolapps726@gmail.com <mailto:coolapps726@gmail.com> , uc...@google.com <mailto:uc...@google.com>
type:  Bug P1 S1
duplicate issue:  122879708 <https://issuetracker.google.com/issues/122879708> , 122937069 <https://issuetracker.google.com/issues/122937069>
found in:  5183351



Generated by Google IssueTracker notification system

You're receiving this email because you are subscribed to updates on Google IssueTracker issue 122450679 <https://issuetracker.google.com/issues/122450679>  where you have the roles: reporter, cc.

This issue reproduces with simple project setup.

Yes, I can repro this in the attached project (comment #5). Thanks uchidige@.

For reference, if you set breakpoints on the following 2 lines:

        if(x>5){
            System.out.println(" X > 5");

the breakpoint on the if(x>5) line is never enabled.

I suspect that this is either a dex level issue. ager@: Would someone on your team be able to take a quick look?

The fact that this is fixed in "3.4 Beta 1 with gradle 3.4.0-beta01" (per comment #4) indicates that the issue is definitely in the build tool chain (gradle, d8/r8).

Project: r8
Branch: master

commit f37c60cd48b16f9c38f41e0b414dd5180c6080a9
Author: Ian Zerny <zerny@google.com>
Date:   Mon Feb 04 13:11:04 2019

    Regression test for breakpoint issue.
   
    The issue does not occur on ToT due to better debug position pruning, so this is
    just the regression test for cherry-picking.
   
    R=mkrogh
   
    Bug: 122450679
    Change-Id: I223289627683aff49883337ff3ce9677086a3fcb

A       src/test/java/com/android/tools/r8/debug/BreakOnIfTest.java
A       src/test/java/com/android/tools/r8/debug/BreakOnIfTestRunner.java

https://r8-review.googlesource.com/33781

This issue appears to be in the underlying debugger protocol in studio/intellij. I've filed a new bug for tracking that analysis in b/123863053.

The issue happens when a nop is inserted with the same line information as the conditional at its branching target. Doing so is can be avoided and appears to work around the issue.

Project: r8
Branch: d8-1.3

commit cf5de3664462e1c9d1b6066b9bbc9cb13f09c013
Author: Ian Zerny <zerny@google.com>
Date:   Mon Feb 04 14:30:45 2019

    Version 1.3.55
   
    Cherry pick: Remove trivial gotos after removing debug positions.
    CL: https://r8-review.googlesource.com/c/r8/+/27740
   
    Cherry pick: Refine algorithm determining the active line at block entry.
    CL: https://r8-review.googlesource.com/c/r8/+/27502
   
    Cherry pick: Regression test for breakpoint issue.
    CL: https://r8-review.googlesource.com/c/r8/+/33781
   
    Bug: 122450679
    Change-Id: If919d506afa783859556cf9935a201759bd1c14d

M       src/main/java/com/android/tools/r8/Version.java
M       src/main/java/com/android/tools/r8/graph/DexDebugEventBuilder.java
M       src/main/java/com/android/tools/r8/ir/conversion/DexBuilder.java
M       src/main/java/com/android/tools/r8/ir/conversion/JarSourceCode.java
M       src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
A       src/test/java/com/android/tools/r8/debug/BreakOnIfTest.java
A       src/test/java/com/android/tools/r8/debug/BreakOnIfTestRunner.java

https://r8-review.googlesource.com/33782

The workaround for this issue can be used by locally updating the top-level build.gradle configuration for your project:

buildscript {
    repositories {
        maven {
            url 'http://storage.googleapis.com/r8-releases/raw' // ADD THIS.
        }
        maven {
            url 'https://kotlin.bintray.com/kotlinx/' // ADD THIS.
        }
    }
    dependencies {
        classpath 'com.android.tools:r8:1.3.55'  // ADD THIS. Must be before the Gradle Plugin for Android.
        classpath 'com.android.tools.build:gradle:3.3'
     }
}

Once the next point release of AGP takes place (i.e., once gradle is at 3.3.2, as this fix did not make it for 3.3.1) these changes can be removed again.

Works :
if (onlyOneCondition())

Doesn't work:
if (firstCondition() && secondCondition())


I think also
boolean rt = firstCondition() && secondCondition();
doesn't work.

AndroidStudio 3.3.2

Thank you!