Fixed

Feature Request

Status Update

No update yet.

Description

si...@google.com

created issue #1

Jan 7, 2019 10:35PM

Currently developer can set minLines on Android.

Comments

si...@google.com <si...@google.com> #2Feb 4, 2020 02:41AM

Some new information? This issue is already over a year old, it was just shifted, and the new ticket here seems to be ignored. This should have a higher Priority then P3.

I feel like this is a serious issue that should get more attention. When working with RecyclerViews you had the possibility of setting up if a ViewHolder is able the be recycled.

All the solutions to circumvent this problem here are either hacks in regards to how the Keyboard is opened, or you ditch LazyColumn completely and use a Column, which is not a solution for complex layouts.

si...@google.com <si...@google.com> Aug 21, 2020 07:14PM

Reassigned to ha...@google.com.

p....@arammeem.com <p....@arammeem.com> #3Sep 3, 2021 08:27AM

1.2.0-beta02 it still remains

si...@google.com <si...@google.com> Nov 17, 2021 02:16AM

Reassigned to an...@google.com.

ho...@fulfillmenttools.com <ho...@fulfillmenttools.com> #4Feb 10, 2022 09:26AM

and cause the other focusable element could not access touch

[Deleted User] <[Deleted User]> #5Feb 17, 2022 09:43PM

We should have some API to pin an item to indicate that we want to keep it around and not dispose it.

Please don't make this API internal, make it public for everyone to use and also allow this API to be used with any kind of items inside of LazyLayout's (not only focusable items). I have described why I need it in this issue https://issuetracker.google.com/issues/236279213 Thanks.

cm...@googlemail.com <cm...@googlemail.com> #6Feb 23, 2022 03:26PM

Related in spirit:

STOP MAKING ALL USEFUL APIS INTERNAL

my...@gmail.com <my...@gmail.com> #7Apr 28, 2022 03:39PM

This issue is also relevant to text selection, where selection should be able to cross items of a LazyColumn (wrapped in a SelectionContainer). Items with a selection inside should not be removed from the composition, but the handles disappear when the first element containing any selected text is scrolled out of view. See attached video for illustration.

Although, sometimes it is desired behaviour. Maybe add a flag whether to persist the node?

si...@google.com <si...@google.com> #8May 4, 2022 03:13PM

Any update?

cf...@gmail.com <cf...@gmail.com> #9Jun 12, 2022 08:35PM

any update?

Message last modified on Jun 12, 2022 08:44PM

de...@edistera.com <de...@edistera.com> #10Jun 13, 2022 07:36AM

No update?

Message last modified on Jun 13, 2022 07:37AM

be...@gmail.com <be...@gmail.com> #11Jun 13, 2022 11:07AM

Any update?

al...@gmail.com <al...@gmail.com> #12Jun 13, 2022 07:57PM

Any update?

ub...@gmail.com <ub...@gmail.com> #13Jun 16, 2022 12:08AM

Any update?

Message last modified on Jun 16, 2022 12:10AM

[Deleted User] <[Deleted User]> #14Jun 23, 2022 03:39PM

Any update?

be...@gmail.com <be...@gmail.com> #15Jun 23, 2022 05:34PM

Project: platform/frameworks/support
Branch: androidx-main

commit 36abe1718e16025253df6f22cd786fc034447be5
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed Nov 16 19:27:22 2022

Add items pinning functionality to the lazy lists

Lazy lists now provide an instance of PinnableContainer via LocalPinnableContainer for each item. It allows to pin the current item from inside the content of the item. Pinning means we will continue composing, measuring and placing this item even when it is scrolled away from the view. Note that the placed position is not guaranteed to be the real one as we do not compose the items in between the pinned one and the first/last visible one.
This interface was added to the ui module as conceptually PinnableContainer is decoupled from lazy layouts from the foundation module. Other layouts using SubcomposeLayout could have some similar functionality and may want to support pinning. And it will allow for modifiers from ui to use this interface to pin their content.

Test: LazyListPinnableContentTest
Fixes: 259274257
Fixes: 195049010
Relnote: Introduced PinnableContainer api propagated by lazy lists via a composition local which allows to pin current item. This means such item will not be disposed when it is scrolled away from the view. For example, Modifier.focusable() will pin the current focused item via this mechanism.
Change-Id: Ib8881191a529c9d9dc5e886570650b1987763207

M compose/foundation/foundation/api/current.ignore
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.ignore
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/FocusableTest.kt
D compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/layout/PinnableParentTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/list/LazyListBeyondBoundsItemCountTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/list/LazyListPinnableContainerTest.kt
D compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/list/LazyListPinningTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyList.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyListItemProvider.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyListMeasure.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyListPinnableContainerProvider.kt
D compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyListPinningModifier.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyListState.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGridItemProvider.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/layout/LazyLayoutItemProvider.kt
D compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/layout/PinnableParent.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/staggeredgrid/LazyStaggeredGridItemProvider.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/PinnableContainer.kt
M tv/tv-foundation/api/current.txt
M tv/tv-foundation/api/public_plus_experimental_current.txt
M tv/tv-foundation/api/restricted_current.txt
A tv/tv-foundation/src/androidTest/java/androidx/tv/foundation/lazy/list/LazyListPinnableContainerTest.kt
D tv/tv-foundation/src/main/java/androidx/tv/foundation/lazy/LazyListPinningModifier.kt
M tv/tv-foundation/src/main/java/androidx/tv/foundation/lazy/grid/LazyGridItemProvider.kt
M tv/tv-foundation/src/main/java/androidx/tv/foundation/lazy/list/LazyBeyondBoundsModifier.kt
M tv/tv-foundation/src/main/java/androidx/tv/foundation/lazy/list/LazyList.kt
M tv/tv-foundation/src/main/java/androidx/tv/foundation/lazy/list/LazyListBeyondBoundsInfo.kt
M tv/tv-foundation/src/main/java/androidx/tv/foundation/lazy/list/LazyListItemProvider.kt
M tv/tv-foundation/src/main/java/androidx/tv/foundation/lazy/list/LazyListMeasure.kt
A tv/tv-foundation/src/main/java/androidx/tv/foundation/lazy/list/LazyListPinnableContainerProvider.kt
M tv/tv-foundation/src/main/java/androidx/tv/foundation/lazy/list/LazyListState.kt

https://android-review.googlesource.com/2304138

ma...@ext.carrefour.com <ma...@ext.carrefour.com> #16Jun 23, 2022 08:28PM

Will there be a way to know when the Composable position is known to be accurate, and that it's visible? Would be helpful for, say a video player, or anything you could think about that needs to do things only if visible.

so...@google.com <so...@google.com> Jul 19, 2022 01:59PM

Reassigned to so...@google.com.

si...@google.com <si...@google.com> #17Jul 25, 2022 05:16PM

LazyListState.layoutInfo contains the list of items being visible. You can use derivedStateOf in order to calculate that the item is fully visible and use that to switch isPlaying state

si...@google.com <si...@google.com> Aug 3, 2022 05:49PM

Reassigned to so...@google.com.

le...@google.com <le...@google.com> Sep 15, 2022 09:48AM

Reassigned to an...@google.com.

be...@gmail.com <be...@gmail.com> #18Sep 15, 2022 10:58AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.4.0-alpha04
androidx.compose.ui:ui:1.4.0-alpha04

ap...@google.com <ap...@google.com> #19Oct 4, 2022 11:31AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-foundation:1.0.0-alpha04

si...@google.com <si...@google.com> #20Oct 10, 2022 08:36PM

Reassigned to so...@google.com.

Assigned for the open CL at aosp/2237754

da...@gmail.com <da...@gmail.com> #21Oct 11, 2022 05:41PM

I see in the CL minLines was added, but it is currently behind an internal modifier.

Are there plans to make this modifier public so that we can use it from our own apps? Or are there intentions to expose the minLines behavior via another mechanism that internally uses this Modifier?

so...@google.com <so...@google.com> Oct 11, 2022 05:49PM

Accepted by so...@google.com.

ap...@google.com <ap...@google.com> #22Oct 13, 2022 07:34AM

Project: platform/frameworks/support
Branch: androidx-main

commit e74bce3b62ac62a8115f7707bf5b58adc8d2c340
Author: Andrei Ancuta <andreiancuta@google.com>
Date: Thu Sep 29 21:30:43 2022

Add minLines parameter to BasicText and BasicTextField

Bug: 122476634
Test: ./gradlew compose:foundation:foundation:test
Relnote: "Added minLines parameter to the BasicText and BasicTextField.
It allows to set the minimum height of these composables in terms of
number of lines"

Change-Id: I2429479960eef317f467fa054b979c12fd73689d

M compose/compiler/compiler-hosted/integration-tests/build.gradle
M compose/compiler/compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/TargetAnnotationsTransformTests.kt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/BasicTextMinMaxLinesDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeInputFieldMinMaxLines.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicText.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/HeightInLinesModifier.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextDelegate.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextControllerTest.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextDelegateTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Text.kt
M wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/Text.kt

https://android-review.googlesource.com/2237754

na...@google.com <na...@google.com> #23Oct 24, 2022 01:36PM

The following release(s) address this bug:

androidx.compose.foundation:foundation:1.4.0-alpha01

al...@gmail.com <al...@gmail.com> #24Oct 24, 2022 04:49PM

Are you certain this landed in 1.4.0-alpha01? I was not able to find this API in the new release. Android Studio doesn't show me a minLines: Int argument when I update to 1.4.0-alpha01.

so...@google.com <so...@google.com> #25Oct 24, 2022 05:06PM

Alex is right, the API change haven't landed in 1.4.0-alpha. We cut the build just before the API change in BasicText(Field) landed so the build only contains the implementation.

so...@google.com <so...@google.com> Nov 9, 2022 06:49PM

Marked as fixed.

be...@yescapa.com <be...@yescapa.com> #26Nov 10, 2022 10:45AM

minLines is not used in the basicText implementation so it's not working :

line 212 of BasicText :

 val controller = remember {
        TextController(
            TextState(
                TextDelegate(
                    text = text,
                    style = style,
                    density = density,
                    softWrap = softWrap,
                    fontFamilyResolver = fontFamilyResolver,
                    overflow = overflow,
                    maxLines = maxLines,
                    placeholders = placeholders
                ),
                selectableId
            )
        )
    }

minLines = minLines is missing in the TextDelegate constructor

Edit: I'm on 1.4.0-alpha02

Message last modified on Nov 10, 2022 10:46AM

so...@google.com <so...@google.com> #27Nov 10, 2022 11:33AM

Accepted by so...@google.com.

Good catch! We missed that during code review, on it.

Please note that String override should be fine, it wasn't propagated to AnnotatedString override only.

Message last modified on Nov 10, 2022 02:16PM

ap...@google.com <ap...@google.com> #28Nov 12, 2022 03:07AM

Project: platform/frameworks/support
Branch: androidx-main

commit 8068bf450819393cf10b8f37d73533cf3b8e6cec
Author: Anastasia Soboleva <soboleva@google.com>
Date: Thu Nov 10 16:34:40 2022

Pass minLines to AnnotatedString override of BasicText

Relnote: "Fix `minLines` of the AnnotatedString override of Text and
BasicText - before this change applying minLines did nothing"
Test: added more tests to cover minLines in BasicText and
BasicTextField
Test: updated HeightInLinesModifierTest some tests of which were false
negatives
Bug: 122476634

Change-Id: I2a7f20069ac2f0da053940f8eadb72656bbb592c

A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/BasicTextMinLinesTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/HeightInLinesModifierTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldMinMaxLinesTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicText.kt

https://android-review.googlesource.com/2297540

si...@google.com <si...@google.com> Nov 14, 2022 05:35PM

Assigned to si...@google.com.

ap...@google.com <ap...@google.com> #29Nov 14, 2022 09:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1ea832da88dda876c4b4d283012f7231eadfcf83
Author: Aurimas Liutikas <aurimas@google.com>
Date: Mon Nov 14 16:48:33 2022

Revert "Pass minLines to AnnotatedString override of BasicText"

This reverts commit 8068bf450819393cf10b8f37d73533cf3b8e6cec.

Reason for revert: Added tests 100% fails on API 33

https://android-build.googleplex.com/builds/tests/view?invocationId=I89500010108059894&testResultId=TR24128369833260040

Bug: 122476634

Change-Id: Ibba3f2354b4ff7c6e5e47f3e8d1ccb1f11da4ea9

D compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/BasicTextMinLinesTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/HeightInLinesModifierTest.kt
D compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldMinMaxLinesTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicText.kt

https://android-review.googlesource.com/2301821

si...@google.com <si...@google.com> #30Feb 2, 2023 08:19PM

Marked as fixed.

The reverted commit was rever-reverted via b/263371866 and https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2367789 by Halil.

This ticket should be fixed. Looks like there is something about the Density's that are being used on device that need some attention. They do not set the font scale therefore they are impacted by the font scale on the device.

si...@google.com <si...@google.com> #31Feb 2, 2023 08:26PM

Based onthe comment on the other ticket

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.4.0-alpha04

Issue 122476634

Description

Issue summary

Comments

si...@google.com <si...@google.com> #2Feb 4, 2020 02:41AM

si...@google.com <si...@google.com> Aug 21, 2020 07:14PM

p....@arammeem.com <p....@arammeem.com> #3Sep 3, 2021 08:27AM

si...@google.com <si...@google.com> Nov 17, 2021 02:16AM

ho...@fulfillmenttools.com <ho...@fulfillmenttools.com> #4Feb 10, 2022 09:26AM

[Deleted User] <[Deleted User]> #5Feb 17, 2022 09:43PM

cm...@googlemail.com <cm...@googlemail.com> #6Feb 23, 2022 03:26PM

STOP MAKING ALL USEFUL APIS INTERNAL

my...@gmail.com <my...@gmail.com> #7Apr 28, 2022 03:39PM

si...@google.com <si...@google.com> #8May 4, 2022 03:13PM

cf...@gmail.com <cf...@gmail.com> #9Jun 12, 2022 08:35PM

de...@edistera.com <de...@edistera.com> #10Jun 13, 2022 07:36AM

be...@gmail.com <be...@gmail.com> #11Jun 13, 2022 11:07AM

al...@gmail.com <al...@gmail.com> #12Jun 13, 2022 07:57PM

ub...@gmail.com <ub...@gmail.com> #13Jun 16, 2022 12:08AM

[Deleted User] <[Deleted User]> #14Jun 23, 2022 03:39PM

be...@gmail.com <be...@gmail.com> #15Jun 23, 2022 05:34PM

ma...@ext.carrefour.com <ma...@ext.carrefour.com> #16Jun 23, 2022 08:28PM

so...@google.com <so...@google.com> Jul 19, 2022 01:59PM

si...@google.com <si...@google.com> #17Jul 25, 2022 05:16PM

si...@google.com <si...@google.com> Aug 3, 2022 05:49PM

le...@google.com <le...@google.com> Sep 15, 2022 09:48AM

be...@gmail.com <be...@gmail.com> #18Sep 15, 2022 10:58AM

ap...@google.com <ap...@google.com> #19Oct 4, 2022 11:31AM

si...@google.com <si...@google.com> #20Oct 10, 2022 08:36PM

da...@gmail.com <da...@gmail.com> #21Oct 11, 2022 05:41PM

so...@google.com <so...@google.com> Oct 11, 2022 05:49PM

ap...@google.com <ap...@google.com> #22Oct 13, 2022 07:34AM

na...@google.com <na...@google.com> #23Oct 24, 2022 01:36PM

al...@gmail.com <al...@gmail.com> #24Oct 24, 2022 04:49PM

so...@google.com <so...@google.com> #25Oct 24, 2022 05:06PM

so...@google.com <so...@google.com> Nov 9, 2022 06:49PM

be...@yescapa.com <be...@yescapa.com> #26Nov 10, 2022 10:45AM

so...@google.com <so...@google.com> #27Nov 10, 2022 11:33AM

ap...@google.com <ap...@google.com> #28Nov 12, 2022 03:07AM

si...@google.com <si...@google.com> Nov 14, 2022 05:35PM

ap...@google.com <ap...@google.com> #29Nov 14, 2022 09:56PM

si...@google.com <si...@google.com> #30Feb 2, 2023 08:19PM

si...@google.com <si...@google.com> #31Feb 2, 2023 08:26PM

Add comment

Issue metadata