Status Update
Comments
ma...@google.com <ma...@google.com>
an...@google.com <an...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 53d7e9505dce7026e7c92059d42e5de784739106
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 16:26:25 2021
Avoid nullable boolean in constraint trackers
Now instead of returning null, trackers work pessimistically,
e.g. BatteryChargingTracker says that battery isn't charging.
It is done in preparation for Kotlin migration, where
this code smell is more apparent.
bug: 209145335
Test: *TrackerTest were updated
Change-Id: Ie1dcbe8961d925784d5633a297307993f3b8a43b
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/ConstraintTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.java
https://android-review.googlesource.com/1911432
Branch: androidx-main
commit 53d7e9505dce7026e7c92059d42e5de784739106
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 16:26:25 2021
Avoid nullable boolean in constraint trackers
Now instead of returning null, trackers work pessimistically,
e.g. BatteryChargingTracker says that battery isn't charging.
It is done in preparation for Kotlin migration, where
this code smell is more apparent.
bug: 209145335
Test: *TrackerTest were updated
Change-Id: Ie1dcbe8961d925784d5633a297307993f3b8a43b
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/ConstraintTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.java
ke...@gmail.com <ke...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 37b6a3fbb83456e319412c81f5039ffede5571c1
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:33:19 2021
Bump room 2.4.0-rc01
bug: 209145335
Test: refactoring
Change-Id: I29efb1b5a2e49ceddae999ed244803889723b080
M work/work-runtime/build.gradle
M work/work-runtime-ktx/build.gradle
M work/work-inspection/build.gradle
M work/work-gcm/build.gradle
M work/work-multiprocess/build.gradle
M work/work-benchmark/build.gradle
M work/work-testing/build.gradle
M work/integration-tests/testapp/build.gradle
https://android-review.googlesource.com/1910055
Branch: androidx-main
commit 37b6a3fbb83456e319412c81f5039ffede5571c1
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:33:19 2021
Bump room 2.4.0-rc01
bug: 209145335
Test: refactoring
Change-Id: I29efb1b5a2e49ceddae999ed244803889723b080
M work/work-runtime/build.gradle
M work/work-runtime-ktx/build.gradle
M work/work-inspection/build.gradle
M work/work-gcm/build.gradle
M work/work-multiprocess/build.gradle
M work/work-benchmark/build.gradle
M work/work-testing/build.gradle
M work/integration-tests/testapp/build.gradle
Description
Description: I think there already was an API for that but I can't find anything about it. I think it was used for a case when there is a TextField inside of the LazyList which is focused with the keyboard opened and when it goes outside of the visible area it gets disposed so the keyboard closes automatically. Maybe it's just not public? If it already exists then could you give me a link or at least what it's called?
Use Case: I have a HorizontalPager with 3 pages each of them has LazyColumn with complex items. Every time I scroll from one page to another there is a visible lag which delays the scrolling because it takes some time for a page with the LazyList to get composed again. I would like to tell the HorizontalPager (which is a LazyLayouts) to not dispose those 3 pages so that they are not recreated on every page change.