Fixed
Status Update
Comments
rm...@google.com <rm...@google.com> #2
Android Studio 3.5 Canary 3
Build #AI-183.5153.38.35.5256920, built on January 24, 2019
JRE: 1.8.0_152-release-1248-b22 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.13.6
Issue can be replicated even on 3.4 Can3. Thank you for reporting the issue.
Build #AI-183.5153.38.35.5256920, built on January 24, 2019
JRE: 1.8.0_152-release-1248-b22 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.13.6
Issue can be replicated even on 3.4 Can3. Thank you for reporting the issue.
ju...@google.com <ju...@google.com>
ju...@google.com <ju...@google.com>
du...@google.com <du...@google.com> #3
#2
3.4 Canary 3? Do you mean 3.5 Canary 3? This feature was not enabled for 3.4.
Also, why do you need the Deployment Target Dialog to display? Is there a particular need for it instead of the new combo box?
3.4 Canary 3? Do you mean 3.5 Canary 3? This feature was not enabled for 3.4.
Also, why do you need the Deployment Target Dialog to display? Is there a particular need for it instead of the new combo box?
mo...@gmail.com <mo...@gmail.com> #4
I didn't write 3.4, your colleague at Google did (ju...@google.com)
I liked the dialog because it provided more information about the devices and had the checkbox for always running the selected device. Also, since it's a dialog and pops up, it was keyboard friendly because you could use shortcuts to run, then the dialog pops up and you can stay on the keyboard and use down arrows to select the device and the OK button. It's harder to do that keyboard shortcut sequence if you have to navigate to the toolbar (via keyboard) to select the drop-down combo box.
I liked the dialog because it provided more information about the devices and had the checkbox for always running the selected device. Also, since it's a dialog and pops up, it was keyboard friendly because you could use shortcuts to run, then the dialog pops up and you can stay on the keyboard and use down arrows to select the device and the OK button. It's harder to do that keyboard shortcut sequence if you have to navigate to the toolbar (via keyboard) to select the drop-down combo box.
mo...@gmail.com <mo...@gmail.com> #5
Oh ya, the dialog also has the option of creating a new device ... now I have to do it as a different work flow.
du...@google.com <du...@google.com> #6
Sorry, that question about 3.4 was address to #2. But yes, the question about needing the dialog was addressed to you, and thank you for replying!
As for your concerns, there's no need for the checkbox any longer, since the selected device in the drop down is going to be the device that you deploy to, just like the behavior of the checkbox. However, the keyboard shortcuts part for selecting the device can definitely be better. We'll see what we can do to improve that use case.
As for creating the new device, that was just a shortcut to the AVD manager. I'm guessing it isn't used frequently (unless there's a use case for creating and deleting virtual devices constantly that I'm not aware of?). Everything about setting up a virtual device should go through the AVD manager.
As for your concerns, there's no need for the checkbox any longer, since the selected device in the drop down is going to be the device that you deploy to, just like the behavior of the checkbox. However, the keyboard shortcuts part for selecting the device can definitely be better. We'll see what we can do to improve that use case.
As for creating the new device, that was just a shortcut to the AVD manager. I'm guessing it isn't used frequently (unless there's a use case for creating and deleting virtual devices constantly that I'm not aware of?). Everything about setting up a virtual device should go through the AVD manager.
ta...@gmail.com <ta...@gmail.com> #7
Just because I have your attention, can you rename AVD Manager to something more obvious and searchable.
In the action dialog, when I type Android or Device or emulator, nothing comes up. It is always a struggle to remember AVD. Now that the shortcut is gone with the dialog, maybe it should be more obvious.
What do you think?
In the action dialog, when I type Android or Device or emulator, nothing comes up. It is always a struggle to remember AVD. Now that the shortcut is gone with the dialog, maybe it should be more obvious.
What do you think?
mo...@gmail.com <mo...@gmail.com> #8
I agree with everything you've said du...@google.com. It's not really a necessary dialog if the redesign covers the normal use cases. Better shortcut keys would be nice. I guess the absence of the dialog confused me since it consolidated a number of avd features and now those features are still available but available in a different way or ways. So I'm good with the design and thanks for the explanation.
du...@google.com <du...@google.com> #9
#7 That's a good suggestion, although I'm guessing we're not going to change the name. I quickly looked over the code, and you'll probably want to file a new bug along with the following notes (my best guess) for whomever ends up needing to implement this feature:
"""
In RunAndroidAvdManagerAction.java, add the following to the constructor(s) (the parameter-less constructor should also be changed to use the default constructor to avoid code duplication):
SearchableOptionsRegistrar.getInstance().addOption("device", "ActionManager", "AVD Manager", "Android.RunAndroidAvdManager", getName());
SearchableOptionsRegistrar.getInstance().addOption("emulator", "ActionManager", "AVD Manager", "Android.RunAndroidAvdManager", getName());
SearchableOptionsRegistrar.getInstance().addOption("Android", "ActionManager", "AVD Manager", "Android.RunAndroidAvdManager", getName());
//...
"""
#8 Thank you again for raising your concerns, and they're all very valid!
"""
In RunAndroidAvdManagerAction.java, add the following to the constructor(s) (the parameter-less constructor should also be changed to use the default constructor to avoid code duplication):
SearchableOptionsRegistrar.getInstance().addOption("device", "ActionManager", "AVD Manager", "Android.RunAndroidAvdManager", getName());
SearchableOptionsRegistrar.getInstance().addOption("emulator", "ActionManager", "AVD Manager", "Android.RunAndroidAvdManager", getName());
SearchableOptionsRegistrar.getInstance().addOption("Android", "ActionManager", "AVD Manager", "Android.RunAndroidAvdManager", getName());
//...
"""
#8 Thank you again for raising your concerns, and they're all very valid!
ta...@gmail.com <ta...@gmail.com> #10
ju...@google.com <ju...@google.com> #11
I chatted with my teammate and decided to undo what I did for this issue. Studio will go back to using the new drop down list regardless of what the Deployment Target Options drop down says in the Run/Debug Configurations dialog. I'm going to redouble my efforts to remove that drop down because it's redundant with the new one.
By all means, if the new drop down is not an acceptable replacement for the old Select Deployment Target dialog please file issues. We all want the new way to be much better.
By all means, if the new drop down is not an acceptable replacement for the old Select Deployment Target dialog please file issues. We all want the new way to be much better.
mo...@gmail.com <mo...@gmail.com> #12
In Canary 3.5.0-alpha05, if I select "Open Select Deployment Target Dialog" in the Deployment Target Options dialog Target dropdown list in the Run/Debug Configuration dialog, it works as expected and the dialog will pop up. If you want to just use the new drop down, that's fine but as long as the option is offered in the dialog's Target dropdown list then you should keep it working. Remove the list, but don't offer a list that has non-working selections.
ju...@google.com <ju...@google.com> #13
It's an unfortunate situation. I'm sitting on a commit that actually removes the redundant drop down but it won't be able to make Canary 7. With the behavior I introduced that drop down works as expected but Apply Changes is broken.
I figure it's better for the redundant drop down to be broken rather than Apply Changes. I know that sucks and I'm sorry. I'm working to get my commit in for Canary 8.
I figure it's better for the redundant drop down to be broken rather than Apply Changes. I know that sucks and I'm sorry. I'm working to get my commit in for Canary 8.
mo...@gmail.com <mo...@gmail.com> #14
That sounds very reasonable, and thanks for being so helpful.
af...@gmail.com <af...@gmail.com> #15
Can't wait for canary 8 as I still see this issue on canary 7 and all I get is this, no matter what I try to do:
Error running 'app': No target device found
Error running 'app': No target device found
Description
1. Open Run/Debug Configuration dialog from the toolbar drop-down combo box.
2. Deployment Target Options "Target" drop-down combo box will display "Use the device/snapshot drop down" choice.
3. change the drop-down selection to anything else (e.g. USB or Open Select Deployment Target Dialog)
4. Click OK (or Apply and then OK) to save changes and close the dialog.
5. repeat step 1 to reopen the dialog.
6. Deployment Target Options "Target" drop-down combo box will still display "Use the device/snapshot drop down" choice and has not remembered the change to any other selection.
This is very very annoying because I can no longer get the Deployment Target Dialog to display!