IssueTracker

When Android Studio is newer than the Android Gradle plugin declared as a buildscript dependency, it shows a dialog "Android Gradle Plugin Update Required". Pressing update will change the AGP version to match the Studio version but can also add an extra google() repository to the buildscript even though it is already there.

This happens if you are using the new Gradle feature "repository filtering" to match dependencies to repositories, then the update button will add a 2nd google() repository to the buildscript repositories block. It should not do this.

Reference for this Gradle feature: https://docs.gradle.org/5.1/userguide/declaring_repositories.html#sec::matching_repositories_to_dependencies

Steps to reproduce:
Create new empty project in Android Studio 3.5 Canary 3
Edit root build.gradle and replace buildscript > repositories > "google()" with:
        google().with {
            content {
                includeGroupByRegex 'androidx?\\..*'
                includeGroupByRegex 'com\\.android\\..*'
            }
        }

Decrement the version of com.android.tools.build:gradle:3.5.0-alpha03 to 3.5.0-alpha02
Do a gradle sync
"Android Gradle Plugin Update Required" dialog appears; press Update
Note that AGP version is changed to 3.5.0-alpha03, as expected
Note that an extra "google()" has been added to the buildscript > repositories block. This should not happen, as the google() repository was already there.

Being able to use this repository filtering is nice because it prevents accidental usage of untrusted maven artifacts using Google's coordinates published by 3rd parties to other repositories.

As a side note, there is a feature request to support the nicer syntax [not having to call ".with" on google()] shown on that Gradle documentation page:
    jcenter {
        content {
            // this repository contains everything BUT artifacts with group starting with "my.company"
            excludeGroupByRegex "my\\.company.*"
        }
    }
Ideally the change to fix this issue would support that syntax if it is added to Gradle. Issue link: https://github.com/gradle/gradle/issues/8280


Build: $VERSION, AI-183.5153.38.35.5256920, 201901241813, AI-183.5153.38.35.5256920, JRE 1.8.0_202-release-b1455x64 JetBrains s.r.o, OS Linux(amd64) v4.18.0-13-generic, screens 2560x1440, 1920x1080
Android Gradle Plugin: 3.5.0-alpha03
Gradle: 5.1.1
NDK: from local.properties: (not specified); latest from SDK: (not found); LLDB: pinned revision 3.1 not found; latest from SDK: (package not found); CMake: from local.properties: (not specified); latest from SDK: (not found); from PATH: (not found);