AppCompat is using reflection which is limited by Android 9? [123699881]

Assigned

Bug

[AOSP] assigned

adexe s nau

Status Update

No update yet.

Description

te...@wiz.world

created issue #1

Feb 1, 2019 06:08AM

Artifact used: com.android.support:appcompat-v7:28.0.0
Version used: 28.0.0
Devices/Android versions reproduced on: All Android 9 devices

==========

In Android 9 Google announced [new limitations on accessing non-SDK interface methods by using reflection](

https://developer.android.com/about/versions/pie/restrictions-non-sdk-interfaces).

If your project uses one, you will get the dialog `Detected problems with API compatibility (visit

g.co/dev/appcompat for more info)`. Although as far as I know this dialog will not appear in a release build, it looks like in the future developers would have completely no way to use reflection to do what they want.

By using the `StrictMode` class, I was able to log the reflection methods being used.

However... It turns out one of them is the AppCompat support library?!

```
2019-02-01 13:45:50.619 14892-14892/com.xxx.xxx.xxx W/com.xxx.xxx.xxx: Accessing hidden method Landroid/view/ViewGroup;->makeOptionalFitsSystemWindows()V (light greylist, reflection)
2019-02-01 13:45:50.620 14892-14892/

com.tao.wiz.dev D/StrictMode: StrictMode policy violation: android.os.strictmode.NonSdkApiUsedViolation: Landroid/view/ViewGroup;->makeOptionalFitsSystemWindows()V
at android.os.StrictMode.lambda$static$1(StrictMode.java:428)
at android.os.-$$Lambda$StrictMode$lu9ekkHJ2HMz0jd3F8K8MnhenxQ.accept(Unknown Source:2)
at java.lang.Class.getDeclaredMethodInternal(Native Method)
at java.lang.Class.getPublicMethodRecursive(Class.java:2075)
at java.lang.Class.getMethod(Class.java:2063)
at java.lang.Class.getMethod(Class.java:1690)
at android.support.v7.widget.ViewUtils.makeOptionalFitsSystemWindows(ViewUtils.java:84)
at android.support.v7.app.AppCompatDelegateImpl.createSubDecor(AppCompatDelegateImpl.java:685)
at android.support.v7.app.AppCompatDelegateImpl.ensureSubDecor(AppCompatDelegateImpl.java:518)
at android.support.v7.app.AppCompatDelegateImpl.setContentView(AppCompatDelegateImpl.java:466)
at android.support.v7.app.AppCompatActivity.setContentView(AppCompatActivity.java:140)
```

May I assume this is something to be fixed by Google?

Comments

ad...@google.com <ad...@google.com> Feb 1, 2019 06:59AM

Assigned to ad...@google.com.

ad...@google.com <ad...@google.com> #2Feb 1, 2019 11:34AM

Reassigned to ki...@google.com.

Our app got the same crash too.

OS Version: iOS 13.3.1 (17D50)
Report Version: 104

Exception Type: EXC_BAD_ACCESS (SIGBUS)
Exception Codes: BUS_NOOP at 0x0000000141a80020
Crashed Thread: 12

Application Specific Information:
CXX: calling C++ destructors for class %s >
Attempted to dereference garbage pointer 0x141a80020.

Thread 12 Crashed:
0   libobjc.A.dylib                 0x347ce7140         objc_release
1   AppMap                          0x1015c8584         -[GMSPointOfInterest .cxx_destruct]
2   libobjc.A.dylib                 0x347ccc0e4         object_cxxDestructFromClass
3   libobjc.A.dylib                 0x347cded78         objc_destructInstance
4   libobjc.A.dylib                 0x347ce5dac         _objc_rootDealloc
5   CoreFoundation                  0x347e5b28c         __RELEASE_OBJECTS_IN_THE_ARRAY__
6   CoreFoundation                  0x347de8c78         -[__NSArrayM dealloc]
7   AppMap                          0x1015d5e50         -[GMSVectorTile .cxx_destruct]
8   libobjc.A.dylib                 0x347ccc0e4         object_cxxDestructFromClass
9   libobjc.A.dylib                 0x347cded78         objc_destructInstance
10  libobjc.A.dylib                 0x347ce5dac         _objc_rootDealloc
11  AppMap                          0x1016398cc         -[GMSTileRequest .cxx_destruct]
12  libobjc.A.dylib                 0x347ccc0e4         object_cxxDestructFromClass
13  libobjc.A.dylib                 0x347cded78         objc_destructInstance
14  libobjc.A.dylib                 0x347ce5dac         _objc_rootDealloc
15  CoreFoundation                  0x347e5b28c         __RELEASE_OBJECTS_IN_THE_ARRAY__
16  CoreFoundation                  0x347de8c78         -[__NSArrayM dealloc]
17  AppMap                          0x10162b894         -[GMSDASHBatchedTileRequest .cxx_destruct]
18  libobjc.A.dylib                 0x347ccc0e4         object_cxxDestructFromClass
19  libobjc.A.dylib                 0x347cded78         objc_destructInstance
20  libobjc.A.dylib                 0x347ce5dac         _objc_rootDealloc
21  libsystem_blocks.dylib          0x318dfaa44         _Block_release
22  libdispatch.dylib               0x326509180         _dispatch_client_callout
23  libdispatch.dylib               0x3264b1a38         _dispatch_continuation_pop$VARIANT$mp
24  libdispatch.dylib               0x3264b118c         _dispatch_async_redirect_invoke
25  libdispatch.dylib               0x3264bdfa0         _dispatch_root_queue_drain
26  libdispatch.dylib               0x3264be76c         _dispatch_worker_thread2
27  libsystem_pthread.dylib         0x31f8a1b44         _pthread_wqthread

Thread 0
0   libsystem_kernel.dylib          0x348044634         mach_msg_trap
1   libsystem_kernel.dylib          0x348043a9c         mach_msg
2   CoreFoundation                  0x347e8f284         __CFRunLoopServiceMachPort
3   CoreFoundation                  0x347e8a3a4         __CFRunLoopRun
4   CoreFoundation                  0x347e89ad8         CFRunLoopRunSpecific
5   GraphicsServices                0x33045a324         GSEventRunModal
6   UIKitCore                       0x3167ed638         UIApplicationMain
7   App                             0x200ba5f64         main (ActionView.swift:16)
8   libdyld.dylib                   0x34808735c         start

Thread 1 name: com.apple.uikit.eventfetch-thread
0   libsystem_kernel.dylib          0x348044634         mach_msg_trap
1   libsystem_kernel.dylib          0x348043a9c         mach_msg
2   CoreFoundation                  0x347e8f284         __CFRunLoopServiceMachPort
3   CoreFoundation                  0x347e8a3a4         __CFRunLoopRun
4   CoreFoundation                  0x347e89ad8         CFRunLoopRunSpecific
5   Foundation                      0x3172e4780         -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
6   Foundation                      0x3172e4660         -[NSRunLoop(NSRunLoop) runUntilDate:]
7   UIKitCore                       0x316885e7c         -[UIEventFetcher threadMain]
8   Foundation                      0x317415098         __NSThread__start__
9   libsystem_pthread.dylib         0x31f8a0d88         _pthread_start

Thread 2
0   libsystem_kernel.dylib          0x348066240         __semwait_signal
1   libsystem_c.dylib               0x32471565c         nanosleep
2   libsystem_c.dylib               0x32471545c         sleep
3   Sentry                          0x100f6f440         monitorCachedData (SentryCrashCachedData.c:151)
4   libsystem_pthread.dylib         0x31f8a0d88         _pthread_start

Thread 3 name: SentryCrash Exception Handler (Secondary)
0   libsystem_kernel.dylib          0x348044634         mach_msg_trap
1   libsystem_kernel.dylib          0x348043a9c         mach_msg
2   Sentry                          0x100f69310         handleExceptions (SentryCrashMonitor_MachException.c:281)
3   libsystem_pthread.dylib         0x31f8a0d88         _pthread_start

Thread 5 name: com.apple.NSURLConnectionLoader
0   libsystem_kernel.dylib          0x348044634         mach_msg_trap
1   libsystem_kernel.dylib          0x348043a9c         mach_msg
2   CoreFoundation                  0x347e8f284         __CFRunLoopServiceMachPort
3   CoreFoundation                  0x347e8a3a4         __CFRunLoopRun
4   CoreFoundation                  0x347e89ad8         CFRunLoopRunSpecific
5   CFNetwork                       0x32984e4e8         <redacted>
6   Foundation                      0x317415098         __NSThread__start__
7   libsystem_pthread.dylib         0x31f8a0d88         _pthread_start

Thread 6 name: AVAudioSession Notify Thread
0   libsystem_kernel.dylib          0x348044634         mach_msg_trap
1   libsystem_kernel.dylib          0x348043a9c         mach_msg
2   CoreFoundation                  0x347e8f284         __CFRunLoopServiceMachPort
3   CoreFoundation                  0x347e8a3a4         __CFRunLoopRun
4   CoreFoundation                  0x347e89ad8         CFRunLoopRunSpecific
5   AVFAudio                        0x3332dbc18         GenericRunLoopThread::Entry
6   AVFAudio                        0x33332cd5c         CAPThread::Entry
7   libsystem_pthread.dylib         0x31f8a0d88         _pthread_start

Thread 7
0   libsystem_kernel.dylib          0x348066a7c         __workq_kernreturn
1   libsystem_pthread.dylib         0x31f8a1bd0         _pthread_wqthread

Thread 8
0   libsystem_kernel.dylib          0x348066a7c         __workq_kernreturn
1   libsystem_pthread.dylib         0x31f8a1bd0         _pthread_wqthread

Thread 9
0   libobjc.A.dylib                 0x347ce829c         objc_opt_self
1   Foundation                      0x3172f5800         +[NSMutableData(NSMutableData) allocWithZone:]
2   Foundation                      0x317328118         +[NSMutableData(NSMutableData) dataWithLength:]
3   AppMap                          0x10152f9f8         -[GMSx_GPBMessage data]
4   AppMap                          0x1014f697c         GMSExtractProtoExtension
5   AppMap                          0x1015e1a58         gmscore::model::UnpackStyleWithProtoRenderOp
6   AppMap                          0x1015e180c         gmscore::model::MakeLabelGroupWithLabelGroup
7   AppMap                          0x1015c7a44         +[GMSPointOfInterest unpackedPOIWithProto:wireContext:]
8   AppMap                          0x101629194         GMSVectorTileFromTileProto
9   AppMap                          0x10162830c         GMSModelTileFromTileProto
10  AppMap                          0x101632ca4         -[GMSMapTileService processResponseProto:intoBatchResponse:]
11  AppMap                          0x10162f7d0         -[GMSDASHTileService handleServerResponse:error:tileRequests:elapsedTime:]
12  AppMap                          0x10162b560         __71-[GMSDASHBatchedTileRequest initWithTileRequests:timingClock:delegate:]_block_invoke
13  AppMap                          0x101462554         -[GMSDASHProtobufferRequest scheduleRetryIfApplicableForResponse:error:connection:]
14  AppMap                          0x101461e74         __74-[GMSDASHProtobufferRequest dispatchHandlerWithResponse:error:connection:]_block_invoke
15  libdispatch.dylib               0x32650860c         _dispatch_call_block_and_release
16  libdispatch.dylib               0x326509180         _dispatch_client_callout
17  libdispatch.dylib               0x3264b1a38         _dispatch_continuation_pop$VARIANT$mp
18  libdispatch.dylib               0x3264b118c         _dispatch_async_redirect_invoke
19  libdispatch.dylib               0x3264bdfa0         _dispatch_root_queue_drain
20  libdispatch.dylib               0x3264be76c         _dispatch_worker_thread2
21  libsystem_pthread.dylib         0x31f8a1b44         _pthread_wqthread

Thread 10
0   libsystem_kernel.dylib          0x3480688a4         stat64
1   CoreData                        0x316fb1c7c         -[NSPersistentStore(_NSInternalMethods) _preflightCrossCheck]
2   CoreData                        0x3170cff3c         __65-[NSPersistentStoreCoordinator executeRequest:withContext:error:]_block_invoke.767
3   CoreData                        0x316f6a1d0         -[NSPersistentStoreCoordinator _routeHeavyweightBlock:]
4   CoreData                        0x316f6af5c         -[NSPersistentStoreCoordinator executeRequest:withContext:error:]
5   CoreData                        0x316f6be14         -[NSManagedObjectContext save:]
6   AppMap                          0x1015a5954         __62-[GMSTileDataCache storeCacheableTileDatas:completionHandler:]_block_invoke
7   CoreData                        0x3170a1de8         developerSubmittedBlockToNSManagedObjectContextPerform
8   libdispatch.dylib               0x326509180         _dispatch_client_callout
9   libdispatch.dylib               0x3264b5400         _dispatch_lane_serial_drain$VARIANT$mp
10  libdispatch.dylib               0x3264b5df4         _dispatch_lane_invoke$VARIANT$mp
11  libdispatch.dylib               0x3264bf310         _dispatch_workloop_worker_thread
12  libsystem_pthread.dylib         0x31f8a1b84         _pthread_wqthread

Thread 11
0   libsystem_kernel.dylib          0x348066a7c         __workq_kernreturn
1   libsystem_pthread.dylib         0x31f8a1bd0         _pthread_wqthread

Thread 13
0   libsystem_pthread.dylib         0x31f8a4758         start_wqthread

Thread 14
0   libsystem_kernel.dylib          0x348044634         mach_msg_trap
1   libsystem_kernel.dylib          0x348043a9c         mach_msg
2   CoreFoundation                  0x347e8f284         __CFRunLoopServiceMachPort
3   CoreFoundation                  0x347e8a3a4         __CFRunLoopRun
4   CoreFoundation                  0x347e89ad8         CFRunLoopRunSpecific
5   Foundation                      0x3172e4780         -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
6   AppMap                          0x101732ea8         -[GMSx_GTMSimpleWorkerThread main]
7   Foundation                      0x317415098         __NSThread__start__
8   libsystem_pthread.dylib         0x31f8a0d88         _pthread_start



EOF

be...@swiftkey.com <be...@swiftkey.com> #3Mar 25, 2019 05:48PM

In the last 3 hours i received several various app crashes. It seems as the same problem. At the first sight it is probably looks like critical memory leeks in Google Maps SDK.

Some examples:

--------------
Crashed: com.apple.root.utility-qos
0 libsystem_malloc.dylib 0x1a38ac49c nanov2_allocate_from_block.cold.1 + 40
1 libsystem_malloc.dylib 0x1a389bce0 nanov2_find_block_and_allocate + 558
2 libsystem_malloc.dylib 0x1a389adf4 nanov2_allocate + 128
3 libsystem_malloc.dylib 0x1a389ad1c nanov2_malloc + 64
4 libsystem_malloc.dylib 0x1a389f360 malloc_zone_malloc + 164
5 libsystem_malloc.dylib 0x1a389fe00 malloc + 32
6 libc++abi.dylib 0x1a396fb48 operator new(unsigned long) + 32
7 SushiWOK 0x10485fd7c void std::__1::vector<gmscore::base::reffed_ptr<gmscore::vector::LabelableFeature>, std::__1::allocator<gmscore::base::reffed_ptr<gmscore::vector::LabelableFeature> > >::__emplace_back_slow_path<gmscore::vector::POILabelableFeature*>(gmscore::vector::POILabelableFeature*&&) + 135748
8 SushiWOK 0x10485c6b8 -[GMSUWFRenderTile labelableFeaturesFromFeature:styleTable:includeIndoorRelations:isPSMFeature:] + 121728
9 SushiWOK 0x104859258 gmscore::vector::detail::FeatureParser::AddLabelableFeature(id<GMSFeature>, bool) + 108320
10 SushiWOK 0x104859610 gmscore::vector::detail::FeatureParser::ParseFeature(id<GMSFeature>) + 109272
11 SushiWOK 0x10485ade8 -[GMSUWFRenderTile featureDataFromTile:withFeatureCodes:featureFilters:indoorLevelID:] + 115376
12 SushiWOK 0x10485a630 -[GMSUWFRenderTile initWithVectorTile:styleTable:epochToStyleTableMap:diffTiles:nextMultiZoom:uiScale:flags:labelSource:filterFeatures:indoorLevelID:] + 113400
13 SushiWOK 0x1048463dc -[GMSVectorTileProvider completeRenderTileFromVectorTile:diffTiles:tileCoords:styleTable:epochToStyleTableMap:handler:] + 30884
14 SushiWOK 0x104845f64 __83-[GMSVectorTileProvider buildRenderTileFromModelTile:diffTiles:tileCoords:handler:]_block_invoke + 29740
15 SushiWOK 0x104846acc __81-[GMSVectorTileProvider loadStyleTablesForMapStyle:epochs:callbackQueue:handler:]_block_invoke + 32660
16 libdispatch.dylib 0x1a3852ec4 _dispatch_call_block_and_release + 32
17 libdispatch.dylib 0x1a385433c _dispatch_client_callout + 20
18 libdispatch.dylib 0x1a38636e8 _dispatch_root_queue_drain + 644
19 libdispatch.dylib 0x1a3863d9c _dispatch_worker_thread2 + 116
20 libsystem_pthread.dylib 0x1a38bb6d8 _pthread_wqthread + 216
21 libsystem_pthread.dylib 0x1a38c19c8 start_wqthread + 8

-----------------
Crashed: com.apple.main-thread
0 libobjc.A.dylib 0x19b138fa8 objc_msgSend + 8
1 SushiWOK 0x1047f59c8 -[GMSTileTypeExpirations initWithExpirationsProto:] + 33672
2 SushiWOK 0x1047f6714 -[GMSCoreClientParameters updateTypedParamGroup:] + 37076
3 SushiWOK 0x104659574 -[GMSAPIClientParameters updateTypedParamGroup:] + 4375598452
4 SushiWOK 0x1046a9fb8 -[GMSClientParameters updateParamGroup:] + 272784
5 SushiWOK 0x1046aac20 -[GMSClientParameters handleClientParametersResponse:] + 275960
6 SushiWOK 0x1046aa8ec -[GMSClientParameters handleClientParameterResponse:error:retriesRemaining:forcingRequest:] + 275140
7 SushiWOK 0x1046aa7e4 __81-[GMSClientParameters sendClientParametersRequestAllowingRetries:forcingRequest:]_block_invoke + 274876
8 SushiWOK 0x1046af17c -[GMSDASHProtobufferRequest scheduleRetryIfApplicableForResponse:error:connection:] + 293716
9 SushiWOK 0x1046aea9c __74-[GMSDASHProtobufferRequest dispatchHandlerWithResponse:error:connection:]_block_invoke + 291956
10 libdispatch.dylib 0x19b0c8b7c _dispatch_call_block_and_release + 32
11 libdispatch.dylib 0x19b0c9fd8 _dispatch_client_callout + 20
12 libdispatch.dylib 0x19b0d5cc8 _dispatch_main_queue_callback_4CF + 968
13 CoreFoundation 0x19b39fcc8 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 16
14 CoreFoundation 0x19b39aa24 __CFRunLoopRun + 1980
15 CoreFoundation 0x19b399f40 CFRunLoopRunSpecific + 480
16 GraphicsServices 0x1a562a534 GSEventRunModal + 108
17 UIKitCore 0x19f525580 UIApplicationMain + 1940
18 SushiWOK 0x104356790 main + 18 (HomeBannerSlideViewController.swift:18)
19 libdyld.dylib 0x19b218e18 start + 4

----------
Crashed: com.google.Maps.FileIO
0 libobjc.A.dylib 0x190f4a088 objc_msgSend + 8
1 SushiWOK 0x102f0503c GMSx_GPBComputeBytesSize + 973332
2 SushiWOK 0x102f3341c -[GMSx_GPBUnknownField serializedSize] + 1162740
3 SushiWOK 0x102f346c0 GPBUnknownFieldSetSerializedSize + 1167512
4 CoreFoundation 0x19116df44 __CFDictionaryApplyFunction_block_invoke + 24
5 CoreFoundation 0x1912472f8 CFBasicHashApply + 136
6 CoreFoundation 0x19116dee4 CFDictionaryApplyFunction + 184
7 SushiWOK 0x102f34690 -[GMSx_GPBUnknownFieldSet serializedSize] + 1167464
8 SushiWOK 0x102f3089c -[GMSx_GPBMessage serializedSize] + 1151604
9 SushiWOK 0x102f04f98 GMSx_GPBComputeMessageSize + 973168
10 SushiWOK 0x102f307f0 -[GMSx_GPBMessage serializedSize] + 1151432
11 SushiWOK 0x102f02004 -[GMSx_GPBCodedOutputStream writeMessageNoTag:] + 960988
12 SushiWOK 0x102f04084 -[GMSx_GPBCodedOutputStream writeMessageArray:values:] + 969308
13 SushiWOK 0x102f2c948 -[GMSx_GPBMessage writeToCodedOutputStream:] + 1135392
14 SushiWOK 0x102f2c7b8 -[GMSx_GPBMessage writeToOutputStream:] + 1134992
15 SushiWOK 0x102ef2f88 GMSSaveProto + 899424
16 SushiWOK 0x102e5afd8 __54-[GMSClientParameters handleClientParametersResponse:]_block_invoke + 276912
17 SushiWOK 0x102eeecf4 __GMSScheduleFileIOBlockWithBackgroundTask_block_invoke.11 + 882380
18 libdispatch.dylib 0x190ef2610 _dispatch_call_block_and_release + 24
19 libdispatch.dylib 0x190ef3184 _dispatch_client_callout + 16
20 libdispatch.dylib 0x190e9f538 _dispatch_lane_serial_drain$VARIANT$mp + 916
21 libdispatch.dylib 0x190e9fdf8 _dispatch_lane_invoke$VARIANT$mp + 420
22 libdispatch.dylib 0x190ea9314 _dispatch_workloop_worker_thread + 588
23 libsystem_pthread.dylib 0x190f42b88 _pthread_wqthread + 276
24 libsystem_pthread.dylib 0x190f45760 start_wqthread + 8

be...@swiftkey.com <be...@swiftkey.com> #4Apr 24, 2019 11:48AM

Thanks for your post. It appears that you are experiencing the same issue as

https://issuetracker.google.com/154855417. Please star the this issue to receive notifications regarding the updates of this bug as all publicly available updates will be posted there.

Rest assured that we have logged this internally and our engineering team is currently working on the fix. For the meantime, please consider the possible workaround posted in comment

https://issuetracker.google.com/issues/154855417#comment181

Marking this as a duplicate of

https://issuetracker.google.com/154855417

ki...@google.com <ki...@google.com> #5Apr 24, 2019 03:29PM

+Ian for FragmentManagerImpl
+Andrey for ViewUtils and ViewGroupUtilsApi14

an...@google.com <an...@google.com> #6Apr 24, 2019 03:57PM

Last two are from transitions and we will be releasing a new version 1.2.0-qpreview01 where reflections are handled properly with the next batched release in May

il...@google.com <il...@google.com> #7Apr 24, 2019 04:03PM

We've already removed the use of reflection in FragmentManager as part of

b/129486478

ki...@google.com <ki...@google.com> #8Apr 24, 2019 04:35PM

getHorizontallyScrolling will be switched to

https://developer.android.com/reference/android/widget/TextView.html#isHorizontallyScrollable()
doAfterTextChanged + doBeforeTextChanged will be switched to

https://developer.android.com/reference/android/widget/AutoCompleteTextView.html#refreshAutoCompleteResults()

ensureImeVisible needs an additional (internal) step to expose one missing API

be...@swiftkey.com <be...@swiftkey.com> #9Apr 25, 2019 10:23AM

Thanks for all the information!

ki...@google.com <ki...@google.com> #10Apr 25, 2019 08:40PM

Remaining usages of reflection in appcompat on the latest SDK:

* ViewUtils - View.computeFitSystemWindows and View.makeOptionalFitsSystemWindows
* AppCompatTextViewAutoSizeHelper - TextView.getLayoutAlignment
* ListPopupWindow - PopupWindow.setClipToScreenEnabled, getMaxAvailableHeight and setEpicenterBounds
* MenuPopupWindow - PopupWindow.setTouchModal
* SearchView - AutoCompleteTextView.ensureImeVisible
* DropDownListView - AbsListView.mIsChildViewEnabled (field)

ki...@google.com <ki...@google.com> #11Apr 25, 2019 08:52PM

All PopupWindow APIs are available in Q. Will prepare another CL to switch ListPopupWindow and MenuPopupWindow.

ki...@google.com <ki...@google.com> #12Apr 25, 2019 09:00PM

Wasn't looking in the right branch. All PopupWindow usages have already been converted and waiting for the final Q SDK build. What is left right now:

* ViewUtils - View.computeFitSystemWindows and View.makeOptionalFitsSystemWindows
* AppCompatTextViewAutoSizeHelper - TextView.getLayoutAlignment
* SearchView - AutoCompleteTextView.ensureImeVisible
* DropDownListView - AbsListView.mIsChildViewEnabled (field)

ky...@gmail.com <ky...@gmail.com> #13May 10, 2019 10:37AM

To update issue status

kb...@yelp.com <kb...@yelp.com> #14Sep 10, 2019 11:46AM

Any updates on this issue now that the final build is out?

be...@swiftkey.com <be...@swiftkey.com> #15Sep 23, 2019 01:41PM

Is there an idea of when all issues will be fixed? Veridex still finds the following issues with Appcompat 1.1.0, Activity 1.0.0 and Transition 1.1.0:

Reflection greylist-max-p Landroid/animation/LayoutTransition;->cancel use(s):
Landroidx/transition/ViewGroupUtilsApi14;->cancelLayoutTransition(Landroid/animation/LayoutTransition;)V

Reflection greylist-max-p Landroid/view/View;->mViewFlags use(s):
Landroidx/transition/ViewUtils;->fetchViewFlagsField()V

Reflection greylist-max-p Landroid/view/View;->setFrame use(s):
Landroidx/transition/ViewUtilsBase;->fetchSetFrame()V

Reflection greylist-max-p Landroid/view/inputmethod/InputMethodManager;->mH use(s):
Landroidx/activity/ImmLeaksCleaner;->initializeReflectiveFields()V

Reflection greylist-max-p Landroid/view/inputmethod/InputMethodManager;->mNextServedView use(s):
Landroidx/activity/ImmLeaksCleaner;->initializeReflectiveFields()V

Reflection greylist-max-p Landroid/view/inputmethod/InputMethodManager;->mServedView use(s):
Landroidx/activity/ImmLeaksCleaner;->initializeReflectiveFields()V

Reflection greylist-max-p Landroid/widget/AutoCompleteTextView;->doAfterTextChanged use(s):
Landroidx/appcompat/widget/SearchView$AutoCompleteTextViewReflector;-><init>()V

Reflection greylist-max-p Landroid/widget/AutoCompleteTextView;->doBeforeTextChanged use(s):
Landroidx/appcompat/widget/SearchView$AutoCompleteTextViewReflector;-><init>()V

Reflection greylist-max-p Landroid/widget/AutoCompleteTextView;->ensureImeVisible use(s):
Landroidx/appcompat/widget/SearchView$AutoCompleteTextViewReflector;-><init>()V

Reflection greylist-max-p Landroid/widget/ImageView;->mDrawMatrix use(s):
Landroidx/transition/ImageViewUtils;->fetchDrawMatrixField()V

ki...@google.com <ki...@google.com> #16Sep 23, 2019 07:34PM

ImageViewUtils.fetchDrawMatrix usage of mDrawMatrix should be happening only on pre-29 versions of the platform.
ViewUtilsBase.fetchSetFrame usage of setFrame should be happening only on pre-29 versions of the platform.
ViewUtils.setTransitionVisibility usage of mViewFlags should be happening only on pre-29 versions of the platform.
ViewGroupUtilsApi14.cancelLayoutTransition usage of cancel should be happening only on pre-29 versions of the platform.

Filed 141481690 on ImmLeaksCleaner of androidx.activity component

ki...@google.com <ki...@google.com> #17Sep 23, 2019 08:09PM

ImmLeaksCleaner is used in

https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/activity/activity/src/main/java/androidx/activity/ComponentActivity.java#125 only on 19..23 versions of the platform.

be...@swiftkey.com <be...@swiftkey.com> #18Sep 26, 2019 11:30AM

Thank you very much for confirming these! That leaves the 3 issues in AutoCompleteTextView left, do you have an idea of when they'll be fixed?

vi...@google.com <vi...@google.com> #19Nov 14, 2019 07:00AM

Considering the P1 priority, please let us know if there is any further updates on this bug and its fix plan. It's been more than a month with no updates. If there is no plan in the near future to fix this issue, please let us know if we can reduce the priority of the bug.

al...@google.com <al...@google.com> #20Apr 8, 2020 07:55PM

Removing from all platform hotlists, since this isn't tied to the platform release.

al...@google.com <al...@google.com> #21Apr 8, 2020 07:55PM

Kirill, is there remaining work here?

ki...@google.com <ki...@google.com> #22Apr 8, 2020 08:09PM

Reassigned to jj...@google.com.

See

https://b.corp.google.com/issues/123768509#comment2

https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/appcompat/appcompat/src/main/java/androidx/appcompat/widget/ViewUtils.java is still using reflection to access computeFitSystemWindows and makeOptionalFitsSystemWindows.

That comment says that something has been punted to R. Going to reassign to that team to see what's happening there.

jj...@google.com <jj...@google.com> #23Apr 8, 2020 08:53PM

Reassigned to ch...@google.com.

Chris, I thought ABOL would be deprecated in favor of Toolbar? I believe ABOL is the only customer for this..

ch...@google.com <ch...@google.com> #24Apr 9, 2020 07:15AM

Reassigned to jj...@google.com.

It's not officially deprecated, but not really something devs shouldn't be using, but there will obviously be a lot of apps which do use it. I don't have a fix for this, it needs to use the makeOptionalFitsSystemWindows API. ABOL has already migrated away from computeFitSystemWindows.

al...@google.com <al...@google.com> #25Apr 19, 2021 07:04PM

Jorim, what's the state of this? We're still making the reflective call from the library, and I'd like to get it removed. Can we make the platform API public, is the API being removed, or is there an alternative API that we can call?

jj...@google.com <jj...@google.com> #26Apr 20, 2021 12:30PM

Reassigned to ti...@google.com.

I think we may be able to remove this call on R+ potentially? With the Window.setFitsSystemWindows.

ro...@gmail.com <ro...@gmail.com> #27Apr 27, 2021 02:04PM

Hey. Found this thread after checking our app for strict mode violations. Any updates?

Full logs
```
android.os.strictmode.NonSdkApiUsedViolation: Landroid/view/ViewGroup;->makeOptionalFitsSystemWindows()V
at android.os.StrictMode.lambda$static$1(StrictMode.java:416)
at android.os.-$$Lambda$StrictMode$lu9ekkHJ2HMz0jd3F8K8MnhenxQ.accept(Unknown Source:2)
at java.lang.Class.getDeclaredMethodInternal(Native Method)
at java.lang.Class.getPublicMethodRecursive(Class.java:2079)
at java.lang.Class.getMethod(Class.java:2066)
at java.lang.Class.getMethod(Class.java:1693)
at androidx.appcompat.widget.ViewUtils.makeOptionalFitsSystemWindows(ViewUtils.java:84)
at androidx.appcompat.app.AppCompatDelegateImpl.createSubDecor(AppCompatDelegateImpl.java:973)
at androidx.appcompat.app.AppCompatDelegateImpl.ensureSubDecor(AppCompatDelegateImpl.java:806)
at androidx.appcompat.app.AppCompatDelegateImpl.onPostCreate(AppCompatDelegateImpl.java:527)
at androidx.appcompat.app.AppCompatActivity.onPostCreate(AppCompatActivity.java:127)
at android.app.Instrumentation.callActivityOnPostCreate(Instrumentation.java:1383)
at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3484)
```

fe...@gmail.com <fe...@gmail.com> #28Oct 12, 2022 02:00AM

Hello,
Just seconding al...@google.com's comment. Still getting StrictMode violations due to makeOptionalFitsSystemWindows. Should I be using something else to create a Toolbar? Shoudl I not use AppCompat at all?

ub...@gmail.com <ub...@gmail.com> #29Oct 25, 2023 01:35PM

Regardless of the eventual resolution of this long-standing issue: for the time being appcompat needs to address the log spamming & crashes that are causing problems here for anyone wanting to analyze their own app code for SDK incompatibilities.

appcompat needs to wrap the offending calls with code to temporarily disable the API checks. Here's the gist:

if (Build.VERSION_CODES.P <= Build.VERSION.SDK_INT) {
    val oldPolicy = StrictMode.getVmPolicy()

    StrictMode.setVmPolicy(
            VmPolicy.Builder(oldPolicy).permitNonSdkApiUsage().build()
        )
    }

    computeFitSystemWindowsOrWhatever()

    StrictMode.setVmPolicy(oldPolicy)
) else {
    computeFitSystemWindowsOrWhatever()
}

This can be turned into an API to make it nicer to use, for inspiration see https://github.com/bubenheimer/strictmodeutil