Status Update
No update yet.
Comments
sp...@google.com
sp...@google.com
Hi Jomo, can you take a look at this one?
va...@gmail.com
Currently we are filtering the flags. Maybe we should just allow -C as well?
[Deleted User] <[Deleted User]>
It would be great if -C can be allowed.
CMake is evolving. Recently support for log levels was introduced. With filtering cannot pass --log-level=VERBOSE into CMake.
Isn't blacklisting -G, -S, -B and a few others a better approach?
Plugin can emit a warning/error if user try to override one of them. Message will help developers to correct script files and prevent half-baked builds from happening.
As for scope of this issue, I'm totally fine with -C being allowed.
sp...@google.com
I would love to move forward and you're able to help me with that.
Any chance for this to be solved in near future?
va...@gmail.com
Like in school. The best way to get a silence is to ask a question. :D
sp...@google.com
It looks like a bug to me. I think it's related to the fact that we don't append arguments to the result here:
va...@gmail.com
All flags should be passable now, even ones like -G or -N that are likely to result in an unstable or unusable project. So, it's caveat emptor for now and I'll disallow some flags if that turns out to be too problematic.
(internal reference ag/a5f1a02d3faa4e41bacf1885efc3581c36c5c9fe)
sp...@google.com
I will test it on my machine and wait for full release to bump on build agents.
Thank you very much!
va...@gmail.com
Hello. I would like to get you know than in Gradle plugin 4.2.1 -C is still removed from CMake command line.
Description
After running Lint I saw the following complains from Lint:
```
Incorrect icon size for `mipmap-hdpi/ic_launcher_foreground.png`: expected 72x72, but was 162x162 for /home/niklas/dev/GitHub/vanniktech/app-yatzy/src/main/res/mipmap-hdpi/ic_launcher_foreground.png
Incorrect icon size for `mipmap-mdpi/ic_launcher_foreground.png`: expected 48x48, but was 108x108 for /home/niklas/dev/GitHub/vanniktech/app-yatzy/src/main/res/mipmap-mdpi/ic_launcher_foreground.png
Incorrect icon size for `mipmap-xhdpi/ic_launcher_foreground.png`: expected 96x96, but was 216x216 for /home/niklas/dev/GitHub/vanniktech/app-yatzy/src/main/res/mipmap-xhdpi/ic_launcher_foreground.png
Incorrect icon size for `mipmap-xxhdpi/ic_launcher_foreground.png`: expected 144x144, but was 324x324 for /home/niklas/dev/GitHub/vanniktech/app-yatzy/src/main/res/mipmap-xxhdpi/ic_launcher_foreground.png
Incorrect icon size for `mipmap-xxxhdpi/ic_launcher_foreground.png`: expected 192x192, but was 432x432 for /home/niklas/dev/GitHub/vanniktech/app-yatzy/src/main/res/mipmap-xxxhdpi/ic_launcher_foreground.png
```
Either the wizard is generating the images with incorrect sizes or the Lint check is using the wrong dimensions. In either case an app icon that was generated using the wizard should not be flagged by Lint.