onAuthenticationError called with null [128350861]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Mar 12, 2019 01:05PM

Version 1.0.0-alpha03

Not sure how to reproduce but crash shows up in Crashlytics.

Inspecting the code offers an explanation:

If `FingerprintHelperFragment.sendErrorToClient()` is passed an int that is not ERROR_HW_NOT_PRESENT,
ERROR_HW_UNAVAILABLE, ERROR_NO_BIOMETRICS or ERROR_USER_CANCELED `getErrorString()` returns null which is passed to onAuthenticationError which is annotated @NonNull.

This causes a crash when AuthenticationCallback is implemented in Kotlin

Comments

kc...@google.com <kc...@google.com> Jun 20, 2019 01:27AM

Assigned to kc...@google.com.

kc...@google.com <kc...@google.com> #2Jun 25, 2019 06:58PM

Reassigned to cu...@google.com.

We should have backup strings in the support library that checks the return value from FingerprintManager

It's possible that vendors are sending vendor errors (non public HIDL messages) without overlaying the vendor strings. IN that case we should probably send a generic message like "Try again"

cu...@google.com <cu...@google.com> Jun 25, 2019 11:57PM

Accepted by cu...@google.com.

kc...@google.com <kc...@google.com> #3Jun 26, 2019 03:10AM

Marked as fixed.

Fixed in aosp/997173

Not sure why buganizer doesn't get associated to aosp CLs

rh...@gmail.com <rh...@gmail.com> #4Sep 26, 2019 03:09PM

This error was reintroduced in 1.0.0-beta02

kc...@google.com <kc...@google.com> #5Sep 26, 2019 04:44PM

Do you have a stack trace? I don't see any suspicious commits.

rh...@gmail.com <rh...@gmail.com> #6Sep 26, 2019 06:31PM

Process: com.rhi.rockethq.testing, PID: 15209
java.lang.IllegalArgumentException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter errString
at com.rhi.rockethq.Helpers.AccountAuth.BiometricAuthenticationHandler$initializeBiometricPrompt$1$1.onAuthenticationError(Unknown Source:6)
at androidx.biometric.BiometricFragment$2$1.run(BiometricFragment.java:82)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:764)

rh...@gmail.com <rh...@gmail.com> #7Sep 26, 2019 06:33PM

Its occurring on Samsung devices after facial recognition fails.

kc...@google.com <kc...@google.com> #8Sep 26, 2019 06:42PM

Ok, I'll fork that to a new bug for investigation -

b/141700902