Fixed
Status Update
No update yet.
Comments
rm...@google.com
Thank you for suggesting this enhancement. We value the feedback from our community and hope to review your suggestion in an upcoming sprint.
sp...@google.com
Jamal, please weigh in on the desired behavior.
ea...@google.com
Thanks for raising the issue. The 24 dp is there because if you choose a default clip art icon, these come from the material design system icons which are set to 24dp (https://material.io/design/iconography/system-icons.html ).
I think the behavior is right for the system icons from the clip art, but I agree for local file imports radio button option, the values in the box should be the original size of the source SVG file and not 24 dp and the override check box should allow for edits of the values.
I think the behavior is right for the system icons from the clip art, but I agree for local file imports radio button option, the values in the box should be the original size of the source SVG file and not 24 dp and the override check box should allow for edits of the values.
lb...@gmail.com
@4 I think the "override" checkbox should be gone.
Instead, you could have a clickable button to reset to original size .
And right when you choose the file, it should show you the sizes in editable manner, including checkbox of "keep aspect ratio" .
This means that if it's turned on, and you change the width, the height will also change.
I think it should be checked by default, as vectors usually are used to have the same aspect ratio and not being distorted...
Instead, you could have a clickable button to reset to original size .
And right when you choose the file, it should show you the sizes in editable manner, including checkbox of "keep aspect ratio" .
This means that if it's turned on, and you change the width, the height will also change.
I think it should be checked by default, as vectors usually are used to have the same aspect ratio and not being distorted...
sp...@google.com
The current default behavior (with "override" unchecked) distorts non-square images. This behavior should be treated as a bug.
lb...@gmail.com
@6 I suggest to replace it, so that people that got used to this weird behavior won't complain about it not working as before.
sp...@google.com
I don't think the "keep aspect ratio" checkbox is needed since the Vector Asset wizard is not a general purpose image editing tool. The aspect ratio should be always preserved without an option to change it.
lb...@gmail.com
@8 I wasn't talking just about this, but setting the new size with keeping aspect ratio helps to make sure that it keeps itself check, without any un-needed calculations on our side.
So I think it is a good thing to have there. It's also very easy to implement.
So I think it is a good thing to have there. It's also very easy to implement.
sp...@google.com
Agree.
lb...@gmail.com
@10 I'm glad you changed your mind.
sp...@google.com
Sorry, there seems to be a misunderstanding. I agree that the aspect ratio should be preserved, but not that there should be an option to change it.
lb...@gmail.com
@12 Why not? We have it now... It would be weird to have 2 text-fields to edit, yet only one can be edited...
I just think it should be a checkbox that is checked by default, because that's the most common thing that's expected to be used in case of size setting (which might be rare anyway, if the bug didn't exist).
I just think it should be a checkbox that is checked by default, because that's the most common thing that's expected to be used in case of size setting (which might be rare anyway, if the bug didn't exist).
sp...@google.com
Both fields will be editable but the value in the field not currently being edited will follow the the field being edited to maintain aspect ratio. To change my mind you would have to come up with a compelling case for changing aspect ratio of images during import. "We have it now" is not a sufficient reason for keeping something that doesn't serve any useful purpose.
lb...@gmail.com
@14 Easy use case: The designer person (or someone important from the staff) wants the image to look a bit differently than what was originally set, and he's out of reach or busy at the moment.
sp...@google.com
Adjusting aspect ratio of a drawable is pretty rare. The low frequency of its use does not justify additional clutter and complexity in the Vector Asset wizard.
lb...@gmail.com
@16 The current UI is not cluttered. It has 2 text-fields, just like what I suggest to have, with a checkbox.
Why are you afraid of having it? I don't think it will cause people to be confused of what it's doing.
Why are you afraid of having it? I don't think it will cause people to be confused of what it's doing.
Description
To workaround this, I have to always make sure that "override" checkbox is ticked, which doesn't even make sense (because I expect "override" to let me change to a different size, yet the original size that it chose is wrong...) .
Please make it always choose the original size that the SVG has, and not force it to be 24dp.
Attached video to show what I mean.