Animate changes to app bar [131403621]

Fixed

Bug

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Apr 27, 2019 12:53AM

Component used: Navigation
Version used: 2.0.0
Devices/Android versions reproduced on: all

My navigation destinations have different title bars:
* The top-level bar has no menu/back icon
* Each destination has its own title text

When I navigate between destinations, the Navigation library updates the app bar icon and title text, but no animation occurs. As a result, the app bar change is startling, whereas the content change is smooth. For the user, this makes the app feel like it has a bug or something.

Can you add a feature to animate changes to the app bar? Some animations I'd like to see are:
* If the icon is being added or removed, slide the title text from its original position to its new position
* Otherwise, either cross-fade the title or maybe match the destination transition animation

Thanks

Comments

il...@google.com <il...@google.com> #2Apr 27, 2019 01:05AM

Dany, I believe this is fixed in a new release of safeargs ?

sa...@gmail.com <sa...@gmail.com> #3Apr 27, 2019 01:43AM

Safeargs still needs AndroidComponentsExtension to get the applicationID from the variants (https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt;l=73). Did AGP 7.2.0-alpha05 remove the extension?

il...@google.com <il...@google.com> #4May 13, 2019 10:28PM

Assigned to ki...@google.com.

it moved to a different package : com.android.build.api.variant

ki...@google.com <ki...@google.com> #5May 14, 2019 05:52PM

Reassigned to an...@google.com.

Safeargs still relies on AGP 4.2. We need some of the BaseVariant APIs to have replacements before we can upgrade to 7.0+ (https://issuetracker.google.com/203557189).

ki...@google.com <ki...@google.com> #6May 14, 2019 05:54PM

The BaseVariant API are deprecated but still available in 7.x, so you should be able to release a newer version that uses the new package and still relies on the old API you require. Or am I missing something ?

an...@google.com <an...@google.com> #7May 14, 2019 06:16PM

I'll try updating to the latest stable to see if we run into any issues. I can check to make sure changing the package name in 7.2.0-alpha05 works, but we would need it to be stable before we could do a release with this change.

an...@google.com <an...@google.com> May 16, 2019 11:21AM

Reassigned to ki...@google.com.

ki...@google.com <ki...@google.com> #8May 16, 2019 02:26PM

Status: Won't Fix (Intended Behavior)

FYI this also breaks the latest Studio (2021.1.1 Beta 5)/AGP (7.1.0-beta05) beta where com.android.build.api.extension.AndroidComponentsExtension has been removed.

Is there a particular reason why https://issuetracker.google.com/203557189 and this issues don't have a higher priority?

As it stands, no one can upgrade either AGP/Studio Beta or Canary and take advantage of fixes in the latest versions because Navigation still uses the old AGP APIs.

sa...@gmail.com <sa...@gmail.com> #9May 17, 2019 09:04PM

Was this fixed in Studio 2021.1.1 RC 1?

sa...@gmail.com <sa...@gmail.com> #10May 17, 2019 09:16PM

I do not think so https://developer.android.com/studio/releases/fixed-bugs/studio/2021.1.1#android-studio-bumblebee-rc-01-2021.1.1.19.

Pretty disappointing though.

ki...@google.com <ki...@google.com> #11May 17, 2019 09:24PM

This will be fixed in the Navigation Safe Args 2.5.0-alpha01 and 2.4.1 versions. You can follow the snapshot instructions and try this out with build id #8054565.

il...@google.com <il...@google.com> #12May 23, 2019 10:43PM

Status: Assigned (reopened)

Thank you! 2.4.1 is at least two weeks out (possibly 4, if I'm not mistaken).

I applaud the AGPs team decision to stick to the new APIs though. Hopefully its not too long before Navigation fixes this.

ap...@google.com <ap...@google.com> #13Jun 28, 2019 08:49PM

So we are talking mid february ?

jb...@google.com <jb...@google.com> #14Jun 28, 2019 09:23PM

Marked as fixed.

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Dolphin Canary 5 (2021.3.1.5)
Android Gradle Plugin 7.3.0-alpha05

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!