Fixed
Status Update
Comments
ch...@google.com <ch...@google.com> #2
Thanks for the report. Would it be possible for you to share the generated APK? If you prefer to share it privately you can send it to christofferqa@google.com or sgjesse@google.com.
ch...@google.com <ch...@google.com>
ch...@google.com <ch...@google.com> #3
Thanks for sharing the APK. I can confirm that the VerifyError is reproducible on api level 19 and below.
ch...@google.com <ch...@google.com> #4
For the record, this effectively happens because there is a non-abstract class in the application which has a non-abstract method. Simply making the class abstract solves the problem.
I will investigate if there are any optimizations in R8 that introduce abstract methods without making the enclosing class abstract as well.
I will investigate if there are any optimizations in R8 that introduce abstract methods without making the enclosing class abstract as well.
ch...@google.com <ch...@google.com> #5
Chen, could you try to enable assertions and build with R8 version a9bd718ac704fedaef90329f378fd06aab11e0f2 by making the following changes to build.gradle?
buildscript {
repositories {
maven {
url "http://storage.googleapis.com/r8-releases/raw/master "
}
}
dependencies {
classpath 'com.android.tools:r8:a9bd718ac704fedaef90329f378fd06aab11e0f2' // Must be before the Gradle Plugin for Android.
classpath 'com.android.tools.build:gradle:X.Y.Z' // Your current AGP version.
}
}
You can build with assertions enabled using the following command:
$ ./gradlew clean assembleRelease -Dorg.gradle.jvmargs="-ea:com.android.tools.r8... -Xmx1536m"
buildscript {
repositories {
maven {
url "
}
}
dependencies {
classpath 'com.android.tools:r8:a9bd718ac704fedaef90329f378fd06aab11e0f2' // Must be before the Gradle Plugin for Android.
classpath 'com.android.tools.build:gradle:X.Y.Z' // Your current AGP version.
}
}
You can build with assertions enabled using the following command:
$ ./gradlew clean assembleRelease -Dorg.gradle.jvmargs="-ea:com.android.tools.r8... -Xmx1536m"
ch...@google.com <ch...@google.com> #6
This should be fixed by https://r8-review.googlesource.com/c/r8/+/39220 and https://r8-review.googlesource.com/c/r8/+/39222 , which both landed in R8 version 1.5.44.
You should be able to build with this version by making the following changes to build.gradle:
buildscript {
repositories {
maven {
url 'http://storage.googleapis.com/r8-releases/raw '
}
}
dependencies {
classpath 'com.android.tools:r8:1.5.44' // Must be before the Gradle Plugin for Android.
classpath 'com.android.tools.build:gradle:X.Y.Z' // Your current AGP version.
}
}
You should be able to build with this version by making the following changes to build.gradle:
buildscript {
repositories {
maven {
url '
}
}
dependencies {
classpath 'com.android.tools:r8:1.5.44' // Must be before the Gradle Plugin for Android.
classpath 'com.android.tools.build:gradle:X.Y.Z' // Your current AGP version.
}
}
ch...@gmail.com <ch...@gmail.com> #7
It works.
Thank you very much.
Thank you very much.
Description