Fixed
Status Update
No update yet.
Comments
rm...@google.com
Thank you for suggesting this enhancement. We value the feedback from our community and hope to review your suggestion in an upcoming sprint.
sr...@google.com
As a side note, there is an implicit limit of 254 modules per include directive since the number of parameters on JVM is limited to this number https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.3.3
Having an include for every module would also help with this.
Having an include for every module would also help with this.
aa...@gmail.com
there could be a line break in-between to make code review easier, like
includes ':app',
'module1',
'module2'
but yea, 254 module limit was the culprit we stared having an `include` per module
includes ':app',
'module1',
'module2'
but yea, 254 module limit was the culprit we stared having an `include` per module
Description
include ':app', ':mylibrary'
This doesn't really scale when you have a lot of modules (line becomes impossible to read) + constantly causes the same line to be edited in your git history. (e.g. if you have 100 modules and add a new one, how to easily tell what module got added in this commit by looking at the one line with 100 comma's?)
Wouldn't it make more sense to include every new module as a separate include line by default?
include ':app'
include ':mylibrary'
--------------------------------------
Build: AI-191.6707.61.35.5549111, 201905092142,
AI-191.6707.61.35.5549111, JRE 1.8.0_202-release-1483-b02x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.14.4, screens 1680x1050; Retina
AS: 3.5 Beta 2; Android Gradle Plugin: 3.5.0-beta02; Gradle: 5.4.1; NDK: from local.properties: 20.0.5392854-beta2, latest from SDK: (not found); LLDB: LLDB 3.1 (revision: 3.1.4508709); CMake: from local.properties: (not specified), latest from SDK: 3.6.0-rc2, from PATH: 3.14.1