GL_EXT_texture_format_BGRA8888 does not work with 3D textures [133730690]

Fixed

Bug

Reviewed (L1)

Status Update

No update yet.

Description

jn...@mozilla.com

created issue #1

May 28, 2019 04:40PM

I noticed that the emulator version 29 added support for GL_EXT_texture_format_BGRA8888. This works as expected for 2D textures (glTexImage2D, with target = GL_TEXTURE_2D). However, when I attempt to use it with a 3D texture (glTexImage3D, with target either GL_TEXTURE_3D or GL_TEXTURE_2D_ARRAY) I get a GL_INVALID_ENUM error. This is the relevant code:

GLuint tex;
glGenTextures(1, &tex);
glBindTexture(GL_TEXTURE_3D, tex);
glTexImage3D(GL_TEXTURE_3D, 0, GL_BGRA_EXT, 1, 1, 1, 0, GL_BGRA_EXT, GL_UNSIGNED_BYTE, nullptr);

It works correctly on a real device, but on the emulator I get an error.

Android Studio Version: 3.3.2

Emulator Version (Emulator--> Extended Controls--> Emulator Version): 29.0.9
HAXM / KVM Version: KVM 12.0.0

Android SDK Tools:

Host Operating System: Fedora 30

CPU Manufacturer: [Intel / AMD / Other] Intel

Steps to Reproduce Bug:
1. Call glTexImage3D with format GL_BGRA_EXT.

Expected Behavior: It works, and there is no gl error.

Observed Behavior: There is a GL_INVALID_ENUM error.

Comments

rm...@google.com <rm...@google.com> #2May 29, 2019 09:09AM

Assigned to lf...@google.com.

Just for context: ViewModel has a final package-private method named clear. That method is unrelated to any method defined in another package in a subclass called clear. Have we accidentally messed that up. We would not be the first ones to do so. In fact any sub class of ViewModel that has a clear method will not work on Dalvik: https://b.corp.google.com/issues/150809965 :-\

lf...@google.com <lf...@google.com> #3May 29, 2019 01:06PM

Reassigned to ya...@google.com.

The override of package private final methods was something I looked at earlier and we should handle the case correctly - except for the case where we have -allowaccessmodification. That seem to not be the case for this example so I will take a closer look.

ya...@google.com <ya...@google.com> #4Jun 4, 2019 07:54PM

Marked as fixed.

Project: r8
Branch: master

commit 55fcc18a27c5ed93acf6fe9db359a28ed5bbeab2
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Fri Oct 23 10:45:51 2020

Test for accessibility of override before caching in seen set

Bug: 171369796
Change-Id: Ic284dd68f1293eec0b3590349d7c6bfec562c7d0

M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/test/java/com/android/tools/r8/resolution/virtualtargets/PackagePrivateFinalOverrideInterfaceTest.java

https://r8-review.googlesource.com/55261

as...@gmail.com <as...@gmail.com> #5Jun 15, 2019 01:53AM

Project: r8
Branch: master

commit 32646725161fc43ba803e46e0e8cc0ce9bd61b6e
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Fri Oct 23 10:45:30 2020

Add test for package private final override with interface error

Bug: 171369796
Change-Id: I5ecddb4173e3eceda57a489f0ba9f2f5dce5d3fc

A src/test/java/com/android/tools/r8/resolution/virtualtargets/PackagePrivateFinalOverrideInterfaceTest.java

https://r8-review.googlesource.com/55260

jn...@mozilla.com <jn...@mozilla.com> #6Sep 30, 2019 02:24PM

Project: r8
Branch: 2.1

commit 85253f5168006f580f091f4850e8e9bf23e379fd
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Fri Oct 23 11:46:33 2020

Test for accessibility of override before caching in seen set

Bug: 171369796
Change-Id: Ic284dd68f1293eec0b3590349d7c6bfec562c7d0

M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/test/java/com/android/tools/r8/resolution/virtualtargets/PackagePrivateFinalOverrideInterfaceTest.java

https://r8-review.googlesource.com/55325

Issue 133730690