AuthenticationCallback#onAuthenticationError returns error codes that are not present in public API [137788194]

Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Jul 17, 2019 10:18PM

AuthenticationCallback#onAuthenticationError returns error codes that are not present in public API.

public void onAuthenticationError(@BiometricError int errorCode, @NonNull CharSequence errString) {}

@BiometricError is an @IntDef that has constants from androidx.biometric.BiometricConstants and all of them are @hide. Developers cannot access them.

Why are these constants private?

Comments

kc...@google.com <kc...@google.com> #2Jul 17, 2019 10:27PM

The whole class is @hide, but it's implemented by BiometricPrompt, which exposes them as public

https://cs.corp.google.com/aosp-androidx/biometric/api/current.txt

kc...@google.com <kc...@google.com> #3Jul 17, 2019 10:28PM

Status: Won't Fix (Not Reproducible)

Feel free to re-open if I'm misunderstanding

au...@google.com <au...@google.com> #4Jul 17, 2019 10:45PM

Status: Assigned (reopened)

Uploaded a fix:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1056203

ap...@google.com <ap...@google.com> #5Jul 17, 2019 11:44PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8723aede2aca5a61776d225b3535d3afcddee615
Author: Aurimas Liutikas <aurimas@google.com>
Date: Wed Jul 17 15:42:59 2019

Use the correct constants in BiometricPrompt @IntDef

BiometricError was referring to constants that are hidden.
Refer to them via BiometricPrompt which is actually public.

Bug: 137788194
Test: ./gradlew assembleDebug still works
Change-Id: I5cd5ac79c80a5980bc2f6dc99407881ba3d3c37e

M biometric/src/main/java/androidx/biometric/BiometricPrompt.java

https://android-review.googlesource.com/1056203

https://goto.google.com/android-sha1/8723aede2aca5a61776d225b3535d3afcddee615

au...@google.com <au...@google.com> Jul 17, 2019 11:44PM

Marked as fixed.

Issue 137788194