Lint does not flag NewApi violations in androidTest sources [139490306]

Fixed

Bug

Reviewed (L1)

Status Update

No update yet.

Description

me...@thomaskeller.biz

created issue #1

Aug 16, 2019 02:49PM

Studio Build: Android Studio 3.4.1
Build #AI-183.6156.11.34.5522156, built on May 1, 2019
JRE: 1.8.0_152-release-1343-b01 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Version of Gradle Plugin: 3.4.1
Version of Gradle: 5.3.1
OS: macOS 10.14

Steps to Reproduce:
1. Untar the test project and head over to ExampleInstrumentationTest
2. The IDE will not underline the use of `dataDir`

This is probably related to

issue 72509079

, but no local annotation processing is involved here, Lint won't simply show up a regular Android API minSdk violation, not even when the `NewApi` check is executed manually through the `Analyze > Run inspection by name` menu item.

LintNewApiIssue.tar.bz2

147 KB

Download

Comments

vi...@google.com <vi...@google.com> #2Aug 19, 2019 08:17AM

Assigned to tn...@google.com.

Thank you for your feedback. Team may reach out for more feedback in reproducing or triaging this issue.

tn...@google.com <tn...@google.com> #3Aug 19, 2019 01:27PM

Lint normally doesn't enforce checks on test sources (except for test-specific lint checks), unless you turn that on with
android {
lintOptions {
checkTestSources true
}
}

me...@thomaskeller.biz <me...@thomaskeller.biz> #4Aug 19, 2019 04:04PM

@Tor - Yes, I know that, but I was under the impression that this only works for Lint Gradle executions? Anyways, I tried to do that before already and at least with my 3.4 AGP this didn't turn the issue red in the editor. I heard that in later versions Lint configurations are more "in sync" with the editor, meaning that excluded rules for example are honored? So should I retest with a newer version?

tn...@google.com <tn...@google.com> #5Aug 19, 2019 04:51PM

As far as I know, configurations that you do in android.lintOptions should also apply in the editor; if not, that's a bug.

tn...@google.com <tn...@google.com> #6Aug 19, 2019 04:52PM

(we wrap lint checks as IntelliJ inspections, and do sync state to these inspection wrappers from the lintOptions configuration, but if you go into IntelliJ's inspections UI and start configuring the inspections directly, then those apply only in the IDE, not back in Gradle.)

me...@thomaskeller.biz <me...@thomaskeller.biz> #7Aug 20, 2019 09:45AM

So I just tried it again, but with 3.4.2 the setting of

android {
lintOptions {
checkTestSources true
}
}

does not help. The issue is still not flagged in the IDE :(
Should I try with 3.5 or even 3.6?

tn...@google.com <tn...@google.com> #8Feb 11, 2020 09:39PM

Marked as fixed.

This is now fixed in 4.1 canary. Sorry about the delay! Fixed by Change-Id: Ia5ef6654a20818ce227647d2832520010dfb265b

me...@thomaskeller.biz <me...@thomaskeller.biz> #9Feb 12, 2020 05:59AM

Thanks!