Fixed
Status Update
Comments
zo...@gmail.com <zo...@gmail.com> #2
When the AIDL file uses "//注释测试", the corresponding java file cannot be generated normally.
zh...@gmail.com <zh...@gmail.com> #3
I have the same issue too, if use 3.4.2, it works
vi...@google.com <vi...@google.com> #4
Thank you for your feedback. Team may reach out for more feedback in reproducing or triaging this issue.
hi...@digion.com <hi...@digion.com> #5
I have same issue for Japanese comment on Studio 3.5 (Androig Gradle Plugin 3.5.0).
Android Gradle Plugin 3.4.2 works successfully.
This issue occurs on Windows 10 but not on macOS 10.14.6 (or linux).
Workaround:
Add file.encoding option to gradle.property
> org.gradle.jvmargs=-Xmx1536m -Dfile.encoding=UTF-8
I think this issue was caused by following commit.
https://android.googlesource.com/platform/tools/base/+/689f1adc8b900e08306c21105208e3a4521db004
AidlCompile task seems to need an option to specify source code encoding.
Android Gradle Plugin 3.4.2 works successfully.
This issue occurs on Windows 10 but not on macOS 10.14.6 (or linux).
Workaround:
Add file.encoding option to gradle.property
> org.gradle.jvmargs=-Xmx1536m -Dfile.encoding=UTF-8
I think this issue was caused by following commit.
AidlCompile task seems to need an option to specify source code encoding.
yo...@gmail.com <yo...@gmail.com> #6
Me too,when i remove all the Chinese comments in AIDL files,it can generate java file normally.
uc...@google.com <uc...@google.com>
tn...@google.com <tn...@google.com>
je...@google.com <je...@google.com>
je...@google.com <je...@google.com> #7
Hi,
What exactly is the issue? Is it a build error?
I was able to compile a project with an aidl file with chinese comments in it just fine.
Can you please give me more information on how to reproduce this bug, specifically which steps were taken?
What exactly is the issue? Is it a build error?
I was able to compile a project with an aidl file with chinese comments in it just fine.
Can you please give me more information on how to reproduce this bug, specifically which steps were taken?
hi...@digion.com <hi...@digion.com> #8
I was able to reproduce the problem on macOS 10.14.6 and Windows 10
Sample project here.
Steps to Reproduce:
1. Open sample project on Android Studio 3.5.
for Windows: UTF8Sample
for Mac: ShifJISSample
2. Make project and confirm successfully finished.
3. Update Android Gradle Plugin to 3.5.0 (Click "Android Gradle Plugin is ready to update" link)
4. Rebuild project.
5 Build error occurred. AIDL interface stub file is not created successfully.
I think "AidlProcessor#removeOutputPathFromOutput" method occur this issue.
https://android.googlesource.com/platform/tools/base/+/689f1adc8b900e08306c21105208e3a4521db004/build-system/builder/src/main/java/com/android/builder/internal/compiler/AidlProcessor.java#88
Scanner constructer should use correct encoding option(must match Java CompileOption).
And AidlCompile task should report error and abort if Scanner throws exception.
Sample project here.
Steps to Reproduce:
1. Open sample project on Android Studio 3.5.
for Windows: UTF8Sample
for Mac: ShifJISSample
2. Make project and confirm successfully finished.
3. Update Android Gradle Plugin to 3.5.0 (Click "Android Gradle Plugin is ready to update" link)
4. Rebuild project.
5 Build error occurred. AIDL interface stub file is not created successfully.
I think "AidlProcessor#removeOutputPathFromOutput" method occur this issue.
Scanner constructer should use correct encoding option(must match Java CompileOption).
And AidlCompile task should report error and abort if Scanner throws exception.
je...@google.com <je...@google.com> #9
Thank you for the toy project. I was able to reproduce the issue and confirmed that it was caused by that method.
It was added as a temporary solution to a cacheability issue caused by aidl leaving absolute paths in comments. I think it might be time to remove it.
I will let you know once I am able to submit a solution.
It was added as a temporary solution to a cacheability issue caused by aidl leaving absolute paths in comments. I think it might be time to remove it.
I will let you know once I am able to submit a solution.
Description
AI-191.8026.42.35.5791312, JRE 1.8.0_202-release-1483-b03x64 JetBrains s.r.o, OS Windows 10(amd64) v10.0 , screens 1920x1080
AS: 3.5; Android Gradle Plugin: 3.5.0; Gradle: 5.4.1; NDK: from local.properties: 20.0.5594570, latest from SDK: 20.0.5594570; LLDB: LLDB 3.1 (revision: 3.1.4508709); CMake: from local.properties: (not specified), latest from SDK: 3.10.2, from PATH: (not found)
IMPORTANT: Please read