Fixed
Status Update
No update yet.
Comments
sm...@google.com
If you have a team of people who all work on one variant and then someone changes the default variant to something else do we really want everyone to be switched to that new default when they sync?
I feel like the default variant should only be used if the user syncs and the old variant they were on doesn't exist anymore, or first time import. But if we think it wouldn't be a problem (or it wouldn't affect many people) then I guess its something we could do.
I feel like the default variant should only be used if the user syncs and the old variant they were on doesn't exist anymore, or first time import. But if we think it wouldn't be a problem (or it wouldn't affect many people) then I guess its something we could do.
xa...@google.com
I think this is never going to work as expected for anyone. Some people would expected to work on all open, other on first import only. The only option I would see is a studio option to switch to default on project open (not just first import).
xa...@google.com
Let's discuss this for 3.7
cm...@google.com
I wonder whether marking the default variant in the variant chooser would be helpful irrespective of the other directions we choose. I agree that this is a fairly subtle UX choice, and it makes sense to park this until we have a clear direction.
vi...@google.com
xa...@google.com
How about we just have a button in the variant tool window to automatically select the default variant. This would be convenient if you have multiple modules because right now it's painful to change many modules.
so...@google.com
This can be easily implemented by including in old default variants in a sync request.
so...@google.com
je...@google.com
ga...@google.com
To clarify, there are 2 things we can do here:
- in the Build Variants tools window, in the variants dropdown next to the Gradle project name: if there is a default variant name defined for that project, indicate that in some way
- if there are default variants specified, add a button/link to the "Build Variants" tools window that re-triggers sync with default variants
Description
We now allow a default variant to be specified by the user. However this only has effect on the first import, and I wonder if when syncing if the default variant changes from what it was studio should switch to it, at least if the user is on the previous default variant, perhaps unconditionally.
What do you think? I can look at implementing this if you think this a reasonable idea.