BiometricPrompt: savedInstance and null pointer crashes [140447194]

Fixed

Bug

Status Update

No update yet.

Description

tr...@gmail.com

created issue #1

Sep 4, 2019 10:31AM

So I have recently migrated to BiometricPrompt and while testing on my personal devices I did not encounter any error, however, after deployment to the public, around 8 percent of users (2200 crashes in total, 75% of them use Android 9) experienced the following issue:

Fatal Exception: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
at androidx.fragment.app.FragmentManagerImpl.checkStateLoss + 2080(FragmentManagerImpl.java:2080)
at androidx.fragment.app.FragmentManagerImpl.enqueueAction + 2106(FragmentManagerImpl.java:2106)
at androidx.fragment.app.BackStackRecord.commitInternal + 683(BackStackRecord.java:683)
at androidx.fragment.app.BackStackRecord.commit + 637(BackStackRecord.java:637)
at androidx.fragment.app.DialogFragment.show + 144(DialogFragment.java:144)
at androidx.biometric.BiometricPrompt.authenticateInternal + 499(BiometricPrompt.java:499)
at androidx.biometric.BiometricPrompt.authenticate + 465(BiometricPrompt.java:465)

I got 500 crashes in the last 4 days containing this error (100% of devices are Android 9):

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.hardware.fingerprint.FingerprintManager.getErrorString(int, int)' on a null object reference
at android.hardware.biometrics.BiometricPrompt.lambda$sendError$0 + 490(BiometricPrompt.java:490)
at android.hardware.biometrics.-$$Lambda$BiometricPrompt$HqBGXtBUWNc-v8NoHYsj2gLfaRw.run + 6(-.java:6)
at android.os.Handler.handleCallback + 873(Handler.java:873)
at android.os.Handler.dispatchMessage + 99(Handler.java:99)
at android.os.Looper.loop + 193(Looper.java:193)
at android.app.ActivityThread.main + 6715(ActivityThread.java:6715)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run + 493(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main + 911(ZygoteInit.java:911)

And around 300 crashes (all of them are not Android 9):

Fatal Exception: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
at androidx.fragment.app.FragmentManagerImpl.checkStateLoss + 2080(FragmentManagerImpl.java:2080)
at androidx.fragment.app.FragmentManagerImpl.enqueueAction + 2106(FragmentManagerImpl.java:2106)
at androidx.fragment.app.BackStackRecord.commitInternal + 683(BackStackRecord.java:683)
at androidx.fragment.app.BackStackRecord.commit + 637(BackStackRecord.java:637)
at androidx.fragment.app.DialogFragment.dismissInternal + 224(DialogFragment.java:224)
at androidx.fragment.app.DialogFragment.dismiss + 191(DialogFragment.java:191)
at androidx.biometric.FingerprintDialogFragment.handleDismissDialogError + 367(FingerprintDialogFragment.java:367)
at androidx.biometric.FingerprintDialogFragment$H.handleMessage + 102(FingerprintDialogFragment.java:102)
at android.os.Handler.dispatchMessage + 105(Handler.java:105)
at android.os.Looper.loop + 164(Looper.java:164)
at android.app.ActivityThread.main + 6942(ActivityThread.java:6942)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run + 327(Zygote.java:327)
at com.android.internal.os.ZygoteInit.main + 1374(ZygoteInit.java:1374)

I am not doing anything specific, just calling authenticate onAttach and that's it. This is very annoying, I needed to revert the update and rollback to the old authentication method.

Comments

tr...@gmail.com <tr...@gmail.com> #2Sep 4, 2019 10:39AM

Project: platform/frameworks/support
Branch: androidx-main

commit 32e15d7e6a58276987c27730dcc01ecfb950d2db
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Mar 28 11:07:46 2024

Convert `lifecycle-runtime-compose` to multiplatform

* Only platforms supported by Compose in the AndroidX repository will be supported by `lifecycle-runtime-compose` (`android`, `desktop`).
* That is equivalent to what has been done with other artifacts, such as `lifecycle-viewmodel-compose`.
* Credits to Jake Wharton for the original contribution, his CL can be found at aosp/3002225

Test: `gw -p lifecycle bOS`
RelNote: "Added multiplatform support for `lifecycle-runtime-compose`."
Bug: 331769623
Change-Id: I4f4a03613120f3222bd44ae1feab1a085ddb38da

M docs-tip-of-tree/build.gradle
M lifecycle/lifecycle-runtime-compose/build.gradle
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/CollectAsStateWithLifecycleTests.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/DropUnlessLifecycleTest.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleEffectTest.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleExtTest.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/DropUnlessLifecycle.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/FlowExt.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleEffect.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleExt.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LocalLifecycleOwner.kt

https://android-review.googlesource.com/3017203

ga...@gtempaccount.com <ga...@gtempaccount.com> #3Sep 10, 2019 08:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit 195d70fcd1b8d7dea6820e1795584e29e7535c84
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Mar 28 11:14:40 2024

Add `lifecycle-runtime-ktx` in `lifecycle-runtime-compose`

* Constraints do not apply to project dependencies, causing `wear:compose:demos` to fail due to a transitive dependency on an older ``-ktx` library. This results in duplicate definitions.
* Workaround: Added a direct dependency on `lifecycle-runtime-ktx`. Although this artifact is empty, it ensures that upgrading `lifecycle-runtime-compose` also updates `lifecycle-runtime-ktx` in cases where our constraints fail (e.g., internally in AndroidX when using project dependencies).

Test: `./gradlew :wear:compose:integration-tests:demos:dataBindingMergeDependencyArtifactsDebugAndroidTest`
Test: `./gradlew :compose:ui:ui-test:compileDebugKotlinAndroid`
Bug: 331769623
Change-Id: I8e79f3d5a7b6586dac65ae4c7d3868d9518ee585

M lifecycle/lifecycle-runtime-compose/build.gradle

https://android-review.googlesource.com/3017204

kc...@google.com <kc...@google.com> #4Sep 10, 2019 08:57PM

Project: platform/frameworks/support
Branch: androidx-main

commit 49455ad0e53fd704ca5a3c56d5b621f666d3d7b9
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Mar 29 14:38:40 2024

Fix corrupt serialized resolution result in `compose-ui`

* `compose-ui` has a transitive dependency on `lifecycle-livedata-core`, and converting `lifecycle-runtime-compose` to KMP triggered a Gradle bug (

https://github.com/gradle/gradle/issues/14220).
* Directly adding `lifecycle-livedata-core` as `compileOnly` to `androidMain` allowed us to workaround the issue.

Test: `./gradlew :compose:ui:ui:compileCommonMainKotlinMetadata -Pandroidx.constraints=true`
Bug: 331769623
Change-Id: I463276189cf90cfca8efc46bb29ecbb64010e09e

M compose/ui/ui/build.gradle

https://android-review.googlesource.com/3020183

kc...@google.com <kc...@google.com> Sep 11, 2019 10:12PM

Reassigned to tr...@gmail.com.

ga...@gtempaccount.com <ga...@gtempaccount.com> #5Sep 12, 2019 05:50AM

Project: platform/frameworks/support
Branch: androidx-main

commit e48e6e2ce836e4e76a4bb6abe912520282fccf75
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Mar 29 17:03:31 2024

Add `lifecycle-runtime-ktx` in `lifecycle-runtime-compose`

* Constraints do not apply to project dependencies, causing `wear:compose:demos` to fail due to a transitive dependency on an older ``-ktx` library. This results in duplicate definitions.
* Workaround: Added a direct dependency on `lifecycle-runtime-ktx`. Although this artifact is empty, it ensures that upgrading `lifecycle-runtime-compose` also updates `lifecycle-runtime-ktx` in cases where our constraints fail (e.g., internally in AndroidX when using project dependencies).

Test: `./gradlew :wear:compose:integration-tests:demos:dataBindingMergeDependencyArtifactsDebugAndroidTest`
Test: `./gradlew :compose:ui:ui-test:compileDebugKotlinAndroid`
Bug: 331769623
Change-Id: I5599212b8a2dbd83189886a2435068b7b4aa5e1c

M lifecycle/lifecycle-runtime-compose/build.gradle

https://android-review.googlesource.com/3020185

kc...@google.com <kc...@google.com> #6Sep 12, 2019 06:12AM

Reassigned to cu...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 54cd4ca56376ad93a8001d520000418cb8c63142
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Mar 29 16:37:58 2024

Fix corrupt serialized resolution result in `compose-ui`

* `compose-ui` has a transitive dependency on `lifecycle-viewmodel-savedstate`, and converting `lifecycle-runtime-compose` to KMP triggered a Gradle bug (

https://github.com/gradle/gradle/issues/14220). Adding the `livedata` dependency directly works around the issue.
* Directly adding `lifecycle-viewmodel-savedstate` as `compileOnly` to `androidMain` allowed us to workaround the issue.

Test: `./gradlew :compose:ui:ui:compileCommonMainKotlinMetadata -Pandroidx.constraints=true`
Bug: 331769623
Change-Id: Ic4f81fe2737b3d61fd9b4cb02a8b940e3a0d4caf

M compose/ui/ui/build.gradle

https://android-review.googlesource.com/3020064

kc...@google.com <kc...@google.com> #7Sep 12, 2019 06:22AM

Project: platform/frameworks/support
Branch: androidx-main

commit 91927fb2609683bcd11db90d4b5bf77ebbb6cf5a
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Mar 29 17:03:00 2024

Convert `lifecycle-runtime-compose` to multiplatform

* Only platforms supported by Compose in the AndroidX repository will be supported by `lifecycle-runtime-compose` (`android`, `desktop`).
* That is equivalent to what has been done with other artifacts, such as `lifecycle-viewmodel-compose`.
* Credits to Jake Wharton for the original contribution, his CL can be found at aosp/3002225

Test: `gw -p lifecycle bOS`
RelNote: "Added multiplatform support for `lifecycle-runtime-compose`."
Bug: 331769623
Change-Id: If7a714e598e360a1960f8b3a673b33538f595ff4

M docs-tip-of-tree/build.gradle
M lifecycle/lifecycle-runtime-compose/build.gradle
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/CollectAsStateWithLifecycleTests.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/DropUnlessLifecycleTest.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleEffectTest.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleExtTest.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/DropUnlessLifecycle.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/FlowExt.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleEffect.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleExt.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LocalLifecycleOwner.kt

https://android-review.googlesource.com/3020184

cu...@google.com <cu...@google.com> Sep 17, 2019 10:36PM

Accepted by cu...@google.com.

ap...@google.com <ap...@google.com> #8Sep 17, 2019 11:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.7.0-alpha07
androidx.compose.ui:ui-android:1.7.0-alpha07
androidx.compose.ui:ui-desktop:1.7.0-alpha07
androidx.lifecycle:lifecycle-runtime-compose:2.8.0-beta01

ga...@gtempaccount.com <ga...@gtempaccount.com> #9Sep 19, 2019 11:08PM

are these fixes released in beta02?

cu...@google.com <cu...@google.com> #10Sep 25, 2019 10:55PM

Marked as fixed.

> are these fixes released in beta02?

Unfortunately no, but fixes for (1) and (3) from

comment #2

will be in rc01, which should be released very soon. :-)

As kchyn@google.com said, an app-side solution is probably most appropriate for (2).

tr...@gmail.com <tr...@gmail.com> #11Sep 26, 2019 03:16AM

I did use alpha version first and then upgraded to beta-02 and I had the same issues.
Unfortunately at the moment I can't use this library until the state errors will be fixed, so I use my own solution as a workaround.

kc...@google.com <kc...@google.com> #12Sep 26, 2019 04:07AM

Sit tight, rc01, which contains the fixes for 1 and 3 is coming in before the end of next week.