Allow showing icons on PopupMenu [141197721]

Duplicate

of 182789798

Feature Request

Status Update

No update yet.

Description

ol...@myscript.com

created issue #1

Sep 18, 2019 05:59PM

The always accepted answer to this request is to use PopupMenuHelper which is a RestrictedApi

See

https://gist.github.com/aritraroy/6b69ac91f9db6dc1f74c3ebc5cefa483

Moreover, on ChromeOS, when opening a menu and then resizing the Windows, the PopupMenu remains open after the configuration change despite PopupMenu.dismiss() being called in onStop().
When using standard PopupMenu.show() + PopupMenu.dismiss(), it works. Go figure out…

That being said, I don't see any reason to disallow showing icons on such menu using a public API.
Moreover, submenus of PopupMenu DO show such icons (because internally Android uses PopupMenuHelper…).

I'd like an API on PopupMenu like setForceShowIcon or whatever.

Comments

ad...@google.com <ad...@google.com> #2Sep 20, 2019 11:32AM

Assigned to ki...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit b93b6044308aafa2361f69fe55cd24dbf7b016e6
Author: elifbilgin <elifbilgin@google.com>
Date: Wed Aug 02 08:14:41 2023

Converting `room-common` build files to be AndroidX Multiplatform.

Bug: 299168035
Test: Existing tests
Change-Id: I2b0c00a0d978b45745bf7e94628e2b1ebc6cb66e

M room/room-common/build.gradle
M room/room-common/src/commonMain/kotlin/androidx/room/AmbiguousColumnResolver.kt
M room/room-common/src/commonMain/kotlin/androidx/room/AutoMigration.kt
M room/room-common/src/commonMain/kotlin/androidx/room/BuiltInTypeConverters.kt
M room/room-common/src/commonMain/kotlin/androidx/room/ColumnInfo.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Dao.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Database.kt
M room/room-common/src/commonMain/kotlin/androidx/room/DatabaseView.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Delete.kt
M room/room-common/src/commonMain/kotlin/androidx/room/DeleteColumn.kt
M room/room-common/src/commonMain/kotlin/androidx/room/DeleteTable.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Embedded.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Entity.kt
M room/room-common/src/commonMain/kotlin/androidx/room/ForeignKey.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Fts3.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Fts4.kt
M room/room-common/src/commonMain/kotlin/androidx/room/FtsOptions.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Ignore.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Index.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Insert.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Junction.kt
M room/room-common/src/commonMain/kotlin/androidx/room/MapColumn.kt
M room/room-common/src/commonMain/kotlin/androidx/room/MapInfo.kt
M room/room-common/src/commonMain/kotlin/androidx/room/OnConflictStrategy.kt
M room/room-common/src/commonMain/kotlin/androidx/room/PrimaryKey.kt
M room/room-common/src/commonMain/kotlin/androidx/room/ProvidedAutoMigrationSpec.kt
M room/room-common/src/commonMain/kotlin/androidx/room/ProvidedTypeConverter.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Query.kt
M room/room-common/src/commonMain/kotlin/androidx/room/RawQuery.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Relation.kt
M room/room-common/src/commonMain/kotlin/androidx/room/RenameColumn.kt
M room/room-common/src/commonMain/kotlin/androidx/room/RenameTable.kt
M room/room-common/src/commonMain/kotlin/androidx/room/RewriteQueriesToDropUnusedColumns.kt
M room/room-common/src/commonMain/kotlin/androidx/room/RoomMasterTable.kt
M room/room-common/src/commonMain/kotlin/androidx/room/RoomWarnings.kt
M room/room-common/src/commonMain/kotlin/androidx/room/SkipQueryVerification.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Transaction.kt
M room/room-common/src/commonMain/kotlin/androidx/room/TypeConverter.kt
M room/room-common/src/commonMain/kotlin/androidx/room/TypeConverters.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Update.kt
M room/room-common/src/commonMain/kotlin/androidx/room/Upsert.kt
M room/room-common/src/commonTest/kotlin/androidx/room/AmbiguousColumnResolverTest.kt
M room/room-common/src/commonTest/kotlin/androidx/room/AnnotationRetentionPolicyTest.kt
M settings.gradle

https://android-review.googlesource.com/2689826

al...@gmail.com <al...@gmail.com> #3Oct 2, 2019 08:59PM

Project: platform/frameworks/support
Branch: androidx-main

commit cd4f81b707004c84a0a31117bffec06ab22dd624
Author: elifbilgin <elifbilgin@google.com>
Date: Tue Nov 28 14:31:43 2023

Adding KMP to room-compiler and room-migration.

Bug: 299168035
Test: ./gradlew bOS
Change-Id: Ic7f785f26007dbc6a1b2d4d9430e889195debd4a

M settings.gradle

https://android-review.googlesource.com/2850372

ki...@google.com <ki...@google.com> Nov 14, 2019 02:39AM

Reassigned to ob...@google.com.

ob...@google.com <ob...@google.com> Mar 10, 2020 05:02PM

Reassigned to ki...@google.com.

ki...@google.com <ki...@google.com> Dec 14, 2020 04:16PM

Reassigned to al...@google.com.

al...@google.com <al...@google.com> Mar 17, 2021 02:55PM

Status: Duplicate of

182789798

Issue 141197721