"Remove Unused Resources" for view binding missed method reference syntax (e.g. `LayoutBinding::inflate`) [142004503]

Fixed

Bug

Reviewed (L1)

Status Update

No update yet.

Description

th...@gmail.com

created issue #1

Oct 3, 2019 11:10AM

Studio Build: 3.6 Canary 12
Version of Gradle Plugin: 3.6.0-alpha12
Version of Gradle: 5.6.2
Version of Java: 1.8.0_212
OS: Windows / macOS

Steps to Reproduce:
1. Enable view binding and reference layout files with new static binding classes
2. Run "Refactor>Remove Unused Resources"

Comments

uc...@google.com <uc...@google.com> #2Oct 3, 2019 08:49PM

Assigned to th...@gmail.com.

Can you please help share a sample project to reproduce this issue.

th...@gmail.com <th...@gmail.com> #3Oct 10, 2019 11:01PM

Sure, you can check out one of my side projects to reproduce this issue (still facing this with 3.6 beta01):

https://github.com/G00fY2/DeveloperWidget

unused_issue.PNG

49 KB

View

Download

uc...@google.com <uc...@google.com> Oct 14, 2019 10:24PM

Reassigned to rp...@google.com.

th...@gmail.com <th...@gmail.com> #4Apr 23, 2020 06:23PM

Any news about this issue? Still happening in Android Studio 3.6.3 and 4.1 Canary 6.

We use ViewBinding in more and more places and lint keeps reporting unused resources for every file referenced via ViewBinding.

Message last modified on May 26, 2020 08:48PM

es...@google.com <es...@google.com> Apr 29, 2020 06:11PM

Reassigned to an...@google.com.

di...@google.com <di...@google.com> May 5, 2020 02:56PM

Reassigned to lu...@google.com.

da...@google.com <da...@google.com> May 5, 2020 03:49PM

Accepted by da...@google.com.

da...@google.com <da...@google.com> #5May 6, 2020 04:09PM

https://issuetracker.google.com/155685117 has super simple repro steps.

da...@google.com <da...@google.com> #6May 6, 2020 11:30PM

Now that I've been able to look a little closer, I see what's going on. Our lint solution (at least for view binding) handles LayoutBinding.inflate but not LayoutBinding::inflate

I'll look into fixing this ASAP but it probably won't land until 4.1

Until then, a workaround could be to change lines like this:

  override val binding: ActivityAboutBinding by viewBinding(ActivityAboutBinding::inflate)

into:

  override val binding: ActivityAboutBinding by viewBinding { ActivityAboutBinding.inflate(it) }

da...@google.com <da...@google.com> #7May 11, 2020 05:44PM

Marked as fixed.

This fix will land in 4.1 Canary 11. Until then, the only thing I can think to suggest is the workaround in comment #6.

be...@crisalid.com <be...@crisalid.com> #8Jun 9, 2020 11:33AM

The workaround from

comment #6

work for drawables/colors/strings... but not for "@+id". Does your changes fix this too?

da...@google.com <da...@google.com> #9Jun 9, 2020 04:17PM

Comment #8, can you share repro steps or a repro project? Otherwise, I'm not sure what case you're referring to.

ce...@gmail.com <ce...@gmail.com> #10Jan 5, 2021 11:42AM

The issue is not fixed in Android Gradle Plugin 4.1.1. Example project here -> https://github.com/francescocervone/ViewBindingUnusedResourcesIssue

da...@google.com <da...@google.com> #11Jan 23, 2021 12:07AM

Hey comment #10, I also pinged you on another bug, but can you try a more recent version of AGP? (4.2+ or 7.0.0+)

ce...@gmail.com <ce...@gmail.com> #12Mar 17, 2021 08:31AM

I'm sorry, for some reason I didn't receive any notification about your comment.

Tried with AGP 4.2-beta06 and issue is fixed.

da...@google.com <da...@google.com> #13Mar 17, 2021 06:36PM

No worries, thanks for the confirmation!