cannot generate view binders java.lang.StackOverflowError [144604674]

Fixed

Bug

NeedsInfo

Reviewed (L1)

Status Update

No update yet.

Description

la...@gmail.com

created issue #1

Nov 18, 2019 03:26AM

cannot generate view binders java.lang.StackOverflowError
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:209)
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:211)
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:211)
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:211)
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:211)
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:211)

after i update android studio from 3.5.1 to 3.5.2 ,i get this build exception,but it works fine for me with 3.5.1

Comments

vi...@google.com <vi...@google.com> #2Nov 19, 2019 08:59AM

Assigned to la...@gmail.com.

Can you please describe your issue in more detail?Also please provide steps to reproduce the issue.Thank you!

la...@gmail.com <la...@gmail.com> #3Nov 21, 2019 01:21AM

I've fixed this issue by myself,which caused by calling "get()" method of ObservableField in databinding xml

da...@google.com <da...@google.com> #4Nov 21, 2019 02:39AM

Yigit, I thought I saw this bug before (

https://issuetracker.google.com/140999936) but this seems to have a different callstack. I couldn't find any other bugs with "resolveListeners" in their body.

comment #3

, adding "get()" is probably the wrong workaround :/ I think it will get underlined as an error starting in Studio 4.0. Are you using generics in any of your <variable> types?

yb...@google.com <yb...@google.com> #5Nov 21, 2019 05:22AM

Reassigned to yb...@google.com.

I think comment mentions removing #get fixes the issue which seems to be the right thing to do.
That being said, data binding shouldn't crash when get is used, I'll have to look into it to figure out what is going on.

ya...@gmail.com <ya...@gmail.com> #6Dec 4, 2019 11:56AM

The same issue here.
DataBinding is crashing while trying to invoke ObservableField.get() from xml. Luckily, removing of .get() safely resolves the issue (.get() is still invoked in the generated code which is what we want).

The worst thing here is that it's almost impossible to figure out the source of the crash from the stacktrace.

da...@google.com <da...@google.com> #7Dec 4, 2019 05:40PM

At this point we should probably just make it a compile error to call get within the xml? Since, starting in 4.0, it will get underlined as an error in the IDE.

yb...@google.com <yb...@google.com> #8Dec 9, 2019 09:23PM

I created a CL that'll ban this.

yb...@google.com <yb...@google.com> #9Dec 11, 2019 01:34AM

Marked as fixed.

merged the CL that'll disallow observable#get and liveData#getValue methods.
closing this as it should help developer catch these mistakes early.