Enable instrumentation tests for apps using dynamic feature modules [145191501]

Fixed

Feature Request

Reviewed (L1)

Status Update

No update yet.

Description

be...@google.com

created issue #1

Nov 26, 2019 12:08PM

Currently instrumentation tests have to be run using `./gradlew connectedAndroidTest --no-parallel` from the command line.
There is no simple way of running all tests within Studio.

Steps to Reproduce:
1. Clone

github.com/android/plaid.
2. Try to run all instrumentation tests from Studio

Comments

uc...@google.com <uc...@google.com> Nov 26, 2019 07:10PM

Assigned to ar...@google.com.

[Deleted User] <[Deleted User]> #2Nov 27, 2019 10:27AM

This issue is preventing us to properly run and debug androidTest tests locally, reducing the quality of our app.

sm...@sofi.org <sm...@sofi.org> #3Jan 9, 2020 08:46PM

this is super important for us at SoFi, please prioritize the fix.

be...@google.com <be...@google.com> #4Jan 20, 2020 10:36AM

The tests should be able to be run from command line as described in the original issue description until this feature is added to Android Studio.

[Deleted User] <[Deleted User]> #5Jan 23, 2020 11:14AM

on Android Studio we're able to run tests that launch activities/other code in other feature modules - but from command line it's not clear what exact command should be run

be...@google.com <be...@google.com> #6Jan 23, 2020 11:21AM

Have you tried the command mentioned in comment #1?

[Deleted User] <[Deleted User]> #7Jan 23, 2020 05:34PM

it runs fine using the command line option, but we are not able to debug them since android studio doesn't work.

do...@revelo.com <do...@revelo.com> #8Feb 18, 2020 08:17PM

I'm trying to create instrumented tests inside the dynamic feature modules by testing each fragment but it couldn't find any tests at all. I've added the runner configuration on the build.gradle file, imported every androidx test library available but it didn't work either. Do you have any example on this?

be...@google.com <be...@google.com> #9Feb 19, 2020 05:46PM

There was an issue with Android Studio that has been fixed and will likely land in 4.0-beta02.

[Deleted User] <[Deleted User]> #10Feb 21, 2020 08:50PM

Very annoying issue for us at Evite. Please patch this in 3.6.

mi...@tabian.ca <mi...@tabian.ca> #11Apr 15, 2020 04:37PM

I don't know how Dynamic Feature Modules could be considered "production ready" if you can't write UI tests.

be...@google.com <be...@google.com> #12Apr 15, 2020 04:40PM

We have been tracking this internally.
4.0-beta02 is capable of running instrumentation tests within dynamic-feature-modules.
There was a regression in one of the 4.1 canary builds which since has been fixed.

sm...@sofi.org <sm...@sofi.org> #13Apr 16, 2020 04:19PM

This is still an issue in canary 5 for me

linking error.png

52 KB

View

Download

Thu Apr 16 2020 09:18:48 GMT-0700 (Pacific Daylight Time).png

25 KB

View

Download

be...@google.com <be...@google.com> #14Apr 16, 2020 04:28PM

I just double checked and it should be included in canary 6.

sm...@sofi.org <sm...@sofi.org> #15Apr 16, 2020 04:29PM

Cool. When will it be available for us?

On Thu, Apr 16, 2020, 9:28 AM <buganizer-system@google.com> wrote:

- Show quoted text -

--

The information contained in this email message is PRIVATE and intended
only for the personal and confidential use of the recipient named above. If
the reader of this message is not the intended recipient or an agent
responsible for delivering it to the intended recipient, you are hereby
notified that you have received this message in error and that any review,
dissemination, distribution or copying of this message is strictly
prohibited. If you have received this communication in error, please
notify us immediately by email, and delete the original message.

be...@google.com <be...@google.com> #16Apr 16, 2020 04:33PM

Current version is Canary 5. So with the next release. For immediate availability you can downgrade to the 4.0 beta until the next canary release.

mi...@tabian.ca <mi...@tabian.ca> #17Apr 16, 2020 06:03PM

This all sounds great thanks

sm...@sofi.org <sm...@sofi.org> #18Apr 16, 2020 06:34PM

I also tried with AS 4.0 Beta 4

Android Studio 4.0 Beta 4
Build #AI-193.6911.18.40.6348893, built on March 30, 2020
Runtime version: 1.8.0_242-release-1644-b3-6222593 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.14.6
GC: ParNew, ConcurrentMarkSweep
Memory: 1237M
Cores: 12
Registry: ide.new.welcome.screen.force=true
Non-Bundled Plugins: BashSupport, IdeaVIM, mobi.hsz.idea.gitignore, ru.trylogic.idea.gitlab.integration

Still the same problem.

be...@google.com <be...@google.com> #19Apr 16, 2020 07:54PM

Please verify that ./gradlew cAT fails for your configuration on the official sample.

mi...@tabian.ca <mi...@tabian.ca> #20Apr 20, 2020 05:03PM

I just tried with Android Studio 4.0 Beta 4 and I get "No test were found".

What do you need from me?

I have attached my AS version information.
I ran ./gradlew cAT as you said above (not sure if that is what you want) and have attached the stack trace. Note that before I removed the Leak Canary dependency I also got many errors related to that.

Here is the repo I'm testing on: https://github.com/mitchtabian/Clean-Notes/tree/no-tests-found. no-tests-found branch.

UI tests are in notes module.

as version.png

32 KB

View

Download

trace

3 KB

Download

al...@google.com <al...@google.com> #21May 11, 2020 02:25PM

AndroidX team is now getting "Running Instrumented Tests for Dynamic Features is currently not supported on API < 21" in Beta 4 when running non-dynamic feature test suites, so it seems like we've taken one step back with whatever added the check.

Edit: Looks like this was filed already as b/146447085. I'll go complain there. :)

Message last modified on May 11, 2020 02:26PM

be...@google.com <be...@google.com> #22May 11, 2020 02:35PM

#20: Can you please test this on the official sample and confirm the issue persists on Beta 5?

#21: I'll follow you over to the other bug to investigate.

ad...@google.com <ad...@google.com> Feb 28, 2022 11:37PM

Status: New

ya...@google.com <ya...@google.com> Oct 25, 2022 12:01AM

Assigned to ya...@google.com.

ya...@google.com <ya...@google.com> Dec 13, 2022 01:21AM

Marked as fixed.

Issue 145191501

Description

Issue summary

Comments

uc...@google.com <uc...@google.com> Nov 26, 2019 07:10PM

[Deleted User] <[Deleted User]> #2Nov 27, 2019 10:27AM

sm...@sofi.org <sm...@sofi.org> #3Jan 9, 2020 08:46PM

be...@google.com <be...@google.com> #4Jan 20, 2020 10:36AM

[Deleted User] <[Deleted User]> #5Jan 23, 2020 11:14AM

be...@google.com <be...@google.com> #6Jan 23, 2020 11:21AM

[Deleted User] <[Deleted User]> #7Jan 23, 2020 05:34PM

do...@revelo.com <do...@revelo.com> #8Feb 18, 2020 08:17PM

be...@google.com <be...@google.com> #9Feb 19, 2020 05:46PM

[Deleted User] <[Deleted User]> #10Feb 21, 2020 08:50PM

mi...@tabian.ca <mi...@tabian.ca> #11Apr 15, 2020 04:37PM

be...@google.com <be...@google.com> #12Apr 15, 2020 04:40PM

sm...@sofi.org <sm...@sofi.org> #13Apr 16, 2020 04:19PM

be...@google.com <be...@google.com> #14Apr 16, 2020 04:28PM

sm...@sofi.org <sm...@sofi.org> #15Apr 16, 2020 04:29PM

be...@google.com <be...@google.com> #16Apr 16, 2020 04:33PM

mi...@tabian.ca <mi...@tabian.ca> #17Apr 16, 2020 06:03PM

sm...@sofi.org <sm...@sofi.org> #18Apr 16, 2020 06:34PM

be...@google.com <be...@google.com> #19Apr 16, 2020 07:54PM

mi...@tabian.ca <mi...@tabian.ca> #20Apr 20, 2020 05:03PM

al...@google.com <al...@google.com> #21May 11, 2020 02:25PM

be...@google.com <be...@google.com> #22May 11, 2020 02:35PM

ad...@google.com <ad...@google.com> Feb 28, 2022 11:37PM

ya...@google.com <ya...@google.com> Oct 25, 2022 12:01AM

ya...@google.com <ya...@google.com> Dec 13, 2022 01:21AM

Add comment

Issue metadata