Bug: never ending loading of Strings translation tool [145436360]

Fixed

Bug

Reviewed (L1)

Status Update

No update yet.

Description

lb...@gmail.com

created issue #1

Dec 1, 2019 09:44AM

Studio Build:
Version of Gradle Plugin:
Version of Gradle:
Version of Java:
OS:
Android Studio 4.0 Canary 4
Build #AI-192.6817.14.36.6008643, built on November 14, 2019
Runtime version: 1.8.0_212-release-1586-b04 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
GC: ParNew, ConcurrentMarkSweep
Memory: 7916M
Cores: 12
Registry: ide.new.welcome.screen.force=true
Non-Bundled Plugins: String Manipulation, com.github.novotnyr.gitlab-quickmr-idea-plugin, ignaciotcrespo.github.com.vector-drawable-thumbnails, com.mistamek.drawablepreview.drawable-preview

Steps to Reproduce:
1. Open strings file and go to translation tool.

The bug:
It never stops loading.

Attached video to show how long I can wait for this (and it never finished after the video, of course).

2019-12-01_11-40-56.mp4

1.6 MB

Download

idea.log

1.9 MB

View

Download

Comments

ju...@google.com <ju...@google.com> Dec 1, 2019 09:29PM

Assigned to ju...@google.com.

vi...@google.com <vi...@google.com> #2Dec 2, 2019 06:39AM

Reassigned to lb...@gmail.com.

Can you please help capture and share the thread dumps if this issue reproduces again?
Steps to capture the thread dumps are listed at

https://developer.android.com/studio/report-bugs#thread-dump

lb...@gmail.com <lb...@gmail.com> #3Dec 2, 2019 07:53AM

@2 It always occurs, but only on canary. on stable it works fine (except freezing for some time).

As for running the command, attached.

dump.7z

4 KB

Download

vi...@google.com <vi...@google.com> #4Dec 2, 2019 11:03AM

Reassigned to rp...@google.com.

Thank you for your feedback. Team may reach out for more feedback in reproducing or triaging this issue.

ju...@google.com <ju...@google.com> Dec 2, 2019 11:42AM

Reassigned to ju...@google.com.

lb...@gmail.com <lb...@gmail.com> #5Dec 3, 2019 08:04AM

@4 When I open the tool, the IDE actually shows an error at the bottom.
See attached.

This is what it says:

java.lang.AssertionError: class com.android.tools.idea.resources.base.BasicValueResourceItem
at com.android.tools.idea.editors.strings.StringResource.<init>(StringResource.java:68)
at com.android.tools.idea.editors.strings.StringResourceData.lambda$create$0(StringResourceData.java:64)
at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at com.google.common.collect.CollectSpliterators$1WithCharacteristics.lambda$forEachRemaining$1(CollectSpliterators.java:64)
at java.util.stream.Streams$RangeIntSpliterator.forEachRemaining(Streams.java:110)
at com.google.common.collect.CollectSpliterators$1WithCharacteristics.forEachRemaining(CollectSpliterators.java:64)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
at java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:270)
at java.util.Iterator.forEachRemaining(Iterator.java:116)
at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
at java.util.stream.StreamSpliterators$WrappingSpliterator.forEachRemaining(StreamSpliterators.java:312)
at java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:742)
at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:580)
at com.android.tools.idea.editors.strings.StringResourceData.create(StringResourceData.java:64)
at com.android.tools.idea.editors.strings.table.StringResourceTableModel.<init>(StringResourceTableModel.java:56)
at com.android.tools.idea.editors.strings.ResourceLoadingTask.onSuccess(ResourceLoadingTask.java:59)
at com.intellij.openapi.progress.impl.CoreProgressManager.finishTask(CoreProgressManager.java:507)
at com.intellij.openapi.progress.impl.CoreProgressManager$4.lambda$run$0(CoreProgressManager.java:426)
at com.intellij.openapi.application.TransactionGuardImpl$2.run(TransactionGuardImpl.java:312)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.doRun(LaterInvocator.java:433)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.runNextEvent(LaterInvocator.java:416)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:399)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:764)
at java.awt.EventQueue.access$500(EventQueue.java:98)
at java.awt.EventQueue$3.run(EventQueue.java:715)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:734)
at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:824)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:773)
at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$8(IdeEventQueue.java:412)
at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:704)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:411)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

2019-12-03_10-04-31.png

100 KB

View

Download

ju...@google.com <ju...@google.com> #6Dec 13, 2019 10:43PM

Is there anything atypical about your string resources? If you can send me your string resource files that would help immensely.

lb...@gmail.com <lb...@gmail.com> #7Dec 14, 2019 01:21PM

@6 Since this is a project that's not open sourced and is of the company, I can send you only privately.
Please email me so that I can email you.

nd...@gmail.com <nd...@gmail.com> #8Dec 19, 2019 10:38AM

I have the same problem with Canary 6 with the same AssertionError shown above, I can provide more info if needed

Android Studio 4.0 Canary 6
Build #AI-193.2956.37.40.6052267, built on December 5, 2019
Runtime version: 1.8.0_212-release-1586-b4-5784211 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.14.2
GC: ParNew, ConcurrentMarkSweep
Memory: 1979M
Cores: 12
Registry: ide.new.welcome.screen.force=true
Non-Bundled Plugins:

ng...@gmail.com <ng...@gmail.com> #9Apr 4, 2020 12:31PM

I got the same issue on Android Studio 4 beta 3. (Mac OS 10.15.3).

ju...@google.com <ju...@google.com> Apr 8, 2020 08:22PM

Accepted by ju...@google.com.

ju...@google.com <ju...@google.com> #10Apr 8, 2020 10:58PM

Marked as fixed.

I downgraded the assertion failure to a logger warning. Unfortunately the change didn't cherry pick cleanly into 4.0. Fortunately assertions will be disabled in the RCs.

I still don't know why we're getting BasicValueResourceItems out of the resource folder repositories in the first place. I filed https://issuetracker.google.com/153587640 to track that.

A minimal reproducible test case would help us out immensely

lb...@gmail.com <lb...@gmail.com> #11Apr 9, 2020 08:17AM

@10 When was it fixed? I can still see it. It never finishes to load.

Android Studio 4.1 Canary 4
Build #AI-193.6494.35.41.6325121, built on March 24, 2020
Runtime version: 1.8.0_242-release-1644-b01 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
GC: ParNew, ConcurrentMarkSweep
Memory: 1970M
Cores: 12
Registry: ide.new.welcome.screen.force=true, debugger.watches.in.variables=false
Non-Bundled Plugins: String Manipulation, org.jetbrains.kotlin, ignaciotcrespo.github.com.vector-drawable-thumbnails, org.intellij.plugins.markdown

ju...@google.com <ju...@google.com> #12Apr 9, 2020 03:17PM

Expect the fix in 4.1 Canary 6

lb...@gmail.com <lb...@gmail.com> #13Apr 9, 2020 05:38PM

@12
:(

ju...@google.com <ju...@google.com> #14Apr 9, 2020 05:54PM

I honestly don't know if this will work but you can try disabling assertions for the responsible class in the meantime. From the Welcome to Android Studio window:

Configure - Edit Custom VM Options...

and add

-da:com.android.tools.idea.editors.strings.StringResource

Let us know if that works

lb...@gmail.com <lb...@gmail.com> #15Apr 11, 2020 10:04PM

You mean "help"-> "Edit Custom VM Options"
Anyway, added this, it got fixed.

What does it do? Why isn't it working by default?

ju...@google.com <ju...@google.com> #16Apr 11, 2020 10:15PM

That option disables a failing assertion in com.android.tools.idea.editors.strings.StringResource. https://b.corp.google.com/issues/153587640 tracks why that assertion is failing in the first place. Without the fix to 153587640 the translations editor will get resource items that are slower to inspect (and if you have a lot of them they can slow it down a lot) but it should still work.

In Canary 6 you can get rid of that custom option because I downgraded the assertion to a log warning

Message last modified on Apr 11, 2020 10:16PM

lb...@gmail.com <lb...@gmail.com> #17Apr 11, 2020 10:42PM

@16 what is the warning exactly ? Why is it so slow?

ju...@google.com <ju...@google.com> #18Apr 13, 2020 08:55PM

https://android.googlesource.com/platform/tools/adt/idea/+/73dc8944b3f4c032303ae5c2a2b4cebbc6e8f6b0

PsiResourceItems are postparse representations of XML. BasicValueResourceItems are not. It's faster to access XML semantics from a postparse abstraction.

lb...@gmail.com <lb...@gmail.com> #19Apr 14, 2020 07:14AM

@18 Ok I don't understand this.
Keep the good work !
:)

ju...@google.com <ju...@google.com> #20Apr 14, 2020 05:17PM

Thank you for all the bug reports!

mr...@gmail.com <mr...@gmail.com> #21Jul 14, 2020 11:52AM

I am facing the same issue here Android Studio 4.1 Canary 2.

ow...@gmail.com <ow...@gmail.com> #22Sep 11, 2020 01:58PM

the same issue
Android Studio 4.0.1
Build #AI-193.6911.18.40.6626763, built on June 25, 2020
Runtime version: 1.8.0_242-release-1644-b3-6222593 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.15.6
GC: ParNew, ConcurrentMarkSweep
Memory: 2014M
Cores: 4
Registry: ide.new.welcome.screen.force=true, debugger.watches.in.variables=false
Non-Bundled Plugins: com.siimkinks.sqlitemagic

sm...@gmail.com <sm...@gmail.com> #23Oct 7, 2020 12:53PM

the same on 4.0.2

-da:com.android.tools.idea.editors.strings.StringResource

didn't work

Message last modified on Oct 7, 2020 12:55PM

st...@gmail.com <st...@gmail.com> #24Oct 7, 2020 01:59PM

Be sure to check the file structure in your file explorer. If there is a file misnamed the string resource tool will act this way too. The affected file will usually not show up in your IDE, so you'll have to browse the folders yourself to find it.

Message last modified on Oct 7, 2020 02:00PM

sm...@gmail.com <sm...@gmail.com> #25Oct 7, 2020 05:04PM

tried 4.2 canary 12... and it is still not working, so I will look at your suggestion.

sm...@gmail.com <sm...@gmail.com> #26Oct 7, 2020 05:09PM

what do you mean by "misnamed"?

they are all in folders: "values-XX" with one file "strings.xml"

found it, the folders were wrong, 2 had "value-xx"

Message last modified on Oct 7, 2020 05:23PM

Issue 145436360

Description

Issue summary

Comments

ju...@google.com <ju...@google.com> Dec 1, 2019 09:29PM

vi...@google.com <vi...@google.com> #2Dec 2, 2019 06:39AM

lb...@gmail.com <lb...@gmail.com> #3Dec 2, 2019 07:53AM

vi...@google.com <vi...@google.com> #4Dec 2, 2019 11:03AM

ju...@google.com <ju...@google.com> Dec 2, 2019 11:42AM

lb...@gmail.com <lb...@gmail.com> #5Dec 3, 2019 08:04AM

ju...@google.com <ju...@google.com> #6Dec 13, 2019 10:43PM

lb...@gmail.com <lb...@gmail.com> #7Dec 14, 2019 01:21PM

nd...@gmail.com <nd...@gmail.com> #8Dec 19, 2019 10:38AM

ng...@gmail.com <ng...@gmail.com> #9Apr 4, 2020 12:31PM

ju...@google.com <ju...@google.com> Apr 8, 2020 08:22PM

ju...@google.com <ju...@google.com> #10Apr 8, 2020 10:58PM

lb...@gmail.com <lb...@gmail.com> #11Apr 9, 2020 08:17AM

ju...@google.com <ju...@google.com> #12Apr 9, 2020 03:17PM

lb...@gmail.com <lb...@gmail.com> #13Apr 9, 2020 05:38PM

ju...@google.com <ju...@google.com> #14Apr 9, 2020 05:54PM

lb...@gmail.com <lb...@gmail.com> #15Apr 11, 2020 10:04PM

ju...@google.com <ju...@google.com> #16Apr 11, 2020 10:15PM

lb...@gmail.com <lb...@gmail.com> #17Apr 11, 2020 10:42PM

ju...@google.com <ju...@google.com> #18Apr 13, 2020 08:55PM

lb...@gmail.com <lb...@gmail.com> #19Apr 14, 2020 07:14AM

ju...@google.com <ju...@google.com> #20Apr 14, 2020 05:17PM

mr...@gmail.com <mr...@gmail.com> #21Jul 14, 2020 11:52AM

ow...@gmail.com <ow...@gmail.com> #22Sep 11, 2020 01:58PM

sm...@gmail.com <sm...@gmail.com> #23Oct 7, 2020 12:53PM

st...@gmail.com <st...@gmail.com> #24Oct 7, 2020 01:59PM

sm...@gmail.com <sm...@gmail.com> #25Oct 7, 2020 05:04PM

sm...@gmail.com <sm...@gmail.com> #26Oct 7, 2020 05:09PM

Add comment

Issue metadata